Bug #45767 deprecate/remove Field::pack_key, Field::unpack_key, Field::pack_cmp
Submitted: 25 Jun 2009 18:50 Modified: 7 Mar 2010 2:14
Reporter: Zardosht Kasheff (OCA) Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Storage Engines Severity:S4 (Feature request)
Version:5.1.35 OS:Any
Assigned to: Davi Arnaut CPU Architecture:Any
Tags: Contribution

[25 Jun 2009 18:50] Zardosht Kasheff 
Description:
The functions Field::pack_key, Field::unpack_key, and Field::pack_cmp are functions that are not used anywhere in MySQL and seem to have lots of bugs. We tried using them in our storage engine, and we had to reimplement these functions for Field_bit_as_char, Field_new_decimal, and Field_string. We no longer use these functions.

These functions may have been used in the original BDB handlerton, but they are not anymore. It would be nice to remove these all together so others do not try using them.

How to repeat:
n/a

Suggested fix:
remove them
[25 Jun 2009 21:18] Zardosht Kasheff 
patch showing which functions can be removed

Attachment: remove_pack_func.txt (text/plain), 14.30 KiB.
[25 Jun 2009 21:19] Zardosht Kasheff 
in patch, also removed pack_key_from_key_image
[25 Jun 2009 21:23] Zardosht Kasheff 
changed version to 5.1.35, that is what patch is built off of
[26 Jun 2009 12:27] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/77319

3398 Davi Arnaut	2009-06-26
      Bug#45767: deprecate/remove Field::pack_key, Field::unpack_key, Field::pack_cmp
      
      Remove unused and dead code.
      
      Parts of the patch contributed by Zardosht Kasheff
[26 Jun 2009 13:03] Davi Arnaut 
Queued to mysql-pe
[10 Jul 2009 11:21] Bugs System 
Pushed into 5.4.4-alpha (revid:anozdrin@bk-internal.mysql.com-20090710111017-bnh2cau84ug1hvei) (version source revid:davi.arnaut@sun.com-20090626124624-m4wolyo5193j4cu7) (merge vers: 5.4.4-alpha) (pib:11)
[14 Jul 2009 13:27] MC Brown 
Internal change only. No changelog entry required.
[10 Nov 2009 20:51] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/90009

2924 Davi Arnaut	2009-11-10
      Backport of Bug#45767 to mysql-next-mr
      ------------------------------------------------------------
      revno: 3405
      revision-id: davi.arnaut@sun.com-20090626124624-m4wolyo5193j4cu7
      parent: luis.soares@sun.com-20090626113019-1j4mn1jos480u9f3
      committer: Davi Arnaut <Davi.Arnaut@Sun.COM>
      branch nick: mysql-pe
      timestamp: Fri 2009-06-26 09:46:24 -0300
      message:
        Bug#45767: deprecate/remove Field::pack_key, Field::unpack_key, Field::pack_cmp
        
        Remove unused and dead code.
        
        Parts of the patch contributed by Zardosht Kasheff
[20 Nov 2009 12:53] Bugs System 
Pushed into 5.6.0-beta (revid:davi.arnaut@sun.com-20091119234808-xbjpkwaxjt5x5c0b) (version source revid:davi.arnaut@sun.com-20091119234808-xbjpkwaxjt5x5c0b) (merge vers: 5.6.0-beta) (pib:13)
[20 Nov 2009 12:56] Bugs System 
Pushed into 6.0.14-alpha (revid:kostja@sun.com-20091120124947-yi6h2jbgw0kbciwm) (version source revid:kostja@sun.com-20091119222407-5a7cjlhw06trtxnf) (merge vers: 6.0.14-alpha) (pib:13)
[30 Nov 2009 13:52] MC Brown 
Internal change only. No changelog entry required.
[6 Mar 2010 10:55] Bugs System 
Pushed into 5.5.3-m3 (revid:alik@sun.com-20100306103849-hha31z2enhh7jwt3) (version source revid:vvaintroub@mysql.com-20091120154107-6awpq04plug2xlri) (merge vers: 5.6.0-beta) (pib:16)
[7 Mar 2010 2:14] Paul DuBois 
No changelog entry needed.