Bug #45482 MTR2: --default-storage-engine=csv is rejected by mtr

• Submitted: 13 Jun 2009 8:26
• Modified: 14 Oct 2010 13:31
• Reporter: Guilhem Bichot
• Status: Closed
• Category: Tools: MTR / mysql-test-run
• Severity: S3 (Non-critical)
• Version: mysql-azalea
• OS: Linux
• Assigned to: Bjørn Munch
• CPU Architecture: Any

[13 Jun 2009 8:26] Guilhem Bichot

Description:
 ./mtr --mem --mysqld=--default-storage-engine=csv csv
says:
main.csv                                 [ skipped ]  'csv' not supported
It seems to be because of pieces like this in mtr_cases.pm:
    # =======================================================
    # Check that engine selected by
    # --default-storage-engine=<engine> is supported
    # =======================================================
	if ( ! exists $::mysqld_variables{$default_engine} and
	     ! exists $builtin_engines{$default_engine} )
	{
	  $tinfo->{'skip'}= 1;
	  $tinfo->{'comment'}=
	    "'$default_engine' not supported";
	}
builtin_engines is MyISAM and MEMORY. mysqld_variables{'csv'} does not exist because this hash is built by mtr by scanning the output of "../sql/mysqld --no-defaults --help --verbose" and inserting all displayed options in the hash; as there is no --csv option (you can't disable CSV at run time if it's compiled in, it seems), no 'csv' key in the hash.

How to repeat:
 ./mtr --mem --mysqld=--default-storage-engine=csv csv
This does not look like a duplicate of
http://bugs.mysql.com/bug.php?id=42642
(using --mysqld=--default-storage-engine=CSV doesn't change anything)

[10 Feb 2010 10:31] Bjørn Munch

Sorry this was overlooked and never got assigned to me.

Seems like the easy fix is to add csv to the list of builtin engines, but then the test fails:

mysqltest: At line 1560: query 'alter table t1 change v v2 varchar(32)' failed: 1178: The storage engine for the table doesn't support nullable columns

The test creates this table without specifying engine=csv so uses whatever is the default. Which is fine unless the default is csv...

[4 Mar 2010 10:11] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/102265

2899 Bjorn Munch	2010-03-04
      Bug #45482 MTR2: --default-storage-engine=csv is rejected by mtr
      Added csv to list of builtin engines
      Fixed dysfunctional part of csv.test so it actuallu used csv

[9 Mar 2010 15:00] Magnus Blåudd

ok

[9 Mar 2010 15:47] Bjørn Munch

Pushed to 5.1-mtr, trunk-mtr, next-mr-mtr, 6.0-codebase-mtr

[16 Aug 2010 6:29] Bugs System

Pushed into mysql-trunk 5.6.1-m4 (revid:[e-mail]-20100816062701-qo9dpnk5tkt1pksb) (version source revid:[e-mail]-20100816062603-xc16eftmv7rmktyq) (merge vers: 5.6.1-m4) (pib:20)

[16 Aug 2010 6:39] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100816062819-bluwgdq8q4xysmlg) (version source revid:[e-mail]-20100816062612-enatdwnv809iw3s9) (pib:20)

[16 Aug 2010 17:01] Paul DuBois

Test suite changes. No changelog entry needed.

[28 Sep 2010 8:47] Bugs System

Pushed into mysql-5.1 5.1.52 (revid:[e-mail]-20100928083322-wangbv97uobu7g66) (version source revid:[e-mail]-20100928083322-wangbv97uobu7g66) (merge vers: 5.1.52) (pib:21)

[14 Oct 2010 8:36] Bugs System

Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:[e-mail]-20101014082627-jrmy9xbfbtrebw3c) (version source revid:[e-mail]-20101014082627-jrmy9xbfbtrebw3c) (merge vers: 5.1.51-ndb-7.0.20) (pib:21)

[14 Oct 2010 8:51] Bugs System

Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:[e-mail]-20101014083757-5qo48b86d69zjvzj) (version source revid:[e-mail]-20101014083757-5qo48b86d69zjvzj) (merge vers: 5.1.51-ndb-6.3.39) (pib:21)

[14 Oct 2010 9:06] Bugs System

Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:[e-mail]-20101014084420-y54ecj85j5we27oa) (version source revid:[e-mail]-20101014084420-y54ecj85j5we27oa) (merge vers: 5.1.51-ndb-6.2.19) (pib:21)

[14 Oct 2010 13:31] Jon Stephens

Set back to Closed state without further action -- see previous comments.