MySQL Bugs: #45288: pb2 returns a lot of compilation warnings

Bug #45288	pb2 returns a lot of compilation warnings
Submitted:	3 Jun 2009 8:47	Modified:	20 Nov 2010 18:14
Reporter:	Georgi Kodinov	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Compiling	Severity:	S3 (Non-critical)
Version:		OS:	Any
Assigned to:	Davi Arnaut	CPU Architecture:	Any
Tags:	ProdEngPB2

Description:
We get 246 warnings on pb2's 'linux x86_64 gcov' host, 1279 warnings on the 'linux x86_64 max' host.

How to repeat:
Check the pb2 tree of 5.0-bugteam

Suggested fix:
Fix the warnings after making sure bugs #45286 and #45287 are fixed

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113040

3469 Davi Arnaut	2010-07-07
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Although the C standard mandates that sprintf return the number
      of bytes written, some very ancient systems (i.e. SunOS 4)
      returned a pointer to the buffer instead. Since these systems
      are not supported anymore and are hopefully long dead by now,
      simply remove the portability wrapper that dealt with this
      discrepancy. The autoconf check was causing trouble with GCC.

Queued to mysql-5.1-bugteam.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113408

3478 Davi Arnaut	2010-07-12
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Fix warnings flagged by the new warning option -Wunused-but-set-variable
      that was added to GCC 4.6 and that is enabled by -Wunused and -Wall. The
      option causes a warning whenever a local variable is assigned to but is
      later unused. It also warns about meaningless pointer dereferences.
     @ client/mysql.cc
        Meaningless pointer dereferences.
     @ client/mysql_upgrade.c
        Check whether reading from the file succeeded.
     @ client/mysqltest.cc
        Provided a error if connect option is not available.
     @ extra/comp_err.c
        Unused.
     @ extra/yassl/src/yassl_imp.cpp
        Skip instead of reading data that is discarded.
     @ include/my_pthread.h
        Variable is only used in debug builds.
     @ include/mysys_err.h
        Add new error messages.
     @ mysys/errors.c
        Add new error message for permission related functions.
     @ mysys/mf_iocache.c
        Variable is only checked under THREAD.
     @ mysys/my_copy.c
        Raise a error if chmod or chown fails.
     @ mysys/my_redel.c
        Raise a error if chmod or chown fails.
     @ regex/engine.c
        Use a equivalent variable for the assert.
     @ server-tools/instance-manager/instance_options.cc
        Unused.
     @ sql/field.cc
        Unused.
     @ sql/item.cc
        Unused.
     @ sql/log.cc
        Do not ignore the return value of freopen: only set buffer if
        reopening succeeds.
        
        Adjust doxygen comment to the right function.
        
        Pass message lenght to log function.
     @ sql/mysqld.cc
        Do not ignore the return value of freopen: only set buffer if
        reopening succeeds.
     @ sql/partition_info.cc
        Unused.
     @ sql/slave.cc
        No need to set pointer to the address of '\0'.
     @ sql/spatial.cc
        Unused. Left for historical purposes.
     @ sql/sql_acl.cc
        Unused.
     @ sql/sql_base.cc
        Pointers are always set to the same variables.
     @ sql/sql_parse.cc
        End statement if reading fails.
     @ sql/sql_repl.cc
        No need to set pointer to the address of '\0'.
     @ sql/sql_show.cc
        Put variable under the same ifdef block.
     @ sql/udf_example.c
        Set null pointer flag appropriately.
     @ storage/csv/ha_tina.cc
        Meaningless dereferences.
     @ storage/example/ha_example.cc
        Return the error since it's available.
     @ storage/myisam/mi_locking.c
        Remove unused and dead code.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113554

3111 Davi Arnaut	2010-07-14
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Fix compiler warnings due to: a mismatch in the prototypes for
      check_access and implicit conversions from double to ulonglong
      and vice-versa.
     @ mysys/my_getopt.c
        Use wrapper function that supposedly does the right thing.
     @ sql/sql_parse.h
        Make prototype equal to the case when not compiling under embedded.
     @ sql/sys_vars.cc
        Use wrapper to convert a double to a ulonglong.
     @ sql/sys_vars.h
        Use wrapper to convert a double to a ulonglong.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113694

3120 Davi Arnaut	2010-07-15
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Fix compiler warnings due to: a mismatch in the prototypes for
      check_access and implicit conversions from double to ulonglong
      and vice-versa.
     @ mysys/my_getopt.c
        Explicit conversion from ulonglong to double. Might need to
        be tweaked in the future.
     @ sql/sql_parse.h
        Make prototype equal to the case when not compiling under embedded.
     @ sql/sys_vars.cc
        Explicit conversion from ulonglong to double. Destination var
        is a ulonglong.
     @ sql/sys_vars.h
        Explicit conversion from ulonglong to double. Might need to
        be tweaked in the future.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113975

3495 Davi Arnaut	2010-07-20
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Fix warnings flagged by the new warning option -Wunused-but-set-variable
      that was added to GCC 4.6 and that is enabled by -Wunused and -Wall. The
      option causes a warning whenever a local variable is assigned to but is
      later unused. It also warns about meaningless pointer dereferences.
     @ client/mysql.cc
        Meaningless pointer dereferences.
     @ client/mysql_upgrade.c
        Check whether reading from the file succeeded.
     @ extra/comp_err.c
        Unused.
     @ extra/yassl/src/yassl_imp.cpp
        Skip instead of reading data that is discarded.
     @ include/my_pthread.h
        Variable is only used in debug builds.
     @ include/mysys_err.h
        Add new error messages.
     @ mysys/errors.c
        Add new error message for permission related functions.
     @ mysys/mf_iocache.c
        Variable is only checked under THREAD.
     @ mysys/my_copy.c
        Raise a error if chmod or chown fails.
     @ mysys/my_redel.c
        Raise a error if chmod or chown fails.
     @ regex/engine.c
        Use a equivalent variable for the assert.
     @ server-tools/instance-manager/instance_options.cc
        Unused.
     @ sql/field.cc
        Unused.
     @ sql/item.cc
        Unused.
     @ sql/log.cc
        Do not ignore the return value of freopen: only set buffer if
        reopening succeeds.
        
        Adjust doxygen comment to the right function.
        
        Pass message lenght to log function.
     @ sql/mysqld.cc
        Do not ignore the return value of freopen: only set buffer if
        reopening succeeds.
     @ sql/partition_info.cc
        Unused.
     @ sql/slave.cc
        No need to set pointer to the address of '\0'.
     @ sql/spatial.cc
        Unused. Left for historical purposes.
     @ sql/sql_acl.cc
        Unused.
     @ sql/sql_base.cc
        Pointers are always set to the same variables.
     @ sql/sql_parse.cc
        End statement if reading fails.
        
        Store the buffer after it has actually been updated.
     @ sql/sql_repl.cc
        No need to set pointer to the address of '\0'.
     @ sql/sql_show.cc
        Put variable under the same ifdef block.
     @ sql/udf_example.c
        Set null pointer flag appropriately.
     @ storage/csv/ha_tina.cc
        Meaningless dereferences.
     @ storage/example/ha_example.cc
        Return the error since it's available.
     @ storage/myisam/mi_locking.c
        Remove unused and dead code.

Queued to mysql-5.1-bugteam

Pushed into mysql-trunk 5.5.6-m3 (revid:alik@sun.com-20100723121820-jryu2fuw3pc53q9w) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:18)

Pushed into mysql-next-mr (revid:alik@sun.com-20100723121929-90e9zemk3jkr2ocy) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (pib:18)

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/114268

3325 Davi Arnaut	2010-07-23
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Fix assorted compiler warnings about unused variables, type
      mismatch and functions defined but not used.
     @ sql/binlog.cc
        Functions are only used if HAVE_REPLICATION.
     @ strings/ctype-czech.c
        Tag unused argument.
     @ strings/ctype-ucs2.c
        Cast to the expected type.
     @ strings/ctype.c
        Fix typo and cast to the expected type.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/114783

3469 Davi Arnaut	2010-07-30
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Tag unused parameters.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/114786

3469 Davi Arnaut	2010-07-30
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Fix compiler warnings.
     @ mysys/stacktrace.c
        Tag unused parameters.
     @ sql/sql_lex.cc
        Variable becomes unused in non-debug builds. Also, no need to
        assert the obvious.

Pushed into mysql-trunk 5.5.6-m3 (revid:alik@sun.com-20100731131027-1n61gseejyxsqk5d) (version source revid:alik@sun.com-20100731074942-o840woifuqioxxe4) (merge vers: 5.5.6-m3) (pib:18)

Pushed into mysql-trunk 5.5.6-m3 (revid:alik@sun.com-20100731131027-1n61gseejyxsqk5d) (version source revid:alik@sun.com-20100731074942-o840woifuqioxxe4) (merge vers: 5.5.6-m3) (pib:18)

Pushed into mysql-trunk 5.5.6-m3 (revid:alik@sun.com-20100731131027-1n61gseejyxsqk5d) (version source revid:alik@sun.com-20100731074942-o840woifuqioxxe4) (merge vers: 5.5.6-m3) (pib:18)

Pushed into mysql-trunk 5.5.6-m3 (revid:alik@sun.com-20100731131027-1n61gseejyxsqk5d) (version source revid:alik@sun.com-20100731074942-o840woifuqioxxe4) (merge vers: 5.5.6-m3) (pib:18)

Pushed into mysql-trunk 5.5.6-m3 (revid:alik@sun.com-20100731131027-1n61gseejyxsqk5d) (version source revid:alik@sun.com-20100731074942-o840woifuqioxxe4) (merge vers: 5.5.6-m3) (pib:18)

Pushed into mysql-trunk 5.5.6-m3 (revid:alik@sun.com-20100731131027-1n61gseejyxsqk5d) (version source revid:alik@sun.com-20100731074942-o840woifuqioxxe4) (merge vers: 5.5.6-m3) (pib:18)

Pushed into mysql-trunk 5.5.6-m3 (revid:alik@sun.com-20100731131027-1n61gseejyxsqk5d) (version source revid:alik@sun.com-20100731074942-o840woifuqioxxe4) (merge vers: 5.5.6-m3) (pib:18)

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804080001-bny5271e65xo34ig) (version source revid:alik@sun.com-20100731075120-qz9z8c25zum2wgmm) (merge vers: 5.6.99-m4) (pib:18)

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804080001-bny5271e65xo34ig) (version source revid:alik@sun.com-20100731075120-qz9z8c25zum2wgmm) (merge vers: 5.6.99-m4) (pib:18)

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804080001-bny5271e65xo34ig) (version source revid:alik@sun.com-20100731075120-qz9z8c25zum2wgmm) (merge vers: 5.6.99-m4) (pib:18)

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804080001-bny5271e65xo34ig) (version source revid:alik@sun.com-20100731075120-qz9z8c25zum2wgmm) (merge vers: 5.6.99-m4) (pib:18)

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804080001-bny5271e65xo34ig) (version source revid:alik@sun.com-20100731075120-qz9z8c25zum2wgmm) (merge vers: 5.6.99-m4) (pib:18)

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804080001-bny5271e65xo34ig) (version source revid:alik@sun.com-20100731075120-qz9z8c25zum2wgmm) (merge vers: 5.6.99-m4) (pib:18)

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804081533-c1d3rbipo9e8rt1s) (version source revid:alik@sun.com-20100731075120-qz9z8c25zum2wgmm) (merge vers: 5.6.99-m4) (pib:18)

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804081533-c1d3rbipo9e8rt1s) (version source revid:alik@sun.com-20100731075120-qz9z8c25zum2wgmm) (merge vers: 5.6.99-m4) (pib:20)

Pushed into mysql-next-mr (revid:alik@ibmvm-20100804081630-ntapn8bf9pko9vj3) (version source revid:alik@sun.com-20100731075120-qz9z8c25zum2wgmm) (pib:20)

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@sun.com-20100818071819-2lu46b0mm3cs34rf) (version source revid:alik@sun.com-20100818071732-g682fg1v0nnrrutx) (merge vers: 5.6.1-m4) (pib:20)

Pushed into mysql-next-mr (revid:alik@sun.com-20100818071923-4ounwbhiium2met1) (version source revid:alik@sun.com-20100818071743-lrzordai06i2crty) (pib:20)

Pushed into mysql-5.5 5.5.6-m3 (revid:alik@sun.com-20100818071719-dktnkvt8zvidj0sy) (version source revid:alik@sun.com-20100818071719-dktnkvt8zvidj0sy) (merge vers: 5.5.6-m3) (pib:20)

Pushed into mysql-5.1 5.1.51 (revid:build@mysql.com-20100819151858-muaaor6jojb5ouzj) (version source revid:build@mysql.com-20100819151858-muaaor6jojb5ouzj) (merge vers: 5.1.51) (pib:20)

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/119032

3517 Davi Arnaut	2010-09-24
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Temporarily disable strict aliasing warnings in order to get
      wider coverage for optimized builds. Once the violations are
      fixed and false-positives silenced, this flag should be removed.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/119093

3214 Davi Arnaut	2010-09-24
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Use UNINIT_VAR workaround instead of LINT_INIT. The former is
      also used in non-debug builds as it doesn't cause changes.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/119103

3518 Davi Arnaut	2010-09-24
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Use UNINIT_VAR workaround instead of LINT_INIT. The former can
      also be used to silence false-positives in non-debug builds as
      it actually does not cause new code to be generated.

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@sun.com-20100928153607-tdsxkdm5cmuym5sq) (version source revid:alik@sun.com-20100928153508-0saa6v93dinqx1u7) (merge vers: 5.6.1-m4) (pib:21)

Pushed into mysql-next-mr (revid:alik@sun.com-20100928153646-pqp8o1a92mxtuj3h) (version source revid:alik@sun.com-20100928153532-lr3gtvnyp2en4y75) (pib:21)

Pushed into mysql-5.5 5.5.7-rc (revid:alik@sun.com-20100928153459-4nudf4zgzlou4s7q) (version source revid:alik@sun.com-20100928153459-4nudf4zgzlou4s7q) (merge vers: 5.5.7-rc) (pib:21)

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/120332

3217 Davi Arnaut	2010-10-07
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Fix warnings related to the use of the deprecated gets() function
      and passing NULL to non-pointer argument of the sys_var constructor.
     @ plugin/auth/dialog.c
        Do not use the deprecated gets() function.
     @ sql/sys_vars.h
        Do not pass NULL to a non-pointer argument of the sys_var constructor.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/120393

3226 Davi Arnaut	2010-10-08
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Fix assorted compiler warnings.
     @ sql/mysqld.cc
        Do not declare max_page_size twice. If large pages support
        is enabled, the code expects the size in max_desired_page_size.
     @ storage/innobase/include/ibuf0ibuf.h
        Remove trailing comma. Only present in C99.
     @ storage/innobase/include/row0row.h
        Remove trailing comma. Only present in C99.
     @ strings/my_vsnprintf.c
        No need to assert the obvious.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/120394

3227 Davi Arnaut	2010-10-08
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Fix assorted compiler warnings.
     @ sql/mysqld.cc
        Do not declare max_page_size twice. If large pages support
        is enabled, the code expects the size in max_desired_page_size.
     @ storage/innobase/include/ibuf0ibuf.h
        Remove trailing comma. Only present in C99.
        
        Approved by: Vasil (via IRC)
     @ storage/innobase/include/row0row.h
        Remove trailing comma. Only present in C99.
        
        Approved by: Vasil (via IRC)
     @ strings/my_vsnprintf.c
        No need to assert the obvious.

Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (version source revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (merge vers: 5.1.51-ndb-7.0.20) (pib:21)

Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (version source revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (merge vers: 5.1.51-ndb-6.3.39) (pib:21)

Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (version source revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (merge vers: 5.1.51-ndb-6.2.19) (pib:21)

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121001

3533 Davi Arnaut	2010-10-18
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Enable the MySQL maintainer-specific development environment
      (which add various warning related options to the compiler
      flags) if debugging support is enabled.
     @ config/ac-macros/maintainer.m4
        Enable the maintainer mode if debug support is enabled.
     @ configure.in
        Move debug argument to before the maintainer mode check.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121151

3537 Davi Arnaut	2010-10-19
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Fix assorted compiler warnings on Mac OS X.
     @ BUILD/SETUP.sh
        Remove -Wctor-dtor-privacy flag to workaround a GCC bug that
        causes it to not properly detect that implicitly generated
        constructors are always public.
     @ cmd-line-utils/readline/terminal.c
        tgetnum and tgetflag might not take a const string argument.
     @ mysys/my_gethostbyname.c
        Tag unused arguments.
     @ mysys/my_sync.c
        Tag unused arguments.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121155

3538 Davi Arnaut	2010-10-19
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Tag unused arguments.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121158

3538 Davi Arnaut	2010-10-19
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Tag unused arguments.
      
      Approved by: Marko (via IRC)

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121160

3539 Davi Arnaut	2010-10-19
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Tag unused arguments.
            
      Approved by: Marko (via IRC)

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121180

3540 Davi Arnaut	2010-10-19
      Bug#45288: pb2 returns a lot of compilation warnings
      
      Ensure that fdatasync is properly declared as on Mac OS X, the
      function is available but there is no prototype. Also, port a
      fix for a warning from the InnoDB plugin over to the builtin. 
     @ configure.in
        Check that fdatasync is declared.
     @ mysys/my_sync.c
        Use fdatasync only if it is declared.
     @ storage/innobase/include/ut0dbg.h
        Port over from the plugin a fix for a warning.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121223

3541 Davi Arnaut	2010-10-19
      Bug#45288: pb2 returns a lot of compilation warnings
      
      Tag or remove unused arguments and variables.
     @ regex/main.c
        Use the real prototype.
     @ sql/ha_ndbcluster.cc
        Make conditions less ambiguous.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121330

3542 Davi Arnaut	2010-10-20
      Bug#45288: pb2 returns a lot of compilation warnings
      
      Fix assorted compiler warnings.
     @ include/my_pthread.h
        Like for pthread_cond_timedwait, the abstime is constant.
     @ mysys/my_gethwaddr.c
        Instead of using a manual copy that introduce warnings due to
        type mismatch, copy the buffer using memcpy and use memcmp to
        check whether all bytes of the buffer are zeroed.
     @ mysys/thr_mutex.c
        Like for pthread_cond_timedwait, the abstime is constant.
     @ unittest/mytap/tap.h
        Introduce a ok() variant that does not take a format argument.
        Since ok() is tagged with a printf attribute, GCC complains if
        the fmt argument is NULL.

Queued into mysql-5.1-bugteam and up.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121358

3283 Davi Arnaut	2010-10-20
      Bug#45288: pb2 returns a lot of compilation warnings
      
      Fix assorted compiler warnings.
     @ include/my_pthread.h
        Like for pthread_cond_timedwait, the abstime is constant.
     @ mysys/my_gethwaddr.c
        Instead of using a manual copy that introduce warnings due to
        type mismatch, copy the buffer using memcpy and use memcmp to
        check whether all bytes of the buffer are zeroed.
     @ mysys/thr_mutex.c
        Like for pthread_cond_timedwait, the abstime is constant.
     @ unittest/mytap/tap.h
        Introduce a ok() variant that does not take a format argument.
        Since ok() is tagged with a printf attribute, GCC complains if
        the fmt argument is NULL.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121382

3543 Davi Arnaut	2010-10-20
      Bug#45288: pb2 returns a lot of compilation warnings
      
      Fix assorted warnings that are generated in optimized builds. Most
      of it is silencing variables that are set but unused.
      
      This patch also introduces the MY_UNREACHABLE macro which helps
      the compiler to deduce that a certain piece of code is unreachable.
     @ include/my_compiler.h
        Use GCC's __builtin_unreachable if available. It allows the GCC
        to deduce the unreachability of certain code paths, thus avoiding
        warnings that, for example, accused that a variable could be used
        without being initialized.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121393

3543 Davi Arnaut	2010-10-20
      Bug#45288: pb2 returns a lot of compilation warnings
      
      Fix assorted warnings that are generated in optimized builds.
      Most of it is silencing variables that are set but unused.
      
      This patch also introduces the MY_ASSERT_UNREACHABLE macro
      which helps the compiler to deduce that a certain piece of
      code is unreachable.
     @ include/my_compiler.h
        Use GCC's __builtin_unreachable if available. It allows
        GCC to deduce the unreachability of certain code paths,
        thus avoiding warnings that, for example, accused that a
        variable could be used without being initialized (due to
        unreachable code paths).

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121774

3295 Tor Didriksen	2010-10-25
      Bug#45288: pb2 returns a lot of compilation warnings
     @ sql/rpl_slave.cc
        Fix inconsistent print format string.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121826

3269 Tor Didriksen	2010-10-25
      Bug#45288: pb2 returns a lot of compilation warnings
      
      sql/sql_lex.h:1437: warning: control reaches end of non-void function
     @ sql/sql_lex.h
        Make compiler happy, by adding a return statement.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/121830

3269 Tor Didriksen	2010-10-25
      Bug#45288: pb2 returns a lot of compilation warnings
      
      sql/sql_lex.h:1437: warning: control reaches end of non-void function
     @ sql/sql_lex.h
        Make compiler happy, by adding a return statement.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/122046

3294 Tor Didriksen	2010-10-27
      Bug#45288: pb2 returns a lot of compilation warnings
      
      DBG build broken on freebsd:
      storage/innobase/os/os0sync.c:171: warning: format '%lu' expects type 'long unsigned int', but argument 4 has type 'time_t'
     @ storage/innobase/os/os0sync.c
        Cast arguments to match format string.

No/minimal user impact. No changelog entry needed.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/122398

3309 Tor Didriksen	2010-11-01
      Bug#45288: pb2 returns a lot of compilation warnings
      
      DBG build broken on binary-werror-linux-x86_64-tar-gz
      storage/innobase/os/os0sync.c:659: warning: 'timed_out' may be used uninitialized in this function
     @ storage/innobase/os/os0sync.c
        Initialize auto-variable 'timed_out'.

Pushed into mysql-5.1 5.1.53 (revid:build@mysql.com-20101101184443-o2olipi8vkaxzsqk) (version source revid:build@mysql.com-20101101184443-o2olipi8vkaxzsqk) (merge vers: 5.1.53) (pib:21)

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/123051

3555 Jon Olav Hauglid	2010-11-08
      Bug #45288 pb2 returns a lot of compilation warnings
      
      GCOV builds were broken after the patch for Bug#57933
      which added add -Wdeclaration-after-statement to gcc builds.
      
      This patch fixes:
      stacktrace.c:328: warning: ISO C90 forbids mixed
      declarations and code
      
      No test case added.

GCOV patch pushed to 5.1-bugteam and merged to 5.5-bugteam and trunk-bugfixing.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/123109

3556 Jon Olav Hauglid	2010-11-08
      Bug #45288 pb2 returns a lot of compilation warnings
      
      GCOV builds were broken after the patch for Bug#57933
      which added add -Wdeclaration-after-statement to gcc builds.
      
      This patch fixes:
      stacktrace.c:328: warning: ISO C90 forbids mixed
      declarations and code
      
      No test case added.

Pushed into mysql-5.5 5.5.7-rc (revid:sunanda.menon@sun.com-20101109182959-otkxq8vo2dcd13la) (version source revid:sunanda.menon@sun.com-20101109182959-otkxq8vo2dcd13la) (merge vers: 5.5.7-rc) (pib:21)

Pushed into mysql-trunk 5.6.99-m5 (revid:alexander.nozdrin@oracle.com-20101113155825-czmva9kg4n31anmu) (version source revid:vasil.dimov@oracle.com-20100629074804-359l9m9gniauxr94) (merge vers: 5.6.99-m4) (pib:21)

Pushed into mysql-next-mr (revid:alexander.nozdrin@oracle.com-20101113160336-atmtmfb3mzm4pz4i) (version source revid:alexander.nozdrin@oracle.com-20101113152540-gxro4g0v29l27f5x) (pib:21)

Pushed into mysql-5.1 5.1.54 (revid:build@mysql.com-20101118153531-693taxtxyxpt037i) (version source revid:build@mysql.com-20101118153531-693taxtxyxpt037i) (merge vers: 5.1.54) (pib:21)

No changelog entry needed.

Pushed into mysql-5.1 5.1.55 (revid:sunanda.menon@oracle.com-20101215054055-vgwki317xg1wphhh) (version source revid:sunanda.menon@oracle.com-20101215054055-vgwki317xg1wphhh) (merge vers: 5.1.55) (pib:23)

Pushed into mysql-5.5 5.5.9 (revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (version source revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (merge vers: 5.5.9) (pib:24)