Bug #45253 Backup: many backup tests should be changed to not rely on Falcon
Submitted: 2 Jun 2009 6:08 Modified: 9 Jul 2009 16:30
Reporter: Jørgen Løland Email Updates:
Status: Closed Impact on me:
None 
Category:Tests: Server Severity:S3 (Non-critical)
Version:6.0 OS:Any
Assigned to: Jørgen Løland CPU Architecture:Any

[2 Jun 2009 6:08] Jørgen Løland 
Description:
Many backup tests rely on Falcon, which means that they are not run since Falcon is not in mysql-azalea. These tests should be modified to use other storage engines where this makes sense.

How to repeat:
Look at test execution log in PB and modify all tests skipped because it needs Falcon (Falcon is currently not in mysql-6.0-backup

Suggested fix:
Use other storage engines and remove have_falconl.inc from the test header.
[25 Jun 2009 8:31] Jørgen Løland 
This is the list of tests that rely on falcon: 

suite/backup/t/backup_object_count.test
suite/backup/t/backup_commit_backup.test
suite/backup/t/backup_default.test
suite/backup/t/backup_compression_non_win.test
suite/backup/t/backup_lock_conflict.test
suite/backup/t/backup_compression.test
suite/backup/t/backup_client.test
suite/backup/t/backup_check_i_s.test
suite/backup/t/backup_tablespace.test
suite/backup/t/backup_bml.test
suite/backup/t/backup_external_non_win.test
suite/backup/t/backup_default_debug.test
suite/backup/t/backup_commit_restore.test
[25 Jun 2009 9:32] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/77128

2833 Jorgen Loland	2009-06-25
      Bug#45253 - Backup: many backup tests should be changed to not rely on Falcon
      
      Many backup tests rely on Falcon, which means that they are not
      run since Falcon is not in mysql-azalea. These tests should be
      modified to use other storage engines where this makes sense.
      
      Part 1 - tests modified by this patch:
      --------------------------------------
      suite/backup/t/backup_commit_backup.test
      suite/backup/t/backup_compression.test
      suite/backup/t/backup_compression_non_win.test
      suite/backup/t/backup_default.test
      suite/backup/t/backup_lock_conflict.test
      suite/backup/t/backup_object_count.test
     @ mysql-test/suite/backup/r/backup_commit_backup.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_commit_backup_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_compression.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_compression_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_compression_non_win.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_compression_non_win_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_lock_conflict.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_lock_conflict_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_object_count.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_object_count_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_commit_backup.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_commit_backup_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_compression.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_compression_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_compression_non_win.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_compression_non_win_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_default.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_lock_conflict.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_lock_conflict_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_object_count.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_object_count_falcon.test
        Falcon version of test with same name
[26 Jun 2009 9:32] Ingo Strüwing 
Approved. No comments. All looks fine.
[26 Jun 2009 13:18] Rafal Somla 
Good to push.
[26 Jun 2009 13:24] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/77324

2835 Jorgen Loland	2009-06-26
      Bug#45253 - Backup: many backup tests should be changed to not rely on Falcon
            
      Many backup tests rely on Falcon, which means that they are not
      run since Falcon is not in mysql-azalea. These tests should be
      modified to use other storage engines where this makes sense.
            
      Part 1 - tests modified by this patch:
      --------------------------------------
      suite/backup/t/backup_commit_backup.test
      suite/backup/t/backup_compression.test
      suite/backup/t/backup_compression_non_win.test
      suite/backup/t/backup_default.test
      suite/backup/t/backup_lock_conflict.test
      suite/backup/t/backup_object_count.test
     @ mysql-test/suite/backup/r/backup_commit_backup.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_commit_backup_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_compression.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_compression_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_compression_non_win.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_compression_non_win_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_lock_conflict.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_lock_conflict_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_object_count.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_object_count_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_commit_backup.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_commit_backup_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_compression.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_compression_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_compression_non_win.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_compression_non_win_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_default.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_lock_conflict.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_lock_conflict_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_object_count.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_object_count_falcon.test
        Falcon version of test with same name
[26 Jun 2009 13:27] Jørgen Løland 
Set state to In Progress, and removed patch approval tick since there will be another patch for this bug
[29 Jun 2009 7:05] Jørgen Løland 
Test files not made independent on Falcon in the first patch:

suite/backup/t/backup_client.test
suite/backup/t/backup_check_i_s.test
suite/backup/t/backup_tablespace.test
suite/backup/t/backup_bml.test
suite/backup/t/backup_external_non_win.test
suite/backup/t/backup_default_debug.test
suite/backup/t/backup_commit_restore.test
[29 Jun 2009 8:59] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/77429

2836 Jorgen Loland	2009-06-29
      Bug#45253 - Backup: many backup tests should be changed to not
      rely on Falcon
      
      Many backup tests rely on Falcon, which means that they are not
      run since Falcon is not in mysql-azalea. These tests should be
      modified to use other storage engines where this makes sense.
      
      Part 2 - tests modified by this patch:
      --------------------------------------
      suite/backup/t/backup_client.test
      suite/backup/t/backup_check_i_s.test
      suite/backup/t/backup_bml.test
      suite/backup/t/backup_external_non_win.test
      suite/backup/t/backup_default_debug.test
      suite/backup/t/backup_falcon_debug.test
      suite/backup/t/backup_commit_restore.test
     @ mysql-test/include/not_falcon.inc
        Include file that makes tests execute only if Falcon is not available in the server.
     @ mysql-test/suite/backup/r/backup_bml_not_falcon.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_check_i_s.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_client.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_client_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_commit_restore.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_commit_restore_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_default_debug.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_external_non_win_not_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_falcon_debug.result
        New test for Falcon with dbug sync points
     @ mysql-test/suite/backup/t/backup_bml.test
        Added note about backup_bml_not_falcon.test
     @ mysql-test/suite/backup/t/backup_bml_not_falcon.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_check_i_s.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_client.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_client_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_commit_restore.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_commit_restore_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_default_debug.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_external_non_win_not_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_falcon_debug.test
        New test for Falcon with dbug sync points
[30 Jun 2009 7:25] Rafal Somla 
2nd patch good to push.
[30 Jun 2009 7:51] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/77508

2837 Jorgen Loland	2009-06-30
      Bug#45253 - Backup: many backup tests should be changed to not
      rely on Falcon
            
      Many backup tests rely on Falcon, which means that they are not
      run since Falcon is not in mysql-azalea. These tests should be
      modified to use other storage engines where this makes sense.
            
      Part 2 - tests modified by this patch:
      --------------------------------------
      suite/backup/t/backup_client.test
      suite/backup/t/backup_check_i_s.test
      suite/backup/t/backup_bml.test
      suite/backup/t/backup_external_non_win.test
      suite/backup/t/backup_default_debug.test
      suite/backup/t/backup_falcon_debug.test
      suite/backup/t/backup_commit_restore.test
     @ mysql-test/include/not_falcon.inc
        Include file that makes tests execute only if Falcon is not available in the server.
     @ mysql-test/suite/backup/r/backup_bml_not_falcon.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_check_i_s.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_client.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_client_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_commit_restore.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_commit_restore_falcon.result
        Falcon version of test with same name
     @ mysql-test/suite/backup/r/backup_default_debug.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_external_non_win_not_falcon.result
        Make test independant of Falcon
     @ mysql-test/suite/backup/r/backup_falcon_debug.result
        New test for Falcon with dbug sync points
     @ mysql-test/suite/backup/t/backup_bml.test
        Added note about backup_bml_not_falcon.test
     @ mysql-test/suite/backup/t/backup_bml_not_falcon.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_check_i_s.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_client.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_client_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_commit_restore.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_commit_restore_falcon.test
        Falcon version of test with same name
     @ mysql-test/suite/backup/t/backup_default_debug.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_external_non_win_not_falcon.test
        Make test independant of Falcon
     @ mysql-test/suite/backup/t/backup_falcon_debug.test
        New test for Falcon with dbug sync points
[30 Jun 2009 7:54] Jørgen Løland 
Patch 2 pushed with changes requested from reviewers. All test files that rely on Falcon have now been changed with the exception of

suite/backup/t/backup_tablespace.test

Since we can only create tablespaces using Falcon (and NDB, which is not backed up), this test does not make sense without Falcon.
[7 Jul 2009 14:09] Bugs System 
Pushed into 5.4.4-alpha (revid:alik@sun.com-20090707140519-svplog8kcfejbzbe) (version source revid:ingo.struewing@sun.com-20090702190828-8iscrkt20e8g5dtt) (merge vers: 5.4.4-alpha) (pib:11)
[9 Jul 2009 7:36] Bugs System 
Pushed into 5.4.4-alpha (revid:alik@sun.com-20090707140519-svplog8kcfejbzbe) (version source revid:ingo.struewing@sun.com-20090702190828-8iscrkt20e8g5dtt) (merge vers: 5.4.4-alpha) (pib:11)
[9 Jul 2009 16:30] Paul DuBois 
Test case changes. No changelog entry needed.