Bug #44964 mysqltest: connection <connection><some spaces>; fails now

• Submitted: 19 May 2009 19:52
• Modified: 18 Jun 2009 15:31
• Reporter: Matthias Leich
• Status: Closed
• Category: Tools: MTR / mysql-test-run
• Severity: S3 (Non-critical)
• OS: Any
• Assigned to: Bjørn Munch
• CPU Architecture: Any

[19 May 2009 19:52] Matthias Leich

Description:
When trying to execute the NIST test adjusted to
MySQL many changes of the connection fail.

Typical error message:
mysqltest: At line 3: connection 'default ' not found in connection pool

The reason:
   connection default ;
is no more accepted.
   connect default;
# Without spaces between "default" and "," works.

This is IMHO a very unfortunate change in behaviour.

The NIST tests worked fine in autumn 2008.
Please change this behaviour!
It's absolute no fun to change
~ 140 lines of code because of connection ...
in addition to the
~ 5000 - 6000 lines because of now forbidden
  comment starting with "--"

How to repeat:
connection default;
--echo # "connection default;" worked
connection default ;
--echo # "connection default ;" worked

[22 May 2009 13:14] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/74783

2794 Bjorn Munch	2009-05-22
      Bug #44964 mysqltest: connection <connection><some spaces>; fails now
      Incorrection assumption about delimiter character in connection command
      modified:
        client/mysqltest.cc

[22 May 2009 13:17] Bjørn Munch

select_connection() incorrectly sent ',' as last argument to check_command_args(), making it look for a comma (which shouldn't be there) as delimiter character after connection name.

Fixed by replacing ',' with ' '.

[26 May 2009 10:50] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/74951

2795 Bjorn Munch	2009-05-26
      Bug #44964 mysqltest: connection <connection><some spaces>; fails now
      Incorrection assumption about delimiter character in connection command
      modified:
        client/mysqltest.cc

[26 May 2009 10:52] Bjørn Munch

Pushed to 5.1-mtr

[5 Jun 2009 8:04] Bugs System

Pushed into 5.1.36 (revid:[e-mail]-20090605074215-1d7l2reqdb9a0t0t) (version source revid:[e-mail]-20090605074215-1d7l2reqdb9a0t0t) (merge vers: 5.1.36) (pib:6)

[5 Jun 2009 15:32] Paul DuBois

Test suite changes. No changelog entry needed.

Setting report to NDI pending push into 6.0.x.

[17 Jun 2009 19:26] Bugs System

Pushed into 5.4.4-alpha (revid:[e-mail]-20090616183122-chjzbaa30qopdra9) (version source revid:[e-mail]-20090609174954-3ao9iz97nzrfg9yl) (merge vers: 5.4.4-alpha) (pib:11)

[18 Jun 2009 15:31] Paul DuBois

Test suite changes. No changelog entry needed.

[26 Aug 2009 13:46] Bugs System

Pushed into 5.1.37-ndb-7.0.8 (revid:[e-mail]-20090826132541-yablppc59e3yb54l) (version source revid:[e-mail]-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)

[26 Aug 2009 13:46] Bugs System

Pushed into 5.1.37-ndb-6.3.27 (revid:[e-mail]-20090826105955-bkj027t47gfbamnc) (version source revid:[e-mail]-20090826105955-bkj027t47gfbamnc) (merge vers: 5.1.37-ndb-6.3.27) (pib:11)

[26 Aug 2009 13:48] Bugs System

Pushed into 5.1.37-ndb-6.2.19 (revid:[e-mail]-20090825194404-37rtosk049t9koc4) (version source revid:[e-mail]-20090825194404-37rtosk049t9koc4) (merge vers: 5.1.37-ndb-6.2.19) (pib:11)

[27 Aug 2009 16:33] Bugs System

Pushed into 5.1.35-ndb-7.1.0 (revid:[e-mail]-20090827163030-6o3kk6r2oua159hr) (version source revid:[e-mail]-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)