Bug #44641 '\r'-ended lines in sql/Makefile.am, libmysqld/Makefile.am
Submitted: 4 May 2009 11:43 Modified: 21 May 2009 2:31
Reporter: Dmitry Lenev Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server Severity:S3 (Non-critical)
Version:6.0.12-bzr OS:Any
Assigned to: Sergei Golubchik CPU Architecture:Any
Triage: Triaged: D1 (Critical)

[4 May 2009 11:43] Dmitry Lenev
Description:
Recently someone pushed into 6.0 tree changeset that added '\r' aka ^M to ends of all lines in sql/Makefile.am and libmysqld/Makefile.am. This contradicts our coding guidelines which say:
(see http://forge.mysql.com/wiki/MySQL_Internals_Coding_Guidelines)

"Use line feed (\n) for line breaks. Do not use carriage return + line feed (\r\n); that can cause problems for other users and for builds. This rule is particularly important if you use a Windows editor."

This also has messed up revision history.

How to repeat:
Inspect the contents of sql/Makefile.am and libmysqld/Makefile.am.
[4 May 2009 11:55] Sveta Smirnova
Thank you for the report.

Verified as described.
[4 May 2009 15:52] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/73322

2752 Sergei Golubchik	2009-05-04
      Bug#44641 - '\r'-ended lines in sql/Makefile.am, libmysqld/Makefile.am
[16 May 2009 8:41] Bugs System
Pushed into 6.0.12-alpha (revid:alik@sun.com-20090516083402-0avycdy7w6dnn0tv) (version source revid:serg@mysql.com-20090504155155-iz0bu519x3tpg5qz) (merge vers: 6.0.11-alpha) (pib:6)
[21 May 2009 2:31] Paul Dubois
No changelog entry needed.