Bug #44608 | Remove C++ comments from C code in backup | ||
---|---|---|---|
Submitted: | 1 May 2009 15:03 | Modified: | 3 Jun 2009 23:33 |
Reporter: | Chuck Bell | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | MySQL Server: Backup | Severity: | S3 (Non-critical) |
Version: | 6.0.11 | OS: | Any |
Assigned to: | Chuck Bell | CPU Architecture: | Any |
[1 May 2009 15:03]
Chuck Bell
[1 May 2009 15:20]
Chuck Bell
See this for a sample patch: http://lists.mysql.com/commits/73153
[7 May 2009 20:16]
Omer Barnir
triage: setting tag to SR0BETA and and I2/P1 a affects our dev systems and compiling on supported platforms
[7 May 2009 23:47]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/73624 2808 Chuck Bell 2009-05-07 BUG#44608 : Remove C++ comments from C code in backup The backup code uses C++ comments '// some comment' in its C code modules (*.c). These comments must be change to C-style comments '/* some comment */'. This is needed to help product development build the MySQL code for platforms that have stricter C compiler enforcement (do not have C99 turned on). This patch changes all C++-style comments to C-style comments in the *.c source files for backup. modified: client/backup_stream.c sql/backup/stream_v1.c
[8 May 2009 15:18]
Ingo Strüwing
Back to "in progress". Please find requests by email.
[18 May 2009 19:37]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/74408 2808 Chuck Bell 2009-05-18 BUG#44608 : Remove C++ comments from C code in backup The backup code uses C++ comments '// some comment' in its C code modules (*.c). These comments must be change to C-style comments '/* some comment */'. This is needed to help product development build the MySQL code for platforms that have stricter C compiler enforcement (do not have C99 turned on). This patch changes all C++-style comments to C-style comments in the *.c source files for backup. modified: client/backup_stream.c sql/backup/stream_v1.c sql/backup/stream_v1.h sql/backup/stream_v1_transport.c
[19 May 2009 8:19]
Ingo Strüwing
Approved
[20 May 2009 6:59]
Rafal Somla
Good to push.
[20 May 2009 16:10]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/74623 2702 Chuck Bell 2009-05-20 BUG#44608 : Remove C++ comments from C code in backup The backup code uses C++ comments '// some comment' in its C code modules (*.c). These comments must be change to C-style comments '/* some comment */'. This is needed to help product development build the MySQL code for platforms that have stricter C compiler enforcement (do not have C99 turned on). This patch changes all C++-style comments to C-style comments in the *.c source files for backup. modified: client/backup_stream.c sql/backup/stream_v1.c sql/backup/stream_v1.h sql/backup/stream_v1_transport.c
[3 Jun 2009 7:12]
Jørgen Løland
Merged to azalea June 2
[3 Jun 2009 23:33]
Paul DuBois
Cosmetic changes. No changelog entry needed.