MySQL Bugs: #44561: mtr2 --start-dirty is broken

Bug #44561	mtr2 --start-dirty is broken
Submitted:	29 Apr 2009 21:40	Modified:	29 May 2009 1:14
Reporter:	Omer Barnir (OCA)	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tools: MTR / mysql-test-run	Severity:	S7 (Test Cases)
Version:	5.1/6.0	OS:	Any
Assigned to:	Bjørn Munch	CPU Architecture:	Any

Description:
When using mtr2 the --start-dirty option is not working correctly and is resetting the mysql database. As a result objects stored in the mysql database (stored procedures, users etc.) are not preserved.

Other objects (user defined databases and tables) are preserved.

How to repeat:
Start the server using mtr2 with --start &
Using the mysql client create a a stored procedure 
Run select count(*) from mysql.proc 
>> you should get 4 - three pre-defiled in the mtr db and the one just created.
Shut down the system and restart it with --start-dirty
Log in with the mysql client and observe that the procedure defined is not present
(select count(*) from mysql.proc returns 3 - the pre-defined ones

Suggested fix:
the mysql database should be preserved when running with the --start-dirty option

From a chat with Magnus:
[13:59]	<magnus>	./mtr alias --start-dirty --verbose
	I see printout
	worker[1] > Cleaning datadirs...
	that is not a good sign...

This affects stored procedures but not tables. The data directory is *not* deleted.

Even if I try to create a stored procedure exactly like mtr does it (just a different name), that proc is gone when the server is restarted, but the 4 procs created my mtr are left.  No, they are *not* re-created.

By watching the size of var/mysqld.1/data/mysql/proc.MYD, I see that it keeps its size when I stop the first server, but shrinks a bit when the new server is started.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/73123

2787 Bjorn Munch	2009-04-30
      Bug #44561 mtr2 --start-dirty is broken
      start-dirty would remove stored procs etc.
      Skip the copying back from stored system dir if using --start-dirty
      modified:
        mysql-test/mysql-test-run.pl

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/73125

2787 Bjorn Munch	2009-04-30
      Bug #44561 mtr2 --start-dirty is broken
      start-dirty would remove stored procs etc.
      Put the copying back from stored system dir inside if (! $opt_start_dirty)
      modified:
        mysql-test/mysql-test-run.pl

Sorry for the double commit, there was some hiccup

Pushed to 6.0-mtr and 5.1-mtr

Pushed into 6.0.12-alpha (revid:alik@sun.com-20090514161729-xiup7q8jlu1zfy7s) (version source revid:bjorn.munch@sun.com-20090505094251-ck1y1sme0dtoulis) (merge vers: 6.0.12-alpha) (pib:6)

Test suite changes. No changelog entry needed.

Setting report to NDI pending push into 5.1.x.

Pushed into 5.1.36 (revid:joro@sun.com-20090528073639-yohsb4q1jzg7ycws) (version source revid:bjorn.munch@sun.com-20090525205831-zitq9aysxy5zgf5r) (merge vers: 5.1.36) (pib:6)

Test suite change. No changelog entry needed.

Pushed into 5.1.37-ndb-7.0.8 (revid:jonas@mysql.com-20090826132541-yablppc59e3yb54l) (version source revid:jonas@mysql.com-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)

Pushed into 5.1.37-ndb-6.3.27 (revid:jonas@mysql.com-20090826105955-bkj027t47gfbamnc) (version source revid:jonas@mysql.com-20090826105955-bkj027t47gfbamnc) (merge vers: 5.1.37-ndb-6.3.27) (pib:11)

Pushed into 5.1.37-ndb-6.2.19 (revid:jonas@mysql.com-20090825194404-37rtosk049t9koc4) (version source revid:jonas@mysql.com-20090825194404-37rtosk049t9koc4) (merge vers: 5.1.37-ndb-6.2.19) (pib:11)

Pushed into 5.1.35-ndb-7.1.0 (revid:magnus.blaudd@sun.com-20090827163030-6o3kk6r2oua159hr) (version source revid:jonas@mysql.com-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)