MySQL Bugs: #44222: mysql-test-run --start analyses which tests it would skip. This is redundant.

Bug #44222	mysql-test-run --start analyses which tests it would skip. This is redundant.
Submitted:	12 Apr 2009 14:49	Modified:	18 Dec 2009 20:48
Reporter:	Sergey Petrunya	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tools: MTR / mysql-test-run	Severity:	S3 (Non-critical)
Version:	5.1	OS:	Any
Assigned to:	Bjørn Munch	CPU Architecture:	Any

Description:
mysql-test-run --start analyses which tests it would skip. It would be better if 
- it didn't perform analysis of which tests it would need to skip (since it's not going to run any anyway)
- it printed ports and socket paths of the servers it has started.

[spetrunia@dl145s mysql-test]$ ./mysql-test-run --start
Logging: ./mysql-test-run  --start
090412 17:20:16 [Warning] Forcing shutdown of 2 plugins
MySQL Version 5.1.33
Checking supported features...
 - using ndbcluster when necessary, mysqld supports it
 - SSL connections supported
 - binaries are debug compiled
Collecting tests...
 - adding combinations for binlog
 - adding combinations for rpl
vardir: /data0/spetrunia/bzr/mysql-5.1-bugteam-look/mysql-test/var
Removing old var directory...
Creating var directory '/data0/spetrunia/bzr/mysql-5.1-bugteam-look/mysql-test/var'...
Installing system database...
Using server port 33825

==============================================================================

TEST                                      RESULT   TIME (ms)
------------------------------------------------------------

worker[1] Using MTR_BUILD_THREAD 250, with reserved ports 12500..12509
rpl_ndb.rpl_ndb_2myisam                  [ skipped ]  'ndbcluster' not supported
rpl_ndb.rpl_ndb_2innodb                  [ skipped ]  'ndbcluster' not supported
rpl_ndb.rpl_truncate_7ndb_2              [ skipped ]  Test need 'big-test' option
binlog.binlog_row_innodb_stat 'stmt'     [ skipped ]  Doesn't support --binlog-format='statement'
binlog.binlog_row_innodb_stat 'mix'      [ skipped ]  Doesn't support --binlog-format='mixed'
binlog.binlog_stm_innodb_stat 'row'      [ skipped ]  Doesn't support --binlog-format='row'
binlog.binlog_stm_innodb_stat 'mix'      [ skipped ]  Doesn't support --binlog-format='mixed'
rpl.rpl_row_basic_11bugs 'stmt'          [ skipped ]  Doesn't support --binlog-format='statement'
rpl.rpl_row_basic_11bugs 'mix'           [ skipped ]  Doesn't support --binlog-format='mixed'
rpl.rpl_innodb_bug28430 'stmt'           [ skipped ]  Doesn't support --binlog-format='statement'
...
a couple of strings here 
...
rpl.rpl_binlog_corruption                [ disabled ]  BUG#41793 2008-12-30 sven rpl_binlog_corruption disabled in main (needs new mtr)

worker[1] 
Started [mysqld.1.1 - pid: 4966, winpid: 4966] [mysqld.2.1 - pid: 4969, winpid: 4969] [ndb_mgmd.1.1 - pid: 4940, winpid: 4940] [ndbd.1.
1 - pid: 4958, winpid: 4958] [ndbd.2.1 - pid: 4959, winpid: 4959]
worker[1] Waiting for server(s) to exit...

How to repeat:
Run mysql-test-run --start.

Suggested fix:
see above

Thank you for the problem report.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/80824

2816 Bjorn Munch	2009-08-14
      Bug #44222 mysql-test-run --start analyses which tests it would skip. This is redundant.
      Quicker test collection and better output with --start[-dirty]

MTR should still check for tests to be skipped, so that it doesn't "start" a test which is incompatible.

But I have speeded up test "collection": it stops once it has found a test not to be skipped, does not reorder or add combinations, and also prints some more info as requested.

Using --start with an explicit test name will of course "start" that test as before.

I don't see a reason against this change.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/80972

2817 Bjorn Munch	2009-08-18
      Bug #44222 mysql-test-run --start analyses which tests it would skip. This is redundant.
      Quicker test collection and better output with --start[-dirty]

Pushed to 5.1-mtr and azalea-mtr

Pushed into 5.1.40 (revid:bjorn.munch@sun.com-20090903170735-679d64zp580wl39j) (version source revid:bjorn.munch@sun.com-20090903170735-679d64zp580wl39j) (merge vers: 5.1.40) (pib:11)

Test suite change. No changelog entry needed.

Setting report to NDI pending push into 5.4.x.

Pushed into 6.0.14-alpha (revid:alik@sun.com-20090929093622-1mooerbh12e97zux) (version source revid:alik@sun.com-20090922182109-vs5ign07cwht12z6) (merge vers: 6.0.14-alpha) (pib:11)

Pushed into 5.4.5-beta (revid:alik@sun.com-20090925094254-tjl9eajkzwzgthoe) (version source revid:alik@sun.com-20090922142453-x275o41whpyezh4q) (merge vers: 5.4.4-beta) (pib:11)

Test suite change. No changelog entry needed.

Pushed into 5.1.41-ndb-7.1.0 (revid:jonas@mysql.com-20091218102229-64tk47xonu3dv6r6) (version source revid:jonas@mysql.com-20091218095730-26gwjidfsdw45dto) (merge vers: 5.1.41-ndb-7.1.0) (pib:15)

Pushed into 5.1.41-ndb-6.2.19 (revid:jonas@mysql.com-20091218100224-vtzr0fahhsuhjsmt) (version source revid:jonas@mysql.com-20091217101452-qwzyaig50w74xmye) (merge vers: 5.1.41-ndb-6.2.19) (pib:15)

Pushed into 5.1.41-ndb-6.3.31 (revid:jonas@mysql.com-20091218100616-75d9tek96o6ob6k0) (version source revid:jonas@mysql.com-20091217154335-290no45qdins5bwo) (merge vers: 5.1.41-ndb-6.3.31) (pib:15)

Pushed into 5.1.41-ndb-7.0.11 (revid:jonas@mysql.com-20091218101303-ga32mrnr15jsa606) (version source revid:jonas@mysql.com-20091218064304-ezreonykd9f4kelk) (merge vers: 5.1.41-ndb-7.0.11) (pib:15)