MySQL Bugs: #44001: Usage of pin / pinbox for the lock free hash

Bug #44001	Usage of pin / pinbox for the lock free hash
Submitted:	31 Mar 2009 21:43	Modified:	14 Jan 2010 18:02
Reporter:	Marc ALFF	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Performance Schema	Severity:	S3 (Non-critical)
Version:	mysql-6.0-perf	OS:	Any
Assigned to:	Marc ALFF	CPU Architecture:	Any

Description:
The calls to lf_hash_search / lf_hash_insert don't use the pins and pin box properly.

How to repeat:
Found by code review

Also,
- the file delete instrumentation should remove entries from the file hash,
- likewise for table drop and the table name hash

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/75764

3165 Marc Alff	2009-06-05
      Bug#44001 Usage of pin / pinbox for the lock free hash
      
      Revised usage of LF_HASH in the performance schema code,
      per discussion during code review.
      modified:
        mysql-test/suite/perfschema/r/start_server32_off.result
        mysql-test/suite/perfschema/r/start_server32_on.result
        mysql-test/suite/perfschema/r/start_server64_off.result
        mysql-test/suite/perfschema/r/start_server64_on.result
        storage/perfschema/pfs.cc
        storage/perfschema/pfs_instr.cc
        storage/perfschema/pfs_instr.h
        storage/perfschema/pfs_instr_class.cc
        storage/perfschema/pfs_instr_class.h
        storage/perfschema/pfs_lock.h
        storage/perfschema/unittest/pfs_instr-t.cc
        storage/perfschema/unittest/pfs_instr_class-t.cc

Approved. I have informed Marc of a last question which needs a reply (regarding how infinite loops could happen).

Merged in:
- mysql-next-mr (Celosia / 5.5.99-m3)
- mysql-6.0-codebase (6.0.14)

Not in any released version. No changelog entry needed.