Bug #43840 "too many tests failed" includes retries

• Submitted: 24 Mar 2009 18:45
• Modified: 29 May 2009 1:12
• Reporter: Daniel Fischer
• Status: Closed
• Category: Tools: MTR / mysql-test-run
• Severity: S7 (Test Cases)
• Version: 5.1+
• OS: Any
• Assigned to: Bjørn Munch
• CPU Architecture: Any

[24 Mar 2009 18:45] Daniel Fischer

Description:
MTR2 aborts a test run even with --force when too many tests fail:

Too many tests(10) failed! Terminating...

This count includes second and third attempts for failing test cases, and is off by one. Effectively it will abort a test run after 5 reproducibly failing tests plus one failure (reproducible failures counted twice, the 6th failure doesn't get a second chance and therefore doesn't need to be reproducible).

How to repeat:
Run mtr2 in mysql-5.1 or mysql-6.0 with 6 failing test cases.

Suggested fix:
Fix counting.

[27 Mar 2009 14:43] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/70720

2774 Bjorn Munch	2009-03-27
      Bug #43840 "too many tests failed" includes retries
      Only count non-retried tests, and increment before testing
      modified:
        mysql-test/mysql-test-run.pl

[31 Mar 2009 11:16] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/70883

2775 Bjorn Munch	2009-03-31
      Bug #43840 "too many tests failed" includes retries
      Only count non-retried tests, and increment before testing
      modified:
        mysql-test/mysql-test-run.pl

[31 Mar 2009 14:43] Bjørn Munch

Pushed to 6.0-mtr and 5.1-mtr

[14 May 2009 16:26] Bugs System

Pushed into 6.0.12-alpha (revid:[e-mail]-20090514161729-xiup7q8jlu1zfy7s) (version source revid:[e-mail]-20090331112010-1x6pw7ctdvye9vtv) (merge vers: 6.0.11-alpha) (pib:6)

[15 May 2009 1:23] Paul DuBois

Test suite changes. No changelog entry needed.

Setting report to NDI pending push into 5.1.x.

[28 May 2009 8:21] Bugs System

Pushed into 5.1.36 (revid:[e-mail]-20090528073639-yohsb4q1jzg7ycws) (version source revid:[e-mail]-20090525205831-zitq9aysxy5zgf5r) (merge vers: 5.1.36) (pib:6)

[29 May 2009 1:12] Paul DuBois

Test suite change. No changelog entry needed.

[26 Aug 2009 13:46] Bugs System

Pushed into 5.1.37-ndb-7.0.8 (revid:[e-mail]-20090826132541-yablppc59e3yb54l) (version source revid:[e-mail]-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)

[26 Aug 2009 13:46] Bugs System

Pushed into 5.1.37-ndb-6.3.27 (revid:[e-mail]-20090826105955-bkj027t47gfbamnc) (version source revid:[e-mail]-20090826105955-bkj027t47gfbamnc) (merge vers: 5.1.37-ndb-6.3.27) (pib:11)

[26 Aug 2009 13:48] Bugs System

Pushed into 5.1.37-ndb-6.2.19 (revid:[e-mail]-20090825194404-37rtosk049t9koc4) (version source revid:[e-mail]-20090825194404-37rtosk049t9koc4) (merge vers: 5.1.37-ndb-6.2.19) (pib:11)

[27 Aug 2009 16:33] Bugs System

Pushed into 5.1.35-ndb-7.1.0 (revid:[e-mail]-20090827163030-6o3kk6r2oua159hr) (version source revid:[e-mail]-20090826132541-yablppc59e3yb54l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)