Bug #43603 | mysqltest command disable_abort_on_error does not affect all built-in commands | ||
---|---|---|---|
Submitted: | 12 Mar 2009 16:16 | Modified: | 14 Oct 2010 13:29 |
Reporter: | Ingo Strüwing | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | Tools: MTR / mysql-test-run | Severity: | S3 (Non-critical) |
Version: | 6.0 | OS: | Any |
Assigned to: | Bjørn Munch | CPU Architecture: | Any |
[12 Mar 2009 16:16]
Ingo Strüwing
[12 Mar 2009 16:22]
Ingo Strüwing
Suggest triage values: Defect: medium. I'm unsure if this might be as designed. :( Workaround: unacceptable. Using error 0,1 has disadvantages. Impact: minimal. Feature used during test case development [almost] only.
[18 Mar 2010 10:04]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/103662 2903 Bjorn Munch 2010-03-18 Bug #43603 mysqltest command disable_abort_on_error does not affect all built-in commands After disable_abort_on_error, behaved as if --error was in effect Add condition before die, as after queries
[18 Mar 2010 10:10]
Bjørn Munch
With disable_abort_on_error, non-query commands that failed would be reported as "failed with wrong error", as if it didn't match error codes given in --error. There is faulty logic here, the die() should be on condition that we're not expecting any particular error, like it does for queries. So I added an if (command->expected_errors.count > 0) Also, cat_file was changed to not fail unconditionally but use the same system.
[20 Mar 2010 9:45]
Magnus Blåudd
It could be interesting to know why cat_file failed. With patch, the cause is lost(not that it was very apparent before either). Maybe it should print error before returning 1? Looks ok.
[20 Mar 2010 9:50]
Bjørn Munch
I just figured cat_file should behave the same way as e.g. remove_file, found the problem when I used cat_file in the mysqltest.test test case. The fact that the *_file commands don't print more info should IMHO be regarded as a separate issue.
[22 Mar 2010 10:29]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/103952 2905 Bjorn Munch 2010-03-22 Bug #43603 mysqltest command disable_abort_on_error does not affect all built-in commands After disable_abort_on_error, behaved as if --error was in effect Add condition before die, as after queries
[22 Mar 2010 12:05]
Bjørn Munch
Pushed to *-mtr branches
[16 Aug 2010 6:30]
Bugs System
Pushed into mysql-trunk 5.6.1-m4 (revid:alik@sun.com-20100816062701-qo9dpnk5tkt1pksb) (version source revid:alik@sun.com-20100816062603-xc16eftmv7rmktyq) (merge vers: 5.6.1-m4) (pib:20)
[16 Aug 2010 6:37]
Bugs System
Pushed into mysql-next-mr (revid:alik@sun.com-20100816062819-bluwgdq8q4xysmlg) (version source revid:alik@sun.com-20100816062612-enatdwnv809iw3s9) (pib:20)
[16 Aug 2010 17:05]
Paul DuBois
Test suite changes. No changelog entry needed.
[28 Sep 2010 8:47]
Bugs System
Pushed into mysql-5.1 5.1.52 (revid:sunanda.menon@sun.com-20100928083322-wangbv97uobu7g66) (version source revid:sunanda.menon@sun.com-20100928083322-wangbv97uobu7g66) (merge vers: 5.1.52) (pib:21)
[14 Oct 2010 8:32]
Bugs System
Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (version source revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (merge vers: 5.1.51-ndb-7.0.20) (pib:21)
[14 Oct 2010 8:47]
Bugs System
Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (version source revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (merge vers: 5.1.51-ndb-6.3.39) (pib:21)
[14 Oct 2010 9:01]
Bugs System
Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (version source revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (merge vers: 5.1.51-ndb-6.2.19) (pib:21)
[14 Oct 2010 13:29]
Jon Stephens
Set back to Closed state. See previous comments.