Bug #43588 mysqltest command disable_abort_on_error logs connect commands

Description:
If there is a 'connect' command between the 'disable_abort_on_error' and 'enable_abort_on_error' commands, the connect command is logged to the reject file.

The log includes default parameters such as the full path name to the socket.

How to repeat:
Select an arbitrary test file, e.g. backup_default.test
Insert the following sequence, e.g. at the end:

--disable_abort_on_error
    --echo # connection con1
    --connect (con1,localhost,root,,)
    --disconnect con1
--echo # connection default
--connection default
--enable_abort_on_error

Run the test. You will find a log of the 'connect' command.
Comment out --disable_abort_on_error, and re-run the test.
The log is gone.

Suggested fix:
Do not change log behavior based on disable_abort_on_error/enable_abort_on_error.

Triage values:
Defect: minor. Annoying, but not serious.
Workaround: partial. Can disable_query_log for the connect command.
Impact: minimal. disable_abort_on_error is seldom used.

I agree with Ingo's sugestion:
  Do not change log behavior based on disable_abort_on_error/enable_abort_on_error.

IMHO a solution like:
  mysqltest writes a corresponding message into the protocol when it executes a
  connection related builtin command like
  - connect(<connection_name>,....)
  - connection <connection_name>
  - disconnect <connection_name>
  - dirty_close <connection_name>
would be very useful because this makes protocols
much better understandable and the usual
--echo # Switch to connection ....
are no more needed.
Options within the preceeding line like
--replace_result ...     
--disable/enable_query_log
must have an impact on the line written
into the protocol.

I am aware that such a change leads to modifications
of a lot of tests and expected results.
I volunteer for this in case my team lead agrees.

I wonder why you cleared all triage values and the lead.
Also i read in https://inside.mysql.com/wiki/BugTriageGuidelines#Setting_the_Lead_on_Bugs that mysqltest does explicitly not belong to the clients. So "Tests - Test tools" sounds more likely to be the right category.

Hi Ingo I had only added my comment.
This means the changes are done by some magic mechanism
within the BugsDB.
I restore the old values except
Category will be MTR/mysql-test-run

Not sure this should be "fixed" but in any case it belongs to me.

Picking this up. This was apparently added deliberately by WL #1339, which needed connect after --error logged. But the test for this was more general then needed and also covered disable_abort_on_error.

Working on a fix to limit this to connect after --error.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/103604

2903 Bjorn Munch	2010-03-17
      Bug #43588 mysqltest command disable_abort_on_error logs connect commands
      Only log connects after --error
      A few small test adjustments needed/possible

Pushed to *-mtr trees

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@sun.com-20100816062701-qo9dpnk5tkt1pksb) (version source revid:alik@sun.com-20100816062603-xc16eftmv7rmktyq) (merge vers: 5.6.1-m4) (pib:20)

Pushed into mysql-next-mr (revid:alik@sun.com-20100816062819-bluwgdq8q4xysmlg) (version source revid:alik@sun.com-20100816062612-enatdwnv809iw3s9) (pib:20)

Test suite changes. No changelog entry needed.

Pushed into mysql-5.1 5.1.52 (revid:sunanda.menon@sun.com-20100928083322-wangbv97uobu7g66) (version source revid:sunanda.menon@sun.com-20100928083322-wangbv97uobu7g66) (merge vers: 5.1.52) (pib:21)

Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (version source revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (merge vers: 5.1.51-ndb-7.0.20) (pib:21)

Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (version source revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (merge vers: 5.1.51-ndb-6.3.39) (pib:21)

Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (version source revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (merge vers: 5.1.51-ndb-6.2.19) (pib:21)

Setting back to Closed; see previous comments.