Bug #41888 Test binlog.binlog_database causing binlog_innodb to fail on Pushbuild
Submitted: 5 Jan 2009 22:44 Modified: 21 Jan 2009 16:22
Reporter: Patrick Crews Email Updates:
Status: Closed Impact on me:
None 
Category:Tests: Server Severity:S3 (Non-critical)
Version:5.1+ OS:Any
Assigned to: Patrick Crews CPU Architecture:Any
Tags: binlog, binlog_innodb, pushbuild, test failure

[5 Jan 2009 22:44] Patrick Crews 
Description:
Test binlog.binlog_innodb is failing on Pushbuild for stmt, row, and mixed variants.
It appears that the variable binlog_cache_disk_use's value is 2 more than the expected value for several portions of the test

binlog.binlog_innodb 'stmt'    [ fail ]

--- /data0/pushbuild/pb/bzr_mysql-5.1-bugteam/354/bzr_mysql-5.1-bugteam-exp/mysql-test/suite/binlog/r/binlog_innodb.result	2009-01-05 21:56:18.000000000 +0300
+++ /data0/pushbuild/pb/bzr_mysql-5.1-bugteam/354/bzr_mysql-5.1-bugteam-exp/mysql-test/suite/binlog/r/binlog_innodb.reject	2009-01-05 22:24:50.000000000 +0300
@@ -115,14 +115,14 @@
 DROP TABLE t1;
 show status like "binlog_cache_use";
 Variable_name	Value
-Binlog_cache_use	13
+Binlog_cache_use	15
 show status like "binlog_cache_disk_use";
 Variable_name	Value
 Binlog_cache_disk_use	0
 create table t1 (a int) engine=innodb;
 show status like "binlog_cache_use";
 Variable_name	Value
-Binlog_cache_use	14
+Binlog_cache_use	16
 show status like "binlog_cache_disk_use";
 Variable_name	Value
 Binlog_cache_disk_use	1
@@ -131,7 +131,7 @@
 commit;
 show status like "binlog_cache_use";
 Variable_name	Value
-Binlog_cache_use	15
+Binlog_cache_use	17

How to repeat:
Run the test:
From the mysql-test directory execute the following:

./mysql-test-run --force --suite=binlog binlog_innodb

Observer mysql-test-run's output

Suggested fix:
Determine the cause of these failures:

1)  Expected change in server w/o an update of the test
2)  Unexpected change in server behavior

If it is:
1)  Correct the test to reflect the new server behavior
2)  Reassign the bug to a developer to determine the cause of this change.
[7 Jan 2009 23:01] Patrick Crews 
This appears to be a result of a previous test rather than a flaw in binlog_innodb itself.

When running the test solo, it performs as expected.  It is only when running other tests in the binlog suite that this test fails.

Suspect is currently binlog_grant, but still researching.  Will update the bug accordingly when more is known.
[7 Jan 2009 23:11] Patrick Crews 
binlog_database is incrementing binlog_cache_use and causing binlog_innodb to fail.

To repeat execute the following from mysql-test directory:
./mysql-test-run --force --suite=binlog binlog_database binlog_innodb
[8 Jan 2009 0:25] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/62640

2729 Patrick Crews	2009-01-07
      Bug#41888 Test binlog.binlog_database causing binlog_innodb to fail on Pushbuild.
      
      binlog_database was not cleaning up after itsef and was causing binlog_innodb to fail.
      
      Added FLUSH STATUS to the end of the test to properly reset variables used in later tests.
      Re-recorded .result file to account for the additional command.
[12 Jan 2009 23:46] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/63046

2736 Patrick Crews	2009-01-12
      Bug#41888: Test binlog.binlog_database causing binlog_innodb to fail on Pushbuild.
      
      Added cleanup of status variables to the end of binlog_database.
      Re-recorded .result file to account for cleanup statement.
      NOTE:  binlog.binlog_innodb also has had an FLUSH STATUS; statement added to it as well, but
      adding this cleanup as a preventative measure.
[15 Jan 2009 6:40] Bugs System 
Pushed into 5.1.31 (revid:joro@sun.com-20090115053147-tx1oapthnzgvs1ro) (version source revid:davi.arnaut@sun.com-20090113150631-y84w12o2zmh7j3qd) (merge vers: 5.1.31) (pib:6)
[16 Jan 2009 3:49] Paul DuBois 
Test case changes. No changelog entry needed.

Setting report to NDI pending push into 6.0.x.
[19 Jan 2009 11:24] Bugs System 
Pushed into 5.1.31-ndb-6.2.17 (revid:tomas.ulin@sun.com-20090119095303-uwwvxiibtr38djii) (version source revid:tomas.ulin@sun.com-20090115073240-1wanl85vlvw2she1) (merge vers: 5.1.31-ndb-6.2.17) (pib:6)
[19 Jan 2009 13:01] Bugs System 
Pushed into 5.1.31-ndb-6.3.21 (revid:tomas.ulin@sun.com-20090119104956-guxz190n2kh31fxl) (version source revid:tomas.ulin@sun.com-20090119104956-guxz190n2kh31fxl) (merge vers: 5.1.31-ndb-6.3.21) (pib:6)
[19 Jan 2009 15:56] Jon Stephens 
Setting status back to NDI pending merge to 6.0 tree.
[19 Jan 2009 16:07] Bugs System 
Pushed into 5.1.31-ndb-6.4.1 (revid:tomas.ulin@sun.com-20090119144033-4aylstx5czzz88i5) (version source revid:tomas.ulin@sun.com-20090119144033-4aylstx5czzz88i5) (merge vers: 5.1.31-ndb-6.4.1) (pib:6)
[20 Jan 2009 18:55] Bugs System 
Pushed into 6.0.10-alpha (revid:joro@sun.com-20090119171328-2hemf2ndc1dxl0et) (version source revid:timothy.smith@sun.com-20090114143745-x2dvnmix6gjlt6z6) (merge vers: 6.0.10-alpha) (pib:6)
[21 Jan 2009 16:22] Paul DuBois 
Test case changes. No changelog entry needed.