MySQL Bugs: #41002: symlink.test fails on symlinked datadir

Bug #41002	symlink.test fails on symlinked datadir
Submitted:	25 Nov 2008 9:19	Modified:	8 Dec 2008 16:04
Reporter:	Ingo Strüwing	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tests: Server	Severity:	S3 (Non-critical)
Version:	5.1	OS:	Any (Unix-like platforms)
Assigned to:	Ingo Strüwing	CPU Architecture:	Any

Description:
This is a follow-up to Bug#39277 (Creation of table with data and/or index files in data home directory succeeds).

The purpose of this bug report is to get the test case fixed.

Bug#39277 will not be fixed in 5.1. Security team thinks it is not a security issue. Triage team says it's a "corner case".

The consequence is that the current behavior of the server is defined as being correct. This means that some tests in the test case symlink.test will fail when run in an environment without symbolic links, while they will succeed in an environment where the server's data home directory is a symbolic link to a different location. The latter happens when running the test suite in a memeory file system, e.g. with mysql-test-run --mem.

How to repeat:
mysql-test-run --mem

Suggested fix:
Change the --error directive of the affected statements to accept success as well as the specified error. Add a comment to explain, why both is allowed.

Small test case fix only.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/59799

2711 Ingo Struewing	2008-11-25
      Bug#41002 - symlink.test fails on symlinked datadir
      
      symlink.test failed when run in an environment that has mysql-test/var
      symlinked to elsewhere, e.g. a memory file system. This is the case
      when running mysql-test-run --mem.
      
      In this case the server does not detect that the directory specified
      with a DATA/INDEX DIRECTORY clause is within its data home directory.
      This problem was reported as Bug#39277 (Creation of table with data
      and/or index files in data home directory succeeds). It was decided
      that it will not be fixed in 5.1. Hence, the current behavior is
      accepted for 5.1. It will be fixed in 6.0 though.
      
      Fixed the test case so that it works in both environments. 1. When no
      symbolic link is involved, the server notices that the data/index
      directory is in its data hone directory and rejects the CREATE/ALTER
      TABLE statement. 2. When the data home directory is symlinked, it
      does not notice the problem and executes the statement sucessfully.

OK to push by me.

Queued to 6.0-bugteam, 5.1-bugteam.

Pushed into 5.1.31  (revid:ingo.struewing@sun.com-20081125140631-qqnfima1u8ie5778) (version source revid:patrick.crews@sun.com-20081126215253-rub0b9ykdsgx9fvl) (pib:5)

Pushed into 6.0.9-alpha  (revid:ingo.struewing@sun.com-20081125140631-qqnfima1u8ie5778) (version source revid:patrick.crews@sun.com-20081126215920-cfklo6hft01u8zxx) (pib:5)

Test case changes. No changelog entry needed.

Pushed into 5.1.31-ndb-6.2.17 (revid:tomas.ulin@sun.com-20090119095303-uwwvxiibtr38djii) (version source revid:tomas.ulin@sun.com-20090108105244-8opp3i85jw0uj5ib) (merge vers: 5.1.31-ndb-6.2.17) (pib:6)

Pushed into 5.1.31-ndb-6.3.21 (revid:tomas.ulin@sun.com-20090119104956-guxz190n2kh31fxl) (version source revid:tomas.ulin@sun.com-20090119104956-guxz190n2kh31fxl) (merge vers: 5.1.31-ndb-6.3.21) (pib:6)

Pushed into 5.1.31-ndb-6.4.1 (revid:tomas.ulin@sun.com-20090119144033-4aylstx5czzz88i5) (version source revid:tomas.ulin@sun.com-20090119144033-4aylstx5czzz88i5) (merge vers: 5.1.31-ndb-6.4.1) (pib:6)