Bug #40970 Errors from commit blocker are not logged.

Submitted: 24 Nov 2008 9:24 Modified: 11 Feb 2009 3:17
Reporter: Rafal Somla Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Backup Severity:S3 (Non-critical)
Version:6.0 source OS:Any
Assigned to: Jørgen Løland CPU Architecture:Any

[24 Nov 2008 9:24] Rafal Somla
Description:
In the short synchronization phase during backup operation, transaction commits are blocked. This is done inside write_table_data() function (data_backup.cc) by calls to block_commits() and unblock_commits() functions. Although these functions detect errors, an error is not reported if it happens. Neither (un)block_commits() functions, nor the caller log an appropriate error message.

How to repeat:
Code inspection.
[1 Dec 2008 10:12] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/60262

2737 Jorgen Loland	2008-12-01
      Bug#40970 - Errors from commit blocker are not logged.
      
      If block_commits fails, an error is now logged. unblock_commits cannot fail.
[5 Dec 2008 8:41] Øystein Grøvlen
Patch approved.
[5 Dec 2008 9:00] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/60694

2740 Jorgen Loland	2008-12-05
      Bug#40970 - Errors from commit blocker are not logged.
            
      If block_commits fails, an error is now logged. unblock_commits cannot fail.
[5 Dec 2008 9:22] Øystein Grøvlen
Patch approved.
[5 Dec 2008 18:56] Chuck Bell
Patch approved.
[15 Dec 2008 9:22] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/61644

2737 Jorgen Loland	2008-12-15
      Bug#40970 - Errors from commit blocker are not logged.
                  
      If block_commits fails, an error is now logged. unblock_commits cannot fail.
[15 Dec 2008 9:30] Jørgen Løland
Pushed into mysql-6.0-backup Dec 15
[2 Feb 2009 16:07] Bugs System
Pushed into 6.0.10-alpha (revid:sergefp@mysql.com-20090202090240-dlkxhmc1asrar5rl) (version source revid:sergefp@mysql.com-20090129100938-qvke7a9krg24l8pl) (merge vers: 6.0.10-alpha) (pib:6)
[11 Feb 2009 3:17] Paul DuBois
Noted in 6.0.10 changelog.

For BACKUP DATABASE, errors from the commit blocker were not logged.

Portions of this website are copyright © 2001, 2002 The PHP Group

Page generated in 0.064 sec. using MySQL 8.4.7-u6-cloud

Timestamp references displayed by the system are UTC.
Content reproduced on this site is the property of the respective copyright holders.
It is not reviewed in advance by Oracle and does not necessarily represent the opinion of Oracle or any other party.