MySQL Bugs: #40882: main.read_only fails sporadically, weak code

Bug #40882	main.read_only fails sporadically, weak code
Submitted:	20 Nov 2008 12:35	Modified:	14 Mar 2009 1:36
Reporter:	Alexander Nozdrin	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tests: Server	Severity:	S3 (Non-critical)
Version:	6.0-TRUNK	OS:	Any
Assigned to:	Horst Hunger	CPU Architecture:	Any
Tags:	pushbuild, sporadic, test failure

Description:
main.read_only fails sporadically on Windows.

The first failure happened on 2008-09-12 in 6.0-backup.

Symptoms:
@@ -52,7 +52,7 @@
 unlock tables ;
 select @@global.read_only;
 @@global.read_only
-1
+0
 set global read_only=0;
 lock table t1 read;
 lock table t2 read;

Reported after failure in 6.0-falcon.

How to repeat:
XRef: http://tinyurl.com/66xb6e

This is a clear weakness within the test.
- This code exists in 5.0.
  -> Fix should start there.
- It is to be expected that this test fails
  on any testing box with heavy load.
I will change therefor bug title, OS and target version.

Sorry, the weak code comes up with 5.1.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/65731

2795 Horst Hunger	2009-02-10
      Fix for bug#40882: Replaced "sleep 1" by wait_condition, added save/restore start values and closed open sessions. When trying to use "wait_for_query_to_succeed" a type has been fixed, also in "rename.test".

Hi Horst

Code inspection:
- read_only.test looks very good
  perfect
- rename.test
  Please replace error numbers by error names.

Stability tests (my own aggressive version which
is capable to find multi session related issues):
- "read_only"    -- perfect
- "rename"
  My hyper-sensitive check presented 7 failing runs
  per 20 executions.
  I propose to source
  include/count_sessions.inc at the beginning
  include/wait_until_count_sessions.inc at the end
  of the test.

Ok to push

Regards

Matthias

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/65855

2795 Horst Hunger	2009-02-11
      Reviewed fix for bug#40882: Replaced "sleep 1" by wait_condition, added save/restore start values and closed open sessions. When trying to use "wait_for_query_to_succeed" a type has been fixed, also in "rename.test": Added session count and check and replaced error numbers.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/65868

3044 Horst Hunger	2009-02-11 [merge]
      Merge of patches for bug#40882 to 6.0.

Pushed into 6.0.10-alpha (revid:matthias.leich@sun.com-20090212211028-y72faag15q3z3szy) (version source revid:matthias.leich@sun.com-20090212211028-y72faag15q3z3szy) (merge vers: 6.0.10-alpha) (pib:6)

Test case changes. No changelog entry needed.

Setting report to NDI pending push into 5.1.x.

Pushed into 5.1.33 (revid:joro@sun.com-20090313111355-7bsi1hgkvrg8pdds) (version source revid:horst@mysql.com-20090211092752-kdyvh2h9yyfnlvhs) (merge vers: 5.1.32) (pib:6)

Test case changes. No changelog entry needed.

Pushed into 5.1.34-ndb-6.2.18 (revid:jonas@mysql.com-20090508185236-p9b3as7qyauybefl) (version source revid:jonas@mysql.com-20090508100057-30ote4xggi4nq14v) (merge vers: 5.1.33-ndb-6.2.18) (pib:6)

Pushed into 5.1.34-ndb-6.3.25 (revid:jonas@mysql.com-20090509063138-1u3q3v09wnn2txyt) (version source revid:jonas@mysql.com-20090508175813-s6yele2z3oh6o99z) (merge vers: 5.1.33-ndb-6.3.25) (pib:6)

Pushed into 5.1.34-ndb-7.0.6 (revid:jonas@mysql.com-20090509154927-im9a7g846c6u1hzc) (version source revid:jonas@mysql.com-20090509073226-09bljakh9eppogec) (merge vers: 5.1.33-ndb-7.0.6) (pib:6)