Bug #40257 Please remove --loose-skip-innodb from suite/rpl/rpl_1slave_base.cnf
Submitted: 22 Oct 2008 15:32 Modified: 30 Jan 2009 17:45
Reporter: Sven Sandberg Email Updates:
Status: Closed Impact on me:
None 
Category:Tests: Replication Severity:S7 (Test Cases)
Version:5.1-rpl OS:Any
Assigned to: Sven Sandberg CPU Architecture:Any
Tags: 51rpl

[22 Oct 2008 15:32] Sven Sandberg
Description:
Currently, when mtr runs replication tests, it starts the slave server with --loose-skip-innodb, but the master server has no flag to prevent it from using innodb. That is inconsistent (so it causes confusion when we develop tests), and probably inefficient since it forces test cases to set the --innodb flag in .opt files, causing server restarts.

How to repeat:
-

Suggested fix:
Remove --loose-skip-innodb from mysql-test/suite/rpl/rpl_1slave_base.cnf
Remove --innodb and --loose-innodb from .opt files in mysql-test/suite/rpl/t/
[23 Oct 2008 12:24] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/56885

2683 Sven Sandberg	2008-10-23
      BUG#40257: Please remove --loose-skip-innodb from suite/rpl/rpl_1slave_base.cnf
      Removed the flag that disables innodb on slave in the default
      configuration of replication tests. That allowed us to remove
      lots of .opt files, which is good because .opt files cause
      server restarts and make tests less readable.
[29 Oct 2008 11:16] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/57293

2683 Sven Sandberg	2008-10-29
      BUG#40257: Please remove --loose-skip-innodb from suite/rpl/rpl_1slave_base.cnf
      Removed the flag that disables innodb on slave in the default
      configuration of replication tests. That made the explicit
      --innodb flag in .opt files redundant, so lots of .opt files
      could be removed. That is good because .opt files cause
      server restarts and make tests less readable.
      Also fixed a bug where rpl_innodb_mixed_ddl unintentionally
      used myisam on slave.
[29 Oct 2008 13:23] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/57313

2686 Sven Sandberg	2008-10-29
      BUG#40257: Please remove --loose-skip-innodb from suite/rpl/rpl_1slave_base.cnf
      Removed the flag that disables innodb on slave in the default
      configuration of replication tests. That made the explicit
      --innodb flag in -slave.opt files redundant, so lots of -slave.opt
      files could be removed. Also, -master.opt files containing reduntant
      --innodb flag were removed (those were redundant even without
      changing the default). Removing .opt files is good because .opt
      files cause server restarts and make tests less readable.
      Also fixed a bug where rpl_innodb_mixed_ddl unintentionally
      used myisam on slave.
[29 Oct 2008 13:25] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/57315

2716 Sven Sandberg	2008-10-29 [merge]
      merged fix for BUG#40257 from 5.1-rpl to 6.0-rpl
[29 Oct 2008 18:32] Sven Sandberg
pushed to 5.1-rpl and 6.0-rpl
[4 Nov 2008 17:02] Sven Sandberg
In addition, there's an unnecessary --rpl-recovery-rank in suite/rpl/rpl_1slave_base.cnf. This is an obsolete option and it should not be used. Will push a small fix for that too.
[4 Nov 2008 17:04] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/57815

2691 Sven Sandberg	2008-11-04
      BUG#40257: Please remove --loose-skip-innodb from suite/rpl/rpl_1slave_base.cnf
      Removed unnecessary server options --rpl-recovery-rank. This is obsolete
      and does not affect the test suite in any useful way.
[6 Nov 2008 2:25] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/57960

2684 He Zhenxing	2008-11-05 [merge]
      For test, please ignore
[10 Nov 2008 12:31] Sven Sandberg
The patch to remove --rpl-recovery-rank has also been pushed to 5.1-rpl and 6.0-rpl
[30 Jan 2009 13:27] Bugs System
Pushed into 6.0.10-alpha (revid:luis.soares@sun.com-20090129165607-wiskabxm948yx463) (version source revid:luis.soares@sun.com-20090129163120-e2ntks4wgpqde6zt) (merge vers: 6.0.10-alpha) (pib:6)
[30 Jan 2009 15:07] Bugs System
Pushed into 5.1.32 (revid:luis.soares@sun.com-20090129165946-d6jnnfqfokuzr09y) (version source revid:msvensson@mysql.com-20081107152611-4otl7m3ki6peqzp2) (merge vers: 5.1.30) (pib:6)
[30 Jan 2009 17:45] Paul Dubois
Test case changes. No changelog entry needed.
[17 Feb 2009 14:54] Bugs System
Pushed into 5.1.32-ndb-6.3.23 (revid:tomas.ulin@sun.com-20090217131017-6u8qz1edkjfiobef) (version source revid:tomas.ulin@sun.com-20090203133556-9rclp06ol19bmzs4) (merge vers: 5.1.32-ndb-6.3.22) (pib:6)
[17 Feb 2009 16:41] Bugs System
Pushed into 5.1.32-ndb-6.4.3 (revid:tomas.ulin@sun.com-20090217134419-5ha6xg4dpedrbmau) (version source revid:tomas.ulin@sun.com-20090203133556-9rclp06ol19bmzs4) (merge vers: 5.1.32-ndb-6.3.22) (pib:6)
[17 Feb 2009 18:17] Bugs System
Pushed into 5.1.32-ndb-6.2.17 (revid:tomas.ulin@sun.com-20090217134216-5699eq74ws4oxa0j) (version source revid:tomas.ulin@sun.com-20090201210519-vehobc4sy3g9s38e) (merge vers: 5.1.32-ndb-6.2.17) (pib:6)