Bug #40129 | no-threads fails on pushbuild in 6.0-rpl, ps_stm_threadpool | ||
---|---|---|---|
Submitted: | 18 Oct 2008 16:59 | Modified: | 30 Jan 2009 17:41 |
Reporter: | Sven Sandberg | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | MySQL Server: Tests | Severity: | S7 (Test Cases) |
Version: | 5.1-rpl 6.0-rpl | OS: | Any |
Assigned to: | Andrei Elkin | CPU Architecture: | Any |
Tags: | 51rpl, 6.0-rpl-green, no-threads, ps_stm_threadpool, pushbuild, test failure |
[18 Oct 2008 16:59]
Sven Sandberg
[27 Nov 2008 11:20]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/60018 2705 Andrei Elkin 2008-11-27 Bug #40129 no-threads fails on pushbuild in 6.0-rpl, ps_stm_threadpool The test reacted on the way how mtr orders arguments for the server that are gathered from different source. It appeared that the opt-file options were parsed before those that supplied to mtr via its command line. In effect, the opt-file preferences got overriden by the command line and some tests, like no-threads, were caught by surprise: a test expects an option value that had been "hardcoded" into its opt-file but gets another one. This server options ordering problem exists on in the new rpl trees mtr. In option of the author of this patch, the opt-file shall be considered as having the highest preference weight. The opt-file is merely a part of the header of a test, namely a part that can not be technically deployed along the test file. Another possible option might be for a test to refuse to execute via `source have_some_option_value' guard. However, this way looks complicated. Indeed, for the referred test there should be a new guard constructed that allows the test to run only if the interested to the test option `thread_handling' has a specific value `pool-of-threads'. It's unnatural in opinion of this patch author for the test writer to provide both the opt file value and a guard that guarantees the value will be set on in the run time. On the contrary, it's logical to provide either one: the option and its value or the guard. Fixed with relocating parse of the opt file to be the last among sources of the sever's options. A side effect: fixing a small problem of resetting the suite options at time the opt file starts parsing.
[5 Dec 2008 13:54]
Magnus Blåudd
Patch looks very good. But please _remove_ the line you have commented out. Keeping it serves no purpose.
[9 Dec 2008 17:08]
Magnus Blåudd
Approved with comment to remove the commented out code.
[12 Dec 2008 21:52]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/61563 2704 Andrei Elkin 2008-12-12 Bug #40129 no-threads fails on pushbuild in 6.0-rpl, ps_stm_threadpool The test reacted on the way how mtr orders arguments for the server that are gathered from different source. It appeared that the opt-file options were parsed before those that supplied to mtr via its command line. In effect, the opt-file preferences got overriden by the command line and some tests, like no-threads, were caught by surprise: a test expects an option value that had been "hardcoded" into its opt-file but gets another one. This server options ordering problem exists on in the new rpl trees mtr. In option of the author of this patch, the opt-file shall be considered as having the highest preference weight. The opt-file is merely a part of the header of a test, namely a part that can not be technically deployed along the test file. It's unnatural for the test writer to provide both the opt file value and a guard that guarantees the value will be set on in the run time. It's logical to provide either one: the option and its value or the guard. Fixed with relocating parse of the opt file to be the last among sources of the sever's options. A side effect: fixing a small problem of resetting the suite options at time the opt file starts parsing. A side effect: main.log_bin_trust_function_creators_func is disabled to be re-enabled with the fixes for bug#41003 will be merged from the main trees.
[12 Dec 2008 22:27]
Andrei Elkin
pushed to rpl.
[15 Dec 2008 9:22]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/61645 2743 He Zhenxing 2008-12-15 [merge] Auto merge
[30 Jan 2009 13:30]
Bugs System
Pushed into 6.0.10-alpha (revid:luis.soares@sun.com-20090129165607-wiskabxm948yx463) (version source revid:luis.soares@sun.com-20090129163120-e2ntks4wgpqde6zt) (merge vers: 6.0.10-alpha) (pib:6)
[30 Jan 2009 15:10]
Bugs System
Pushed into 5.1.32 (revid:luis.soares@sun.com-20090129165946-d6jnnfqfokuzr09y) (version source revid:alfranio.correia@sun.com-20081213194819-3u93g1xpzyy18u28) (merge vers: 5.1.31) (pib:6)
[30 Jan 2009 17:41]
Paul DuBois
Test suite changes. No changelog entry needed.
[17 Feb 2009 14:59]
Bugs System
Pushed into 5.1.32-ndb-6.3.23 (revid:tomas.ulin@sun.com-20090217131017-6u8qz1edkjfiobef) (version source revid:tomas.ulin@sun.com-20090203133556-9rclp06ol19bmzs4) (merge vers: 5.1.32-ndb-6.3.22) (pib:6)
[17 Feb 2009 16:46]
Bugs System
Pushed into 5.1.32-ndb-6.4.3 (revid:tomas.ulin@sun.com-20090217134419-5ha6xg4dpedrbmau) (version source revid:tomas.ulin@sun.com-20090203133556-9rclp06ol19bmzs4) (merge vers: 5.1.32-ndb-6.3.22) (pib:6)
[17 Feb 2009 18:22]
Bugs System
Pushed into 5.1.32-ndb-6.2.17 (revid:tomas.ulin@sun.com-20090217134216-5699eq74ws4oxa0j) (version source revid:tomas.ulin@sun.com-20090201210519-vehobc4sy3g9s38e) (merge vers: 5.1.32-ndb-6.2.17) (pib:6)