MySQL Bugs: #39858: rpl.rpl_rotate (rpl.rpl_rotate_logs) failed on pushbuild: result mismatch

Bug #39858	rpl.rpl_rotate (rpl.rpl_rotate_logs) failed on pushbuild: result mismatch
Submitted:	4 Oct 2008 12:53	Modified:	18 Mar 2009 15:20
Reporter:	Sven Sandberg	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tests: Replication	Severity:	S3 (Non-critical)
Version:	5.1+	OS:	Any
Assigned to:	li zhou	CPU Architecture:	Any
Tags:	pushbuild, rpl_rotate, sporadic, test failure

Description:
pushbuild failure:

rpl.rpl_rotate_logs                      [ fail ]

CURRENT_TEST: rpl.rpl_rotate_logs
--- e:/pb/bzr_mysql-5.1-rpl/53/mysql-5.1.30-pb53/mysql-test/suite/rpl/r/rpl_rotate_logs.result	2008-09-10 17:42:05.000000000 +0300
+++ e:\pb\bzr_mysql-5.1-rpl\53\mysql-5.1.30-pb53\mysql-test\suite\rpl\r\rpl_rotate_logs.reject	2008-09-10 22:24:13.465500000 +0300
@@ -93,6 +93,7 @@
 purge master logs before (@time_for_purge);
 show binary logs;
 Log_name	File_size
+master-bin.000002	#
 master-bin.000003	#
 insert into t2 values (65);
 SHOW SLAVE STATUS;
@@ -150,6 +151,7 @@
 create table t4 select * from temp_table;
 show binary logs;
 Log_name	File_size
+master-bin.000002	#
 master-bin.000003	#
 master-bin.000004	#
 master-bin.000005	#

mysqltest: Result content mismatch

 - saving 'e:/pb/bzr_mysql-5.1-rpl/53/mysql-5.1.30-pb53/mysql-test/var-n_mix-5/2/log/rpl.rpl_rotate_logs/' to 'e:/pb/bzr_mysql-5.1-rpl/53/mysql-5.1.30-pb53/mysql-test/var-n_mix-5/log/rpl.rpl_rotate_logs/'

Retrying test, attempt(2/3)...

How to repeat:
https://intranet.mysql.com/secure/pushbuild/showpush.pl?dir=bzr_mysql-5.1-rpl&order=53 win2003-x86/n_mix

Has only failed once according to xref: http://tinyurl.com/4tt6c9

This problem occured again during the tests on
5.1.30 performed by the build team.

TEST : rpl.rpl_rotate_logs (normal 'mix')
LOG  : log/loki45-5.1-enterprise-gpl.log
       This is a box with Windos.

@@ -93,6 +93,7 @@
 purge master logs before (@time_for_purge);
 show binary logs;
 Log_name       File_size
+master-bin.000002      #
 master-bin.000003      #
 insert into t2 values (65);
 SHOW SLAVE STATUS;
@@ -150,6 +151,7 @@
 create table t4 select * from temp_table;
 show binary logs;
 Log_name       File_size
+master-bin.000002      #
 master-bin.000003      #
 master-bin.000004      #
 master-bin.000005      #

Thanks Matthias for letting us know. That means it's not specific to the rpl tree.

Please check if the test case still failed.
That test case works well with 5.1-bugteam and 6.0-bugteam in pushbuild.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/68300

2825 Leonard Zhou	2009-03-05
      BUG#39858 rpl.prl_rotate(rpl.rpl_rotate_logs) failed on pushbuild: result mismatch
      
      The new purge time is not always later than the last modify time of master-bin.000002 in windows platform,
      So we can't sure master-bin.000002 is always deleted in any platform.
      
      Change the new purge time to '1 second later than the last modify time of master-bin.000002.
      That can sure we can always delete that file in any platform.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/68834

2825 Leonard Zhou	2009-03-11
      BUG#39858 rpl.rpl_rotate (rpl.rpl_rotate_logs) failed on pushbuild: result mismatch
      
      The method to purge binary log files produces different results in some platfroms. 
      
      Change a new way that sets the time to purge binlog file 1 second after the last modify time of master-bin.000002.
      That can sure that the file must be deleted in any platform.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/68836

2825 Leonard Zhou	2009-03-11
      BUG#39858 rpl.rpl_rotate (rpl.rpl_rotate_logs) failed on pushbuild: result mismatch
      
      The method to purge binary log files produces different results in some platfroms.
      The reason is that the purge time is caculated based on table modified time and
      that can't guarantee to purge master-bin.000002 in all platforms.(eg. windows)
      
      Use a new way that sets the time to purge binlog file 1 second after the last modified time of master-bin.000002.
      That can be sure that the file is always deleted in any platform.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/68838

2825 Leonard Zhou	2009-03-11
      BUG#39858 rpl.rpl_rotate (rpl.rpl_rotate_logs) failed on pushbuild: result mismatch
      
      The method to purge binary log files produces different results in some platforms.
      The reason is that the purge time is calculated based on table modified time and
      that can't guarantee to purge master-bin.000002 in all platforms.(eg. windows)
      
      Use a new way that sets the time to purge binlog file 1 second after the last modified time of master-bin.000002.
      That can be sure that the file is always deleted in any platform.

pushed into 5.1-bugteam and 6.0-bugteam

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/68912

2830 Georgi Kodinov	2009-03-11
      Revert the push for bug #39858

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/69009

2839 Leonard Zhou	2009-03-12
      BUG#39858 rpl.rpl_rotate (rpl.rpl_rotate_logs) failed on pushbuild: result mismatch
      
      The method to purge binary log files produces different results in some platforms.
      The reason is that the purge time is calculated based on table modified time and
      that can't guarantee to purge master-bin.000002 in all platforms.(eg. windows)
      
      Use a new way that sets the time to purge binlog file 1 second after the last
      modified time of master-bin.000002.
      That can be sure that the file is always deleted in any platform.

Ok to push.

Tested on Mac OS, Windows with Cygwin and Windows with ActiveState perl (no Cygwin).

Test works fine alone and as part of full suite and is properly skipped on Windows without Cygwin.

Pushed into 5.1.33 (revid:joro@sun.com-20090313111355-7bsi1hgkvrg8pdds) (version source revid:joro@sun.com-20090311151918-9a6rao1xy4lk1cv4) (merge vers: 5.1.33) (pib:6)

pushed into 5.1-bugteam and 6.0-bugteam

Pushed into 6.0.11-alpha (revid:joro@sun.com-20090318122208-1b5kvg6zeb4hxwp9) (version source revid:joro@sun.com-20090311155209-mit0quoploifypyz) (merge vers: 6.0.11-alpha) (pib:6)

Change in testing only; no user-facing changes to document. Closed without taking any further action.

Pushed into 5.1.34 (revid:joro@sun.com-20090327143448-wuuuycetc562ty6o) (version source revid:leonard@mysql.com-20090316090622-sr8lylqvsl1jrcnv) (merge vers: 5.1.34) (pib:6)

Pushed into 6.0.11-alpha (revid:alik@sun.com-20090413084402-snnrocwzktcl88ny) (version source revid:gni@mysql.com-20090318145800-v3djvy05es7kcvub) (merge vers: 6.0.11-alpha) (pib:6)

Pushed into 5.1.34-ndb-6.2.18 (revid:jonas@mysql.com-20090508185236-p9b3as7qyauybefl) (version source revid:jonas@mysql.com-20090508185236-p9b3as7qyauybefl) (merge vers: 5.1.34-ndb-6.2.18) (pib:6)

Pushed into 5.1.34-ndb-6.3.25 (revid:jonas@mysql.com-20090509063138-1u3q3v09wnn2txyt) (version source revid:jonas@mysql.com-20090509063138-1u3q3v09wnn2txyt) (merge vers: 5.1.34-ndb-6.3.25) (pib:6)

Pushed into 5.1.34-ndb-7.0.6 (revid:jonas@mysql.com-20090509154927-im9a7g846c6u1hzc) (version source revid:jonas@mysql.com-20090509154927-im9a7g846c6u1hzc) (merge vers: 5.1.34-ndb-7.0.6) (pib:6)