Bug #38967 Unused mutex LOCK_Acl
Submitted: 22 Aug 2008 17:25 Modified: 12 Nov 2009 18:56
Reporter: Marc ALFF Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server Severity:S5 (Performance)
Version:5.0-bzr, 5.1-bzr, 6.0-bzr OS:Any
Assigned to: Marc ALFF CPU Architecture:Any

[22 Aug 2008 17:25] Marc ALFF 
Description:
The following mutex:

pthread_mutex_t LOCK_Acl;

is initialized and destroyed, but never locked / unlocked in the server code.

How to repeat:
Code review

Suggested fix:
Remove LOCK_Acl
[22 Aug 2008 17:41] Valeriy Kravchuk 
Thank you for a problem report. Verified with recent 5.0-bzr, 5.1-bzr and 6.0-bzr.
[23 Aug 2008 23:47] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/52386

2684 Marc Alff	2008-08-23
      Bug#38967 (Unused mutex LOCK_Acl)
      
      Removed the unused mutex LOCK_Acl.
[23 Aug 2008 23:48] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/52387

2684 Marc Alff	2008-08-23
      Bug#38967 (Unused mutex LOCK_Acl)
      
      Removed the unused mutex LOCK_Acl.
[26 Aug 2008 2:14] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/52516

2684 Marc Alff	2008-08-23
      Bug#38967 (Unused mutex LOCK_Acl)
      
      Removed the unused mutex LOCK_Acl.
[1 Nov 2008 18:31] Bugs System 
Pushed into 6.0.7-alpha  (revid:marc.alff@sun.com-20080823234817-22nqbhj2ad9mfeeo) (version source revid:marc.alff@sun.com-20080826003843-alvk2j1rxnpf76nc) (pib:5)
[3 Nov 2008 2:00] Paul DuBois 
Cosmetic change. No changelog entry needed.
[29 Oct 2009 15:10] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/88615

2929 Marc Alff	2009-10-29
      Bug#38967 Unused mutex LOCK_Acl
      
      Backport to 5.5
[31 Oct 2009 8:17] Bugs System 
Pushed into 6.0.14-alpha (revid:alik@sun.com-20091031081410-qkxmjsdzjmj840aq) (version source revid:marc.alff@sun.com-20091029213317-ct3xfflphozct2r8) (merge vers: 6.0.14-alpha) (pib:13)
[31 Oct 2009 17:50] Paul DuBois 
Already fixed in earlier 6.0.x.

Setting report to NDI pending push to 5.5.x.
[4 Nov 2009 18:52] Marc ALFF 
Merged in 5.5.0, in mysql-next-mr
[5 Nov 2009 1:46] Paul DuBois 
Cosmetic change. No changelog entry needed.
[12 Nov 2009 8:21] Bugs System 
Pushed into 5.5.0-beta (revid:alik@sun.com-20091110093229-0bh5hix780cyeicl) (version source revid:mikael@mysql.com-20091102100915-a2nbfxaqprpgptfw) (merge vers: 5.5.0-beta) (pib:13)