MySQL Bugs: #38349: Many tests in WL#4288 fail to clean up after themselves

Bug #38349	Many tests in WL#4288 fail to clean up after themselves
Submitted:	24 Jul 2008 13:51	Modified:	30 Jan 2009 17:19
Reporter:	Sven Sandberg	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tests: Server	Severity:	S7 (Test Cases)
Version:	5.1	OS:	Any
Assigned to:	Horst Hunger	CPU Architecture:	Any
Tags:	_basic.test, _func.test, 51rpl, clean up, test case, wl#4288

Description:
Many of the tests added to the main suite in WL#4288 fail to clean up after themselves.

This was not visible in the tree where they were pushed, but causes problems in the replication tree because it has a new version of mtr. The new version of mtr is able to run tests in parallel, which means that tests are executed in other sequences than before, causing strange failures when tests don't clean up after themselves.

The good news is that the new mtr checks that test cases clean up after themselves, so it is straightforward to find the problematic tests. Many of the tests which cause trouble come from WL#4288 (i.e., they end with _func.test or _basic.test).

How to repeat:
Run mtr in 5.1-rpl

Suggested fix:
Make the tests clean up after themselves.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/50503

2676 Horst Hunger	2008-07-25
      Fix for bug#38349 (duplicate of bug#36536) for 5.1.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/50519

2677 Horst Hunger	2008-07-25
      2. fix for bug#38349 for 5.1 after having the results with the new mtr.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/52174

2679 Horst Hunger	2008-08-20
      Some improvements and missing fixes for bug#38349.

I made a first review of a bunch (not all) of
the modified tests. Comments were sent by email
to Horst.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/52870

2660 Horst Hunger	2008-08-28
      Inserted the resuts of the first quick review of the changesets of bug#38349:
      Besides code changes also better format and beautification. I also changes some tests not belonging to WL#4288 
      having the same symtoms: innodb.test, log_state.test, variables_embedded.test, log_tables.test, insert_update.test,
      profiling.test and variables.test. 
      The test "concurrent_insert_func.test" was changed due to some hints given in bug#39009. It was not the server
      but the tests client that hang due to a table locking, that now can be seen in the result.
      Be aware, that the target tree for that bug is the "5.1-rpl" team tree.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/53616

2661 Horst Hunger	2008-09-09
      Fix for bug#38349: Changes after 1. review.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/53773

2681 Horst Hunger	2008-09-10
      Fix for bug#38349: concurrent_insert_func must not with embedded server.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/53774

2681 Horst Hunger	2008-09-10
      Fix for bug#38349: concurrent_insert_func must not with embedded server.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/53776

2680 Horst Hunger	2008-09-10
      Final fix for bug#38349: Did the changes due to the 2 reviews.
      - Updated slow_query_log_file_basic and general_log_file basis instead of the func version as
      the func version run good but the basic versions fail.
      - Sent innodb.test to dev@innodb.com.
      - variables.test has differences probably due to a bug in mtr or in the SET statement (see bug#39369).
      - general_log_file_basic.test and slow_query_log_file_bsaic.test have differences, which might be 
      produced by the new mtr (see bug#38124).

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/53777

2680 Horst Hunger	2008-09-10
      Final fix for bug#38349: Did the changes due to the 2 reviews.
      - Updated slow_query_log_file_basic and general_log_file basis instead of the func version as
      the func version run good but the basic versions fail.
      - Sent innodb.test to dev@innodb.com.
      - variables.test has differences probably due to a bug in mtr or in the SET statement (see bug#39369).
      - general_log_file_basic.test and slow_query_log_file_bsaic.test have differences, which might be 
      produced by the new mtr (see bug#38124).

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/53907

2695 He Zhenxing	2008-09-12 [merge]
      Auto merge

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/53908

2695 He Zhenxing	2008-09-12 [merge]
      Auto merge

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54481

2694 He Zhenxing	2008-09-22 [merge]
      Auto Merge

Pushed into 6.0.10-alpha (revid:luis.soares@sun.com-20090129165607-wiskabxm948yx463) (version source revid:luis.soares@sun.com-20090129163120-e2ntks4wgpqde6zt) (merge vers: 6.0.10-alpha) (pib:6)

Pushed into 5.1.32 (revid:luis.soares@sun.com-20090129165946-d6jnnfqfokuzr09y) (version source revid:hezx@mysql.com-20080929053642-b2mfvfhzisrzj274) (merge vers: 5.1.30) (pib:6)

Test case changes. No changelog entry needed.

Pushed into 5.1.32-ndb-6.3.23 (revid:tomas.ulin@sun.com-20090217131017-6u8qz1edkjfiobef) (version source revid:tomas.ulin@sun.com-20090203133556-9rclp06ol19bmzs4) (merge vers: 5.1.32-ndb-6.3.22) (pib:6)

Pushed into 5.1.32-ndb-6.4.3 (revid:tomas.ulin@sun.com-20090217134419-5ha6xg4dpedrbmau) (version source revid:tomas.ulin@sun.com-20090203133556-9rclp06ol19bmzs4) (merge vers: 5.1.32-ndb-6.3.22) (pib:6)

Pushed into 5.1.32-ndb-6.2.17 (revid:tomas.ulin@sun.com-20090217134216-5699eq74ws4oxa0j) (version source revid:tomas.ulin@sun.com-20090201210519-vehobc4sy3g9s38e) (merge vers: 5.1.32-ndb-6.2.17) (pib:6)