MySQL Bugs: #37938: Test "mysqldump" lacks various INSERT statements / values

Bug #37938	Test "mysqldump" lacks various INSERT statements / values
Submitted:	7 Jul 2008 16:33	Modified:	17 Oct 2008 17:44
Reporter:	Joerg Bruehe	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tests: Server	Severity:	S3 (Non-critical)
Version:	5.1.26-rc	OS:	Any
Assigned to:	Patrick Crews	CPU Architecture:	Any

Description:
This report is about test failures detected in the 5.1.26-rc build.

Such occurrences have also been seen in 5.1.24, but in a much smaller number.
There may have been builds in which the analysis was not fully done, so the problem may be older.

30 runs of this test fail (in different but probably related ways),
per difference it is between 1 and 7 runs in which it occurs.

The symptom is that the log on the build hosts is lacking some insert statements present in the ".result" file,
or that an insert statement contains fewer values than expected.

The exact statements affected vary, I have not seen a clear pattern.
I will append the full list of differences as a separate file,
it is about 29 kB large.

*All* failures have in common that the output starts with these lines:
=====
mysqldump: Couldn't find table: "non_existing"
mysqldump: Got error: 1356: View 'test.v1' references invalid table(s) or column(s) or function(s) or definer/
invoker of view lack rights to use them when using LOCK TABLES
mysqldump: Couldn't execute 'SHOW FIELDS FROM `v1`': View 'test.v1' references invalid table(s) or column(s) o
r function(s) or definer/invoker of view lack rights to use them (1356)
mysqldump: user2 has insufficent privileges to SHOW CREATE PROCEDURE `sp1`!
=====

How to repeat:
Run the test suite (sufficiently often ?).

Test failures on the various platforms

Attachment: mysqldump_failures_5.1.26-rc (application/octet-stream, text), 29.38 KiB.

After some research, found the following:

The incomplete lines that are found are mysqldump output.
The lines are incomplete because the components are the result of separate insert statements:

As an example:

INSERT INTO <table> VALUES (1),(2),(3),(4),(5),(6); 
is the result of two statements INSERT (1),(2),(3) and INSERT (4),(5),(6)
Somehow, one or more of these lines aren't fully processed before MYSQLDUMP is called by the test.

Am currently working on inserting SLEEP's between these INSERTS and the MYSQLDUMP call to see if this fixes the problem.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/52909

2725 Patrick Crews	2008-08-29
      Bug#37938 Test "mysqldump" lacks various INSERT statements / values
      
      Found that the test was failing due to INSERTs not being fully processed before a call to mysqldump.
      Inserted --sleep statements to ensure some time passes before a mysqldump call.
      
      Ran the test 2500 times without failure.  The test was failing ~1/5 times before the changes.

This problem looks very similar to what is reported here: http://bugs.mysql.com/bug.php?id=37521

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/53554

2735 Patrick Crews	2008-09-08
      Bug#37938 Test "mysqldump" lacks various INSERT statements / values
      
      Altered the .test file to turn concurrent inserts off.  We reset concurrent_insert
      to the original value at the end of the test
      
      Re-recorded the .result file to account for the variable changes.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54151

2679 Patrick Crews	2008-09-15
      Bug#37938 Test "mysqldump" lacks various INSERT statements / values
      
      Moved fix for this bug to 5.0 as other mysqldump bugs seem tied to concurrent_insert being on
      Setting concurrent_insert off during this test as INSERTs weren't being 
      completely processed before the calls to mysqldump, resulting in failing tests.
      
      Altered .test file to turn concurrent_insert off during the test and to restore it
      to whatever the value was at the start of the test when complete.
      
      Re-recorded .result file to account for changes to variables in the test.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54153

2742 Patrick Crews	2008-09-15 [merge]
      Bug#37938 Test "mysqldump" lacks various INSERT statements / values
      
      Merge of fixes from 5.0 -> 5.1
      Moved restoration of concurrent_insert's original value to the end of the 5.1 tests
      Re-recorded .result file to account for changes to test file.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54156

2842 Patrick Crews	2008-09-15 [merge]
      Bug#37938 Test "mysqldump" lacks various INSERT statements / values
      Upmerge from 5.1 -> 6.0

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54157

2842 Patrick Crews	2008-09-15 [merge]
      Bug#37938 Test "mysqldump" lacks various INSERT statements / values
      Upmerge from 5.1 -> 6.0

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54161

2679 Patrick Crews	2008-09-15
      Bug#37938 Test "mysqldump" lacks various INSERT statements / values
      
      Moved fix for this bug to 5.0 as other mysqldump bugs seem tied to concurrent_insert being on
      Setting concurrent_insert off during this test as INSERTs weren't being 
      completely processed before the calls to mysqldump, resulting in failing tests.
      
      Altered .test file to turn concurrent_insert off during the test and to restore it
      to whatever the value was at the start of the test when complete.
      
      Re-recorded .result file to account for changes to variables in the test.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54201

Pushed into 5.1.30  (revid:patrick.crews@sun.com-20080915202645-hlun1rh8b57ixa6j) (version source revid:kpettersson@mysql.com-20080915214458-ejxj7ltezohabr3z) (pib:4)

This is actually pushed to 5.1.29, not 5.1.30.

Test case changes. No changelog entry needed.

Setting report to NDI pending push into 6.0.x.

Pushed into 6.0.8-alpha  (revid:patrick.crews@sun.com-20080915203924-irxxbju422t72in2) (version source revid:kpettersson@mysql.com-20080915213305-1ljm3tx7tgsdrne9) (pib:5)

No changelog entry needed.

Pushed into 5.1.29-ndb-6.2.17  (revid:patrick.crews@sun.com-20080915202645-hlun1rh8b57ixa6j) (version source revid:tomas.ulin@sun.com-20081028140209-u4emkk1xphi5tkfb) (pib:5)

Pushed into 5.1.29-ndb-6.3.19  (revid:patrick.crews@sun.com-20080915202645-hlun1rh8b57ixa6j) (version source revid:tomas.ulin@sun.com-20081028194045-0353yg8cvd2c7dd1) (pib:5)

Pushed into 5.1.29-ndb-6.4.0  (revid:patrick.crews@sun.com-20080915202645-hlun1rh8b57ixa6j) (version source revid:jonas@mysql.com-20081101082305-qx5a1bj0z7i8ueys) (pib:5)