| Bug #37834 | mtr --max-test-fail=0 does not set max number of failed tests to unlimited | ||
|---|---|---|---|
| Submitted: | 3 Jul 2008 9:48 | Modified: | 30 Jan 2009 17:15 |
| Reporter: | Sven Sandberg | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Tests | Severity: | S3 (Non-critical) |
| Version: | 5.1-rpl | OS: | Any |
| Assigned to: | Sven Sandberg | CPU Architecture: | Any |
| Tags: | 51rpl, max-test-fail, mtr, unlimited | ||
[22 Jul 2008 18:49]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/50217 2632 Sven Sandberg 2008-07-22 BUG#37834: mtr --max-test-fail=0 does not set max number of failed tests to unlimited Problem: mtr --max-test-fail=0 should allow unlimited number of errors, but stops after the second error. Fix: It's just a typo in mysql-test-run.pl
[22 Jul 2008 18:50]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/50218 2632 Sven Sandberg 2008-07-22 BUG#37834: mtr --max-test-fail=0 does not set max number of failed tests to unlimited Problem: mtr --max-test-fail=0 should allow unlimited number of errors, but stops after the second error. Fix: It's just a typo in mysql-test-run.pl
[22 Jul 2008 18:52]
Sven Sandberg
pushed to 5.1-rpl
[30 Jan 2009 13:29]
Bugs System
Pushed into 6.0.10-alpha (revid:luis.soares@sun.com-20090129165607-wiskabxm948yx463) (version source revid:luis.soares@sun.com-20090129163120-e2ntks4wgpqde6zt) (merge vers: 6.0.10-alpha) (pib:6)
[30 Jan 2009 15:09]
Bugs System
Pushed into 5.1.32 (revid:luis.soares@sun.com-20090129165946-d6jnnfqfokuzr09y) (version source revid:sven@mysql.com-20080722185520-xb3szhkjx2s0t1yz) (merge vers: 5.1.28) (pib:6)
[30 Jan 2009 17:15]
Paul DuBois
Test suite changes. No changelog entry needed.
[17 Feb 2009 14:58]
Bugs System
Pushed into 5.1.32-ndb-6.3.23 (revid:tomas.ulin@sun.com-20090217131017-6u8qz1edkjfiobef) (version source revid:tomas.ulin@sun.com-20090203133556-9rclp06ol19bmzs4) (merge vers: 5.1.32-ndb-6.3.22) (pib:6)
[17 Feb 2009 16:46]
Bugs System
Pushed into 5.1.32-ndb-6.4.3 (revid:tomas.ulin@sun.com-20090217134419-5ha6xg4dpedrbmau) (version source revid:tomas.ulin@sun.com-20090203133556-9rclp06ol19bmzs4) (merge vers: 5.1.32-ndb-6.3.22) (pib:6)
[17 Feb 2009 18:22]
Bugs System
Pushed into 5.1.32-ndb-6.2.17 (revid:tomas.ulin@sun.com-20090217134216-5699eq74ws4oxa0j) (version source revid:tomas.ulin@sun.com-20090201210519-vehobc4sy3g9s38e) (merge vers: 5.1.32-ndb-6.2.17) (pib:6)
Description: mtr --help says: max-test-fail Limit the number of test failurs before aborting the current test run. Defaults to 10, set to 0 for no limit. Set it's default with MTR_MAX_TEST_FAIL However, if I run $ ./mtr --max-test-fail=0 then it will stop on the second error How to repeat: ./mtr --max-test=fail=0 where the suite contains at least two failing tests. Suggested fix: This is just a typo in mysql-test/mysql-test-run.pl === modified file 'mysql-test/mysql-test-run.pl' --- mysql-test/mysql-test-run.pl 2008-06-19 08:10:37 +0000 +++ mysql-test/mysql-test-run.pl 2008-07-03 09:44:22 +0000 @@ -451,7 +451,7 @@ push(@$completed, $result); return $completed; } - elsif ($num_failed_test > 0 and + elsif ($opt_max_test_fail > 0 and $num_failed_test >= $opt_max_test_fail) { $suite_timeout_proc->kill(); mtr_report("Too many tests($num_failed_test) failed!",