Bug #37380 Test funcs_1.is_columns_myisam_embedded fails on OS X
Submitted: 12 Jun 2008 19:39 Modified: 29 Jul 2008 9:55
Reporter: Patrick Crews Email Updates:
Status: Closed Impact on me:
None 
Category:Tests: Server Severity:S3 (Non-critical)
Version:5.0 OS:Mac OS X (10.5)
Assigned to: Patrick Crews CPU Architecture:Any
Tags: funcs_1, information_schema, mac, myisam, os x, Tests
Triage: D3 (Medium)

[12 Jun 2008 19:39] Patrick Crews
Description:
Test funcs_1.is_columns_myisam_embedded fails on Mac OS X.

Sample test diffs
-NULL	test	tb4	f221	46	CURRENT_TIMESTAMP	NO	timestamp	NULL	NULL	NULLNULL	NULL	NULL	timestamp				
+NULL	test	tb4	f221	46	CURRENT_TIMESTAMP	NO	timestamp	NULL	NULL	NULLNULL	NULL	NULL	timestamp		on update CURRENT_TIMESTAMP

-NULL	test	tb3	f129	12		NO	binary	1	1	NULL	NULL	NULL	NULLbinary(1)				
+NULL	test	tb3	f129	12		NO	binary	1	1	NULL	NULL	NULL	NULLbinary(1)

Found this on 5.0 and 5.1 builds without the --with-extra-charsets=complex in configuration.  Not 100% certain if this is needed.  Still testing other builds and will update the bug as more information is found (unless the bug is corrected first)

How to repeat:
Build MySQL without using --with-extra-charsets-complex

Run the following from the mysql-test directory
./mysql-test-run --suite=funcs_1 --force --embedded-server is_columns_myisam_embedded

You should observe 3-4 sets of differences between actual and expected results.

Suggested fix:
Still researching to see what is causing a failure for the seemingly matched differences (see the second example diff).

1)  Determine if this is a test issue of a problem with the actual Server's behavior on Mac OSX.
2)  Fix the test if it is a test issue or reassign the bug to an appropriate developer if this belongs to the server.
[13 Jun 2008 10:32] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/47834
[13 Jun 2008 11:20] Matthias Leich
My changeset does not fix this bug.
It only mentions the bug and skips tests which might
suffer from it.
Setting the status back to verified.
[16 Jun 2008 18:40] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/47932
[18 Jun 2008 15:04] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48102
[18 Jun 2008 15:57] Matthias Leich
Changeset is not intended to fix this bug.
Our commit triggers seem to react on
"Bug nnn".
[18 Jun 2008 17:25] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48113
[20 Jun 2008 12:58] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48239
[20 Jun 2008 15:11] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48248
[20 Jun 2008 15:13] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48249
[24 Jun 2008 1:21] Patrick Crews
This bug just 'went away' on the latest version of the 5.0 tree.

I had determined that there was an extra character '\x05' in difference lines such as this:
-NULL	test	tb3	f129	12		NO	binary	1	1	NULL	NULL	NULL	NULLbinary(1)

The extra character was before the '\t' separating the 12 from the NO data fields and causing mismatches.

On the latest update of my working tree, this behavior disappeared.  Tried to get the test to fail with multiple build configurations (with and without complex character sets, etc, etc) and could no longer duplicate the bug.

Will be submitting a patch to re-enable the test on Mac OS systems.
[24 Jun 2008 2:30] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48366

2641 Patrick Crews	2008-06-23
      Bug#37380 - Test funcs_1.is_columns_myisam_embedded fails on OS X.
      
      Re-enabling the test on OS X due to disappearance of test failure.  
      Was including extra '\x05' character in results, but behavior has disappeared on newer versions of server
[1 Jul 2008 18:45] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48832

2642 Patrick Crews	2008-07-01
      Bug#37380 - Test funcs_1.is_columns_myisam_embedded fails on OS X
      
      Test was failing due to the addition of a '\x05' character in result sets
      Latest builds of the server have shown this problem to have disappeared.
      Removing code within the test that disables the test on Mac OS X.
      
      Recommit due to tree error on earlier, approved patch.
[1 Jul 2008 23:25] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48847

2642 Patrick Crews	2008-07-01
      Bug#37380 - Test funcs_1.is_columns_myisam_embedded fails on OS X
      
      Test was failing due to the addition of a '\x05' character in result sets
      Latest builds of the server have shown this problem to have disappeared.
      Removing code within the test that disables the test on Mac OS X.
      
      Recommit due to tree error on earlier, approved patch.
[2 Jul 2008 17:05] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48897

2643 Timothy Smith	2008-07-02
      Fix "C++ code in C file" syntax error in mysys/default.c
[9 Jul 2008 12:42] Georgi Kodinov
Pushed in 5.0.66
[28 Jul 2008 13:47] Bugs System
Pushed into 5.0.68  (revid:kpettersson@mysql.com-20080715152926-s5kgnqhtu93b3c8v) (pib:2)
(Retry automatic marking, to ensure nothing is missed. cm01)
[28 Jul 2008 16:47] Bugs System
Pushed into 5.1.28  (revid:joerg@mysql.com-20080714105031-88hmr2baz5di9xej) (version source revid:joerg@mysql.com-20080714105031-88hmr2baz5di9xej) (pib:3)
[28 Jul 2008 17:41] Paul Dubois
Test case-related changes. No 5.0.x/5.1.x changelog entries needed.

Setting report to Patch Queued pending push of fix into 6.0.x.
[29 Jul 2008 8:54] Georgi Kodinov
Pushed in 6.0.7-alpha
[29 Jul 2008 9:55] Jon Stephens
Closed per comment from Paul.