Bug #37302 missing DBUG_RETURN macro in function "find_key_block" (5.0 only)
Submitted: 10 Jun 2008 8:33 Modified: 12 Aug 2008 17:32
Reporter: Shane Bester (Platinum Quality Contributor) Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Errors Severity:S3 (Non-critical)
Version:5.0.66-debug OS:Any
Assigned to: Marc ALFF CPU Architecture:Any

[10 Jun 2008 8:33] Shane Bester 
Description:
in 5.0 debug builds I got this error message in the logs:

missing DBUG_RETURN or DBUG_VOID_RETURN macro in function "find_key_block"

How to repeat:
set global key_cache_block_size=512;
set global key_cache_block_size=1024;

Suggested fix:
replace the "return 0;" with "DBUG_RETURN(0)" in the function find_key_block in mf_keycache.c
[11 Jun 2008 16:48] Susanne Ebrecht 
Many thanks for writing a bug report.

Unfortunately I can't repeat this by using 5.0.66-debug (bzr tree from today).

Also I couldn't reproduce with 5.1 bzr tree.

Looking into the 5.0 code, I found DBUG_RETURN(something) as well as "return 0;"
[4 Jul 2008 19:45] MySQL Verification Team 
there are still "return  0;" lines in the function find_key_block. perhaps certain code paths lead to them, still the warnings can be annoying.  check the code, ./mysys/mf_keycache.c
[29 Jul 2008 17:55] Marc ALFF 
Verified by code review:

find_key_block() is missing DBUG_RETURN in some code paths,
in 5.0.68

Verified by code review:

The code is already fixed in 5.1.28 and 6.0.7
[11 Aug 2008 21:08] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51351

2658 Marc Alff	2008-08-11
      Bug#37302 (missing DBUG_RETURN macro in function "find_key_block" (5.0 only))
      
      Fixed missing DBUG_RETURN in the function find_key_block
[11 Aug 2008 21:16] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51352

2658 Marc Alff	2008-08-11
      Bug#37302 (missing DBUG_RETURN macro in function "find_key_block" (5.0 only))
      
      Fixed missing DBUG_RETURN in the function find_key_block
[11 Aug 2008 21:21] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51353

2657 Marc Alff	2008-08-11 [merge]
      Merge mysql-5.0-bugteam -> local bugfix branch
[11 Aug 2008 22:45] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51358

2691 Marc Alff	2008-08-11 [merge]
      Manual merge of mysql-5.0-bugteam -> mysql-5.1-bugteam
      
      Note: NULL merge of sql/sql_yacc.yy, the fix for bug#38296 will be provided separately for 5.1
[11 Aug 2008 23:06] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51359

2691 Marc Alff	2008-08-11 [merge]
      Manual merge of mysql-5.0-bugteam -> mysql-5.1-bugteam
      
      Note: NULL merge of sql/sql_yacc.yy, the fix for bug#38296 will be provided separately for 5.1
[12 Aug 2008 15:05] Bugs System 
Pushed into 5.1.28  (revid:marc.alff@sun.com-20080811210812-8fou4cdke83pqndq) (version source revid:davi.arnaut@sun.com-20080812142843-he05ncsggstbn57z) (pib:3)
[12 Aug 2008 17:32] Paul DuBois 
No changelog entry needed (I think).
[12 Aug 2008 19:07] Bugs System 
Pushed into 5.0.68  (revid:marc.alff@sun.com-20080811210812-8fou4cdke83pqndq) (version source revid:davi.arnaut@sun.com-20080812185100-d47qb8mz2ye6pe6b) (pib:3)
[13 Aug 2008 16:26] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51535

2758 Marc Alff	2008-08-13 [merge]
      Merge 5.1-bugteam -> 6.0-bugteam
      
      Manual merge of sql_yacc.yy
[13 Aug 2008 16:28] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51536

2758 Marc Alff	2008-08-13 [merge]
      Merge 5.1-bugteam -> 6.0-bugteam
      
      Manual merge of sql_yacc.yy
[14 Aug 2008 8:19] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51605

2685 He Zhenxing	2008-08-14 [merge]
      Merge 5.1-rpl-testfixes -> 6.0-rpl-testfixes
[15 Aug 2008 2:01] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/51688

2769 He Zhenxing	2008-08-15 [merge]
      Merge 6.0-rpl-testfixes -> 6.0
[19 Aug 2008 20:01] Bugs System 
Pushed into 6.0.7-alpha  (revid:marc.alff@sun.com-20080811210812-8fou4cdke83pqndq) (version source revid:sven@mysql.com-20080818175803-c1nutd5773r6b4gd) (pib:3)
[28 Aug 2008 20:16] Bugs System 
Pushed into 6.0.7-alpha  (revid:cbell@mysql.com-20080822132131-uveo6wiuecy6m2b8) (version source revid:cbell@mysql.com-20080822132131-uveo6wiuecy6m2b8) (pib:3)
[14 Sep 2008 6:06] Bugs System 
Pushed into 6.0.7-alpha  (revid:marc.alff@sun.com-20080811210812-8fou4cdke83pqndq) (version source revid:timothy.smith@sun.com-20080813081348-d1t79whh0xmepllq) (pib:3)