Bug #36625 Please remove the rpl_probe and rpl_parse features from the server

• Submitted: 9 May 2008 14:06
• Modified: 3 Sep 2010 14:34
• Reporter: Sven Sandberg
• Status: Can't repeat
• Category: MySQL Server: Replication
• Severity: S3 (Non-critical)
• Version: 5.1, 6.0
• OS: Any
• Assigned to: Sven Sandberg
• CPU Architecture: Any
• Tags: dead code, disable_rpl_parse, enable_rpl_parse, rpl_parse, rpl_probe

[9 May 2008 14:06] Sven Sandberg

Description:
The "rpl_probe" and "rpl_parse" features don't do anything useful. They are only used by mysqltest.c and by some places in the server which are inside "#ifdef TO_BE_REMOVED". The functionality exported to the test language by mysqltest.c is only used in rpl_redirect, which does not test anything useful.

These features were supposed to be for fail-safe replication but were never finished and abandoned around 2003.

How to repeat:
Read the code.

Suggested fix:
Remove all traces of rpl_probe and rpl_parse from the server.
Remove rpl_redirect.test.

[15 May 2008 19:19] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/46748

ChangeSet@1.2562, 2008-05-15 21:19:58+02:00, sven@riska.(none) +3 -0
  BUG#36625: Please remove the rpl_probe and rpl_parse features from the server
  The rpl_probe and rpl_parse features were abandoned in 2003 but traces of
  them still remain in the server and in the test language. This fix removes
  a test case that tested the feature, and un-exposes the features to the
  test language.

[6 Nov 2008 9:57] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/57971

2698 Sven Sandberg	2008-11-06
      BUG#36625: Please remove the rpl_probe and rpl_parse features from the server
      Problem 1: BUG#36625: rpl_redirect doesn't do anything useful. It tests an
      obsolete feature that was never fully implemented.
      Fix 1: Remove rpl_redirect.
      Problem 2: rpl_innodb_bug28430 and rpl_flushlog_loop are disabled despite the
      bugs for which they were disabled have been fixed.
      Fix 2: Re-enable rpl_innodb_bug28430 and rpl_flushlog_loop.

[6 Nov 2008 10:12] Sven Sandberg

The above changeset has been pushed to 5.1 main. It only removes the test case.

The server changes and the changes to mysql-test will be targeted to 6.0.

[6 Nov 2008 10:13] Bugs System

Pushed into 5.1.30  (revid:[e-mail]-20081106100055-rglw51og834wshqf) (version source revid:[e-mail]-20081106100055-rglw51og834wshqf) (pib:5)

[10 Nov 2008 10:52] Bugs System

Pushed into 6.0.8-alpha  (revid:[e-mail]-20081106100055-rglw51og834wshqf) (version source revid:[e-mail]-20081106161825-9biri1v40v7b0kg3) (pib:5)

[21 Nov 2008 21:02] Bugs System

Pushed into 5.1.30-ndb-6.2.17  (revid:[e-mail]-20081106100055-rglw51og834wshqf) (version source revid:[e-mail]-20081121161314-jhz3twf5xjt8stnh) (pib:5)

[21 Nov 2008 23:45] Bugs System

Pushed into 5.1.30-ndb-6.3.20  (revid:[e-mail]-20081106100055-rglw51og834wshqf) (version source revid:[e-mail]-20081121210644-zas6e9wa5kuj7d6f) (pib:5)

[27 Nov 2008 14:52] Bugs System

Pushed into 5.1.30-ndb-6.4.0  (revid:[e-mail]-20081106100055-rglw51og834wshqf) (version source revid:[e-mail]-20081126125835-5sohkzk2jjwpq1wp) (pib:5)

[3 Sep 2010 14:34] Sven Sandberg

This is already fixed in trunk. I don't know when it was fixed.