Bug #34686 change master w/o explict master_heartbeat_period dont reset period to default
Submitted: 20 Feb 2008 12:26 Modified: 26 Mar 2008 20:14
Reporter: Andrei Elkin Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Replication Severity:S3 (Non-critical)
Version:6.0,5.1-telco-6.3 OS:Any
Assigned to: Andrei Elkin CPU Architecture:Any
Tags: heartbeat

[20 Feb 2008 12:26] Andrei Elkin
Description:
CHANGE Master w/o the explicit  master_heartbeat_period is supposed to
reset the period to the value of @@global.slave_net_timeout/2.

rpl_heartbeat test passed earlier without noticing the problem because of
a bad lack of choosing the init value of the global var by mtr that supplies it o the starting server.
Once the init value of the global has changed there appears the test failures on mysql-5.1-telco-6.3 tree.

How to repeat:
./mysql-test-run.pl --mysqld=--slave-net-timeout=60  rpl_heartbeat
[20 Feb 2008 13:02] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/42645

ChangeSet@1.2609, 2008-02-20 15:02:10+02:00, aelkin@mysql1000.dsl.inet.fi +2 -0
  Bug #34686 change master w/o explict master_heartbeat_period dont reset period to default
      
  There appeared failures on 5.1-telco-6.3 tree after mtr started using 
  bigger value to init @@global.slave_net.timeout.
  Whereas the very first default setting was correct to follow
  hb=slave_net_timeout/2 rule
  rule, the following CHANGE master w/o the keyword failed.
      
  Fixed with enforcing logics in change_master() to reset the heartbeat period
  to the specified slave_net_timeout/2 when the option is not passed to
  CHANGE master command.
[20 Feb 2008 13:13] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/42647

ChangeSet@1.2609, 2008-02-20 15:12:47+02:00, aelkin@mysql1000.dsl.inet.fi +2 -0
  Bug #34686 change master w/o explict master_heartbeat_period dont reset period to default
      
  There appeared failures on 5.1-telco-6.3 tree after mtr started using 
  bigger value to init @@global.slave_net.timeout.
  Whereas the very first default setting was correct to follow
  hb=slave_net_timeout/2 rule
  rule, the following CHANGE master w/o the keyword failed.
      
  Fixed with enforcing logics in change_master() to reset the heartbeat period
  to the specified slave_net_timeout/2 when the option is not passed to
  CHANGE master command.
[20 Feb 2008 21:31] Andrei Elkin
Pushed to mysql-5.1-telco-6.3 from mysql-5.1-rpl-heartbeat.
Todo: to push to 6.0-rpl.
[8 Mar 2008 10:16] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/43642

ChangeSet@1.2590, 2008-03-08 12:14:47+02:00, aelkin@mysql1000.(none) +2 -0
  Bug #34686 change master w/o explict master_heartbeat_period dont reset
                 period to default
      
      The original patch has been pushed to 5.1-telco-6.3.
      This separate one is for 6.0 because merging is in reverse:
      6.0->telco.
      
  CHANGE Master w/o the explicit  master_heartbeat_period is supposed to
  reset the period to the value of @@global.slave_net_timeout/2.
  However, there was a possibility to get the hb status un-reset preserving its
  former value.
  Fixed with adding a rule to reset to the default in change_master().
  sql/sql_repl.cc
  ensuring hb repiod gets reset to the specified default.
[26 Mar 2008 19:00] Bugs System
Pushed into 6.0.5-alpha
[26 Mar 2008 20:14] Jon Stephens
Documented in the 6.0.5 changelog as follows:

        A CHANGE MASTER statement with no
        MASTER_HEARTBEAT_PERIOD option failed to reset the
        heartbeat period to its default value.
[2 Apr 2008 20:11] Jon Stephens
Fix also noted in the 5.1.23-ndb-6.3.11 changelog.
[3 Dec 2009 13:45] Jon Stephens
Also documented in the 5.6.0 changelog. See BUG#48463.
[7 Mar 2010 1:47] Paul Dubois
Changed 5.6.0 changelog entry to 5.5.3.