Bug #34458 Extreneous use of templates in server code
Submitted: 11 Feb 2008 14:08 Modified: 26 Mar 2008 8:20
Reporter: Mats Kindahl Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Row Based Replication ( RBR ) Severity:S3 (Non-critical)
Version: OS:Any
Assigned to: Mats Kindahl CPU Architecture:Any

[11 Feb 2008 14:08] Mats Kindahl
Description:
In the code for row-based replication, there is a use of a template function that is not needed.

How to repeat:
Read the code.

Suggested fix:
Refactor the code to use a Builder or Factory Method pattern instead.
[12 Feb 2008 16:55] Susanne Ebrecht
Mats,

please can you tell the team, where exactly this would be? Some more detailed informations?

Many thanks,

Susanne
[13 Feb 2008 21:00] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/42243

ChangeSet@1.2548, 2008-02-13 22:00:01+01:00, mats@kindahl-laptop.dnsalias.net +1 -0
  Bug #34458  	Extreneous use of templates in server code
  
  Replacing a template function with a normal static function.
  The template parameter, which previously was supplied as a
  template parameter, is now passed using an enumeration
  constant.
[15 Feb 2008 11:19] Michael Widenius
Ok to push after changing binlog_log_row() to take a pointer to the binlog_row_logging_function() instead of using an enum.
[15 Feb 2008 11:47] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/42345

ChangeSet@1.2548, 2008-02-15 12:47:42+01:00, mats@kindahl-laptop.dnsalias.net +1 -0
  Bug #34458  	Extreneous use of templates in server code
  
  Replacing a template function with a normal static function.
  The template parameter, which previously was the class to
  find a binlogging function in, is now passed as a pointer to
  the actual binlogging function instead.
  
  The patch requires change of indention, but that is submitted
  as a separate patch.
[15 Feb 2008 11:56] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/42347

ChangeSet@1.2548, 2008-02-15 12:56:44+01:00, mats@kindahl-laptop.dnsalias.net +1 -0
  Bug #34458  	Extreneous use of templates in server code
  
  Replacing a template function with a normal static function.
  The template parameter, which previously was the class to
  find a binlogging function in, is now passed as a pointer to
  the actual binlogging function instead.
  
  The patch requires change of indention, but that is submitted
  as a separate patch.
[15 Feb 2008 12:06] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/42349

ChangeSet@1.2549, 2008-02-15 13:06:28+01:00, mats@kindahl-laptop.dnsalias.net +1 -0
  Bug #34458  	Extreneous use of templates in server code
  
  Patch to remove white-space left over after removing anonymous
  namespace.
[25 Mar 2008 11:22] Bugs System
Pushed into 5.1.24-rc
[26 Mar 2008 8:20] Jon Stephens
Thank you for your bug report. This issue has been committed to our source repository of that product and will be incorporated into the next release.

If necessary, you can access the source repository and build the latest available version, including the bug fix. More information about accessing the source trees is available at

    http://dev.mysql.com/doc/en/installing-source.html

Discussed with Mats; no user changes to document; closed without further action.
[26 Mar 2008 19:00] Bugs System
Pushed into 6.0.5-alpha