Bug #34183 Missing DBUG_RETURN in alloc_root
Submitted: 31 Jan 2008 0:36 Modified: 20 May 2008 23:16
Reporter: Marc ALFF Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Logging Severity:S3 (Non-critical)
Version:5.1.24 OS:Any
Assigned to: Kristofer Pettersson CPU Architecture:Any

[31 Jan 2008 0:36] Marc ALFF
Description:
MySQL Version 5.1.24

In file mysys/my_alloc.c,
in function alloc_root(),

void *alloc_root(MEM_ROOT *mem_root, size_t length)
{
...
    if (!(next = (USED_MEM*) my_malloc(get_size,MYF(MY_WME))))
    {
      if (mem_root->error_handler)
        (*mem_root->error_handler)();
      return((void*) 0);                      /* purecov: inspected */

This error path does not use DBUG_RETURN

How to repeat:
code inspection
[31 Jan 2008 0:53] MySQL Verification Team
Thank you for the bug report.
[7 Apr 2008 9:21] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/44978

ChangeSet@1.2584, 2008-04-07 11:29:45+02:00, thek@adventure.(none) +1 -0
  Bug#34183 Missing DBUG_RETURN in alloc_root
  
  DBUG_RETURN was missing form an exit path in 5.1 branch of alloc_root
[20 Apr 2008 13:01] Bugs System
Pushed into 6.0.6-alpha
[20 May 2008 21:22] Bugs System
Pushed into 5.1.25-rc
[20 May 2008 23:16] Paul DuBois
No changelog entry needed.
[28 Jul 2008 16:54] Bugs System
Pushed into 5.1.25-rc  (revid:sp1r-kostja@bodhi.(none)-20080520073817-17550) (version source revid:sp1r-kostja@bodhi.(none)-20080520073817-17550) (pib:3)