MySQL Bugs: #33354: Backup: restore changes current database to null

Bug #33354	Backup: restore changes current database to null
Submitted:	19 Dec 2007 3:24	Modified:	20 Feb 2010 19:39
Reporter:	Peter Gulutzan	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Backup	Severity:	S3 (Non-critical)
Version:	6.0.5-alpha	OS:	Linux (SUSE 10 64-bit)
Assigned to:	Sanjay Manwani	CPU Architecture:	Any

Description:
I say 'use test'.
I backup database test.
I restore.
Now my current database is no long 'test', it is NULL.

How to repeat:
mysql> select database();
+------------+
| database() |
+------------+
| test       |
+------------+
1 row in set (0.00 sec)

mysql> backup database test to 'e';
+-----------+
| backup_id |
+-----------+
| 5         |
+-----------+
1 row in set (3.48 sec)

mysql> restore from 'e';
+-----------+
| backup_id |
+-----------+
| 6         |
+-----------+
1 row in set (3.46 sec)

mysql> select database();
+------------+
| database() |
+------------+
| NULL       |
+------------+
1 row in set (0.00 sec)

Thank you for the bug report. Verified as described.

[miguel@amanhecer 6.0b]$ bin/mysql -uroot
Welcome to the MySQL monitor.  Commands end with ; or \g.
Your MySQL connection id is 1
Server version: 6.0.5-alpha-debug Source distribution

Type 'help;' or '\h' for help. Type '\c' to clear the buffer.

mysql> use test
Database changed
mysql> backup database test to 'e';
+-----------+
| backup_id |
+-----------+
| 1         | 
+-----------+
1 row in set (1.83 sec)

mysql> restore from 'e';
+-----------+
| backup_id |
+-----------+
| 2         | 
+-----------+
1 row in set (3.49 sec)

mysql> select database();
+------------+
| database() |
+------------+
| NULL       | 
+------------+
1 row in set (0.00 sec)

mysql>

Another test case:

use test
create database q2;
create table q2.q (s1 int);
backup database q2 to 'b2';
restore from 'b2';
select database();
/* The database is now q2. */

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/86774

2881 Sanjay Manwani	2009-10-14
      BUG#33354 Backup: restore changes current database to null  
      
      Added a variable m_db_saved to Si_session_context to save the default database if available
      
      added test backup_use_db_restore.test and its result file

Setting back to in progress based on review of patch. No record of acceptance though. Sending email to request correct status.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/87160

Setting to in progress as there are serious issues in the patch WRT collateral test failures.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/89308

Patch rejected. Collateral test failures show that CREATE statements have been changed.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/90523

STATUS
------
Approved pending changes (under protest).

REQUIRED
--------
1. I have not received a satisfactory answer as to why the backup_events test fails with this patch and why it has not been fixed as requested. If this appears in the team tree it will cause complications for me not only as MC but also since I have a patch that alters the test. 

This alone should be enough to seek a fully justified reason the test fails. I strongly suggest when the reply is made as to why it is failing, that the test result be corrected before pushing so that it does not interfere with your colleague's work.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/90893

Asked for patch fixes.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/91630

Good to push.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/91885

2898 Sanjay Manwani	2009-11-27
      BUG#33354 Backup: restore changes current database to null
      
      Additional changes due to the backup_use_db_restore.test failures in PB
      
      @ backup_use_db_restore.test
      added the line "--source include/not_embedded.inc"

Pushed into 6.0.14-alpha (revid:ingo.struewing@sun.com-20100218152520-s4v1ld76bif06eqn) (version source revid:ingo.struewing@sun.com-20100119103538-wtp5alpz4p2jayl5) (merge vers: 6.0.14-alpha) (pib:16)

Noted in 6.0.14 changelog.

RESTORE caused the default database to become NULL.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/101264