Bug #33174 Backup: Numeric error values inside backup test scripts

• Submitted: 12 Dec 2007 16:46
• Modified: 30 Oct 2008 19:18
• Reporter: Rafal Somla
• Status: Closed
• Category: MySQL Server: Backup
• Severity: S3 (Non-critical)
• Version: 6.0 source
• OS: Any
• Assigned to: Rafal Somla
• CPU Architecture: Any

[12 Dec 2007 16:46] Rafal Somla

Description:
Some of the backup tests use command like:

--error 1146

this is going to fail when error numbers are changed due to new error messages
inserted into the errmsg.txt file.

How to repeat:
Inside mysql-test/ directory issue command:

$ grep -n '\-- \?error *[0-9]' t/backup*.test

It gives:

t/backup_ddl_blocker.test:271:--error 1146
t/backup_ddl_blocker.test:421:--error 1146
t/backup_fkey.test:48:--error 1452
t/backup_progress.test:232:--error 1049
t/backup_security.test:60:--error 1227
t/backup_security.test:66:--error 1227

Suggested fix:
One should use corresponding constant names instead, like this:

--error ER_BAD_DB_ERROR

[16 Sep 2008 8:34] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/54183

2693 Rafal Somla	2008-09-16
      BUG#33174 (Backup: Numeric error values inside backup test scripts)
      
      Before: Some backup tests used numeric error values in "--error" directives.
      
      After: Always a symbolic error constant is used.

[26 Sep 2008 16:10] Rafal Somla

Pushed into mysql-6.0-backup tree.

[24 Oct 2008 9:41] Rafal Somla

Somehow, the patch haven't made it to the team tree. Pushed again into mysql-6.0-backup

revision-id: [e-mail]-20081024082548-b7udqmrj9grcwjgo

[30 Oct 2008 12:45] Bugs System

Pushed into 6.0.8-alpha  (revid:[e-mail]-20080916083321-flbnmmxk5qrojlnu) (version source revid:[e-mail]-20081024082548-b7udqmrj9grcwjgo) (pib:5)

[30 Oct 2008 19:18] Paul DuBois

Test case changes. No changelog entry needed.