Bug #32831 libmysql should be built with all charsets

• Submitted: 28 Nov 2007 22:56
• Modified: 10 Feb 2009 21:19
• Reporter: Jess Balint
• Status: Closed
• Category: MySQL Server: Charsets
• Severity: S2 (Serious)
• Version: 5.1.22
• OS: Windows
• CPU Architecture: Any

[28 Nov 2007 22:56] Jess Balint

Description:
libmysql doesn't include support for all character sets. Alot of them are disabled in config-win.h. eg.

#define HAVE_CHARSET_cp1250 1
/* #undef HAVE_CHARSET_cp1251 */

How to repeat:
Call get_charset() on an unsupported character set will return null.

Suggested fix:
Change config-win.h (and possible other platforms) to include support for all character sets.

[4 Dec 2007 10:24] Valeriy Kravchuk

Thank you for a problem report. It looks like a reasonable feature request to me.

[3 Sep 2008 20:30] Jim Winstead

This is not just a feature request, it's a serious cross-platform compatibility problem that can impact the cross-platform compatbility of MySQL-using applications, and users of our ODBC driver.

[7 Jan 2009 18:34] Reggie Burnett

Jim manages libmysql now.  Setting him as lead.

[13 Jan 2009 15:19] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/63127

2737 Timothy Smith	2009-01-13
      Fix Bug#32831: libmysql should be built with all charsets
      
      Add #define HAVE_CHARSET_name in config-win.h for all character sets that MySQL
      supports.  Add comments to config/ac-macros/character_sets.m4 and config-win.h
      so hopefully they will be updated in sync.

[14 Jan 2009 1:04] Patrick Crews

Ok to push.  

Tested on Windows XP 32bit.

[20 Jan 2009 18:53] Bugs System

Pushed into 6.0.10-alpha (revid:[e-mail]-20090119171328-2hemf2ndc1dxl0et) (version source revid:[e-mail]-20090116170937-hvddomjy5hop3zg9) (merge vers: 6.0.10-alpha) (pib:6)

[29 Jan 2009 20:35] Paul DuBois

Noted in 6.0.10 changelog.

libmysqld was not built with all character sets.

Setting report to NDI pending push into 5.1.x.

[3 Feb 2009 9:40] Bugs System

Pushed into 5.1.32 (revid:[e-mail]-20090203090549-gos3v4320vimrzg6) (version source revid:[e-mail]-20090123182108-2efo5zwexcrf0h3o) (merge vers: 5.1.32) (pib:6)

[10 Feb 2009 21:19] Paul DuBois

Noted in 5.1.32 changelog.

[17 Feb 2009 14:54] Bugs System

Pushed into 5.1.32-ndb-6.3.23 (revid:[e-mail]-20090217131017-6u8qz1edkjfiobef) (version source revid:[e-mail]-20090203133556-9rclp06ol19bmzs4) (merge vers: 5.1.32-ndb-6.3.22) (pib:6)

[17 Feb 2009 16:41] Bugs System

Pushed into 5.1.32-ndb-6.4.3 (revid:[e-mail]-20090217134419-5ha6xg4dpedrbmau) (version source revid:[e-mail]-20090203133556-9rclp06ol19bmzs4) (merge vers: 5.1.32-ndb-6.3.22) (pib:6)

[17 Feb 2009 18:18] Bugs System

Pushed into 5.1.32-ndb-6.2.17 (revid:[e-mail]-20090217134216-5699eq74ws4oxa0j) (version source revid:[e-mail]-20090202111723-1zzwax187rtls913) (merge vers: 5.1.32-ndb-6.2.17) (pib:6)