| Bug #32052 | Small inconsistency with the big_test and ndb_extra test options | ||
|---|---|---|---|
| Submitted: | 2 Nov 2007 12:34 | Modified: | 30 Jan 2009 16:49 |
| Reporter: | Philip Stoev | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Tests | Severity: | S3 (Non-critical) |
| Version: | 5.0.45 | OS: | Any |
| Assigned to: | Magnus Blåudd | CPU Architecture: | Any |
| Tags: | 51rpl | ||
[5 Sep 2008 15:38]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/53374 2676 Magnus Svensson 2008-09-05 Bug#32052 Small inconsistency with the big_test and ndb_extra test options
[7 Sep 2008 1:04]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/53438 2688 He Zhenxing 2008-09-07 [merge] Auto merge
[30 Sep 2008 13:26]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/54774 2667 He Zhenxing 2008-09-29 [merge] Auto Merge
[30 Jan 2009 13:31]
Bugs System
Pushed into 6.0.10-alpha (revid:luis.soares@sun.com-20090129165607-wiskabxm948yx463) (version source revid:luis.soares@sun.com-20090129163120-e2ntks4wgpqde6zt) (merge vers: 6.0.10-alpha) (pib:6)
[30 Jan 2009 15:10]
Bugs System
Pushed into 5.1.32 (revid:luis.soares@sun.com-20090129165946-d6jnnfqfokuzr09y) (version source revid:hezx@mysql.com-20080929053642-b2mfvfhzisrzj274) (merge vers: 5.1.30) (pib:6)
[30 Jan 2009 16:49]
Paul DuBois
Test suite changes. No changelog entry needed.
[17 Feb 2009 14:59]
Bugs System
Pushed into 5.1.32-ndb-6.3.23 (revid:tomas.ulin@sun.com-20090217131017-6u8qz1edkjfiobef) (version source revid:tomas.ulin@sun.com-20090203133556-9rclp06ol19bmzs4) (merge vers: 5.1.32-ndb-6.3.22) (pib:6)
[17 Feb 2009 16:47]
Bugs System
Pushed into 5.1.32-ndb-6.4.3 (revid:tomas.ulin@sun.com-20090217134419-5ha6xg4dpedrbmau) (version source revid:tomas.ulin@sun.com-20090203133556-9rclp06ol19bmzs4) (merge vers: 5.1.32-ndb-6.3.22) (pib:6)
[17 Feb 2009 18:23]
Bugs System
Pushed into 5.1.32-ndb-6.2.17 (revid:tomas.ulin@sun.com-20090217134216-5699eq74ws4oxa0j) (version source revid:tomas.ulin@sun.com-20090201210519-vehobc4sy3g9s38e) (merge vers: 5.1.32-ndb-6.2.17) (pib:6)
Description: Hello, The help page for mysql-test-run says: big-test Set the environment variable BIG_TEST, which can be checked from test cases. which would imply that by setting the BIG_TEST option, those tests will be run, meaning that this construct: BIG_TEST=1 make test should cause them to execute. However, this is not the case because mysql-test-run decides to skip those tests only on the basis that the big-test option is not present on the command line of make-test-run. How to repeat: Try to run the big-test test suite using make only, without evoking mysql-test-run: BIG_TEST=1 make test Suggested fix: Even though mysql-test-run.pl converts the command-line option into an ENV variable, lib/mtr_cases.pl still checks the command-line option when deciding which tests to run. diff -ruN mysql-5.0.45-clean/mysql-test/lib/mtr_cases.pl mysql-5.0.45-mine/mysql-test/lib/mtr_cases.pl --- mysql-5.0.45-clean/mysql-test/lib/mtr_cases.pl 2007-07-04 16:49:09.000000000 +0300 +++ mysql-5.0.45-mine/mysql-test/lib/mtr_cases.pl 2007-11-02 14:29:04.000000000 +0200 @@ -516,14 +516,14 @@ if ( $::used_default_engine =~ /^innodb/i ); } - if ( $tinfo->{'big_test'} and ! $::opt_big_test ) + if ( $tinfo->{'big_test'} and ! $ENV{BIG_TEST} ) { $tinfo->{'skip'}= 1; $tinfo->{'comment'}= "Test need 'big-test' option"; return; } - if ( $tinfo->{'ndb_extra'} and ! $::opt_ndb_extra_test ) + if ( $tinfo->{'ndb_extra'} and ! $ENV{NDB_EXTRA_TEST} ) { $tinfo->{'skip'}= 1; $tinfo->{'comment'}= "Test need 'ndb_extra' option";