| Bug #31544 | funcs_1: <engine>_storedproc_08 broken, adjustment to 5.2 properties missing | ||
|---|---|---|---|
| Submitted: | 11 Oct 2007 20:01 | Modified: | 28 Nov 2007 21:38 |
| Reporter: | Matthias Leich | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Tests | Severity: | S3 (Non-critical) |
| Version: | 5.2 | OS: | Any |
| Assigned to: | Martin Hansson | CPU Architecture: | Any |
[16 Oct 2007 8:32]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/35620 ChangeSet@1.2611, 2007-10-16 10:36:16+02:00, mhansson@linux-st28.site +2 -0 Bug#31544: funcs_1: <engine>_storedproc_08 broken, adjustment to 5.2 properties missing - Changed columns where date is removed. - re-run of the test case shows only added columns in table 'routines'
[16 Oct 2007 8:54]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/35624 ChangeSet@1.2611, 2007-10-16 10:30:26+02:00, mhansson@linux-st28.site +2 -0 Bug#31544: funcs_1: <engine>_storedproc_08 broken, adjustment to 5.2 properties missing - Changed columns where date is removed. - re-run of the test case shows only added columns in table 'routines'
[19 Oct 2007 17:51]
Patrick Crews
Verified test will pass. Only differences are the addition of 7 new columns to table (marked in results file) and alteration of --replace clause in storedproc/.inc file (variable columns have moved position due to new columns being added). Everything looks good.
[19 Oct 2007 18:16]
Patrick Crews
Disregard previous passing review. Patch only affected memory_storedproc_08.result. test still fails for myisam, innodb, ndb. Need to patch these result files to correct bug.
[22 Oct 2007 7:12]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/36003 ChangeSet@1.2611, 2007-10-22 09:16:33+02:00, mhansson@linux-st28.site +5 -0 Bug#31544: funcs_1: <engine>_storedproc_08 broken, adjustment to 5.2 properties missing - Changed columns where date is removed. - re-run of the test cases shows as only difference added columns in table 'routines'. Same for each of memory, myisam, innodb, and ndb.
[22 Oct 2007 7:31]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/36005 ChangeSet@1.2611, 2007-10-22 09:11:53+02:00, mhansson@linux-st28.site +5 -0 Bug#31544: funcs_1: <engine>_storedproc_08 broken, adjustment to 5.2 properties missing - Changed columns where date is removed. - re-run of the test case shows as only difference added columns in table 'routines', for each of memory, myisam, innodb, ndb.
[22 Oct 2007 18:48]
Patrick Crews
Verified that test is corrected for all engines that have storedproc_08 (myisam, memory, ndb, innodb). Only changes made are to the results file (accounting for presence of new columns) and to the storedproc_08_show.inc file (altering columns to be --replace'd due to new columns -- 16 and 17 now 23 and 24). ok to push.
[29 Oct 2007 12:17]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/36547 ChangeSet@1.2664, 2007-10-29 16:12:38+04:00, gluh@mysql.com +5 -0 Bug#31544: funcs_1: <engine>_storedproc_08 broken, adjustment to 5.2 properties missing - Changed columns where date is removed. - re-run of the test case shows as only difference added columns in table 'routines', for each of memory, myisam, innodb, ndb.
[16 Nov 2007 9:34]
Bugs System
Pushed into 6.0.4-alpha
[28 Nov 2007 21:38]
Paul DuBois
Test case changes. No changelog entry needed.
Description: Please run for example ./mysql-test-run.pl --suite=funcs_1 \ --do-test=memory_storedproc_08 and see that this test fails. Just some example of the multiple times occuring differences ROUTINE_SCHEMA db_storedproc ROUTINE_NAME sp_1 ROUTINE_TYPE PROCEDURE +DATA_TYPE +CHARACTER_MAXIMUM_LENGTH NULL +CHARACTER_OCTET_LENGTH NULL +NUMERIC_PRECISION NULL +NUMERIC_SCALE NULL +CHARACTER_SET_NAME NULL +COLLATION_NAME NULL DTD_IDENTIFIER NULL ROUTINE_BODY SQL ROUTINE_DEFINITION BEGIN set @x=i1; END -EXTERNAL_NAME NULL -EXTERNAL_LANGUAGE NULL +EXTERNAL_NAME <modified> +EXTERNAL_LANGUAGE <created> PARAMETER_STYLE SQL IS_DETERMINISTIC NO SQL_DATA_ACCESS CONTAINS SQL SQL_PATH NULL SECURITY_TYPE INVOKER -CREATED <modified> -LAST_ALTERED <created> +CREATED 2007-10-11 22:44:06 +LAST_ALTERED 2007-10-11 22:44:06 SQL_MODE ROUTINE_COMMENT new comment, SP changed to INVOKER DEFINER root@localhost One reason why this test fails is the fact that the I_S table ROUTINES contains now more columns. MySQL compiled from source mysql-5.2-build last ChangeSet@1.2611, 2007-10-11 How to repeat: Please see above