MySQL Bugs: #31509: funcs_1: <engine>__datadict tests broken, adjustment to 5.2 properties missing

Bug #31509	funcs_1: <engine>__datadict tests broken, adjustment to 5.2 properties missing
Submitted:	10 Oct 2007 17:40	Modified:	28 Nov 2007 21:37
Reporter:	Matthias Leich	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Tests	Severity:	S3 (Non-critical)
Version:	5.1, 5.2	OS:	Any
Assigned to:	Sergei Glukhov	CPU Architecture:	Any

Description:
Please run
./mysql-test-run.pl --suite=funcs_1 myisam__datadict
within a MySQL 5.2 tree.
The test aborts because the I_S view parameters exists now.
Other issues are that several I_S tables have now a
slightly different definition compared to 5.1.

I will disable the <engine>__datadict tests within a
post merge fix for
Bug#31407 funcs_1: <engine>__datadict tests broken
          because of wrong expected results

How to repeat:
See above

Suggested fix:
1. WL#4057 Test INFORMATION_SCHEMA: PARAMETERS view
2. WL#4058 Test INFORMATION_SCHEMA.ROUTINES: Add missing columns
3. Solve the remaining problems

This should be added to https://inside.mysql.com/wiki/QATestPlanV50func once pushed.

* Section 3.2.18 - Checks on TRIGGERS:
** 3.2.18.1: Ensure that the INFORMATION_SCHEMA.TRIGGERS table has the following columns, in the following order: TRIGGER_CATALOG NULL, TRIGGER_SCHEMA, TRIGGER_NAME, EVENT_MANIPULATION, EVENT_OBJECT_CATALOG, EVENT_OBJECT_SCHEMA, EVENT_OBJECT_TABLE, ACTION_ORDER, ACTION_CONDITION, ACTION_STATEMENT, ACTION_ORIENTATION, ACTION_TIMING, ACTION_REFERENCE_OLD_TABLE, ACTION_REFERENCE_NEW_TABLE, ACTION_REFERENCE_OLD_ROW, ACTION_REFERENCE_NEW_ROW, CREATED, SQL_MODE

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/35583

ChangeSet@1.2610, 2007-10-15 18:28:45+02:00, mhansson@linux-st28.site +9 -0
  Bug#31509: funcs_1: <engine>__datadict tests broken, adjustment to 5.2
  properties missing
  
  - enabled datadict_show_table_design.inc for 'parameters' in
  datadict_master.inc and added columns to comment.
  - removed the test trap from datadict_tables.inc
  - added 'parameters' table to datadict_tables_error_[0-9]+.inc

There were substantial changes to the result file.
I have listed changes the first time they appear.

- help tables have been removed from select over 'tables' table (l 1099 & 1165-)
- there's one more table in information_schema (l 1180 - 2297)
- extra column storage_format in table 'columns' (2297 - 3212)
- 'statistics' has new column INDEX_COMMENT (line 2550)
- there are 11452 collations (line 3252)
- table 'routines' has different set of columns. (line 3258)
- table 'statistics' has different set of columns. (line 3266 - 3311)
- view definitions are not truncated (line 3313 - 3324)
- new content in 'key_column_usage' (3495, 3496 and below)
- table 'columns' has more columns (3647)
- table 'routines' has more columns
- table 'statistics' has more columns
- After 'root: check with db name' there are some tables that have more rows
- A query has changed to exclude 'help_%' tables (5825-)
- DISTINCT sorts differently (5905-)
- 'views' has default value NULL for VIEW_DEFINITION
- 'triggers' has default value NULL for columns ACTION_STATEMENT, SQL_MODE and 
  DEFINER (line 15530-)

'routines' table has more columns and it was needed to remove date-specific
 data in columns 23 & 24 rather than 16 & 17

The test case has been found to fail in 5.1 as well

The patch for 5.1 follows below

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/35743

ChangeSet@1.2587, 2007-10-17 13:05:34+02:00, mhansson@linux-st28.site +1 -0
  Bug#31509: funcs_1: <engine>__datadict tests broken, adjustment to 5.2
    properties missing
  
  - Re-recorded test case with changes annotated.

ok to push

myisam_datadicts looks good, but the other engines' results files have not been changed.

Need to alter all of the results files for this test to have it 100%.

revision to last comment: 
All engines except NDB need to be fixed (NDB will not work due to Bug#31421)

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/36012

ChangeSet@1.2587, 2007-10-22 11:34:24+02:00, mhansson@linux-st28.site +3 -0
  Bug#31509: funcs_1: <engine>__datadict tests broken, adjustment to 5.2
    properties missing
  
  - Re-recorded test cases with changes annotated: MyISAM, Memory, and InnoDB
  - NDB is updated in bug 31421 and 31411

ok to push.  myisam, memory, and innodb have been updated.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/36553

ChangeSet@1.2615, 2007-10-29 16:45:35+04:00, gluh@mysql.com +3 -0
  Bug#31509: funcs_1: <engine>__datadict tests broken, adjustment to 5.2 properties missing
  
  - Re-recorded test cases with changes annotated: MyISAM, Memory, and InnoDB
  - NDB is updated in bug 31421 and 31411

I reviewed a tar archive of the funcs_1 tests
with changes to the <engine>__datadict and all is ok.
Note:
  This fix does not prevent that ndb__datadict
  fails because of
  Bug31421 funcs_1: ndb__datadict fails, discrepancy 
           between scripts and expected results

Reviewed two latest patches for 5.1 and 6.0  both work as advertised with the exception of NDB as noted by Matthias.

Pushed into 6.0.4-alpha

Test case changes. No changelog entry needed.

However, I did notice that some of these new INFORMATION_SCHEMA table columns were undocumented, so I documented them in the I_S chapter.