Bug #29675 collation_connection is defined twice for the same value.
Submitted: 10 Jul 2007 5:09 Modified: 30 Nov 2007 1:30
Reporter: Sadao Hiratsuka (Basic Quality Contributor) Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Charsets Severity:S3 (Non-critical)
Version:5.0.46-BK, 5.0.42 OS:Any
Assigned to: Alexander Barkov CPU Architecture:Any
Tags: collation_connection, qc

[10 Jul 2007 5:09] Sadao Hiratsuka
Description:
collation_connection is defined twice for the same value.

How to repeat:
static int init_common_variables(const char *conf_file_name, int argc,
				 char **argv, const char **groups)
{
...
  /* Set collactions that depends on the default collation */
  global_system_variables.collation_server=	 default_charset_info;
  global_system_variables.collation_database=	 default_charset_info;
  global_system_variables.collation_connection=  default_charset_info; *HERE*
  global_system_variables.character_set_results= default_charset_info;
  global_system_variables.character_set_client= default_charset_info;
  global_system_variables.collation_connection= default_charset_info; *HERE*

Suggested fix:
please delete one of them.
[10 Jul 2007 5:15] Sadao Hiratsuka
source: sql/mysqld.cc
[10 Jul 2007 9:08] Valeriy Kravchuk
Thank you for a bug report. Verified just as described by code review with latest 5.0.46-BK sources. See lines 2849 and 2852 in sql/mysqld.cc.
[2 Oct 2007 10:24] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/34749

ChangeSet@1.2535, 2007-10-02 15:20:45+05:00, bar@mysql.com +1 -0
  Bug#29675 collation_connection is defined twice for the same value
  Removing redundant initialization.
[2 Oct 2007 10:37] Alexey Botchkov
ok to push
[2 Oct 2007 10:48] Alexander Barkov
No second review needed.

Pushed into 5.0.50-rpl and 5.1.23-rpl
[27 Nov 2007 10:49] Bugs System
Pushed into 5.0.54
[27 Nov 2007 10:50] Bugs System
Pushed into 5.1.23-rc
[27 Nov 2007 10:52] Bugs System
Pushed into 6.0.4-alpha
[30 Nov 2007 1:30] Paul DuBois
No user-visible effect. No changelog entry needed.