MySQL Bugs: #29046: rpl_stm_mystery22 unstable

Bug #29046	rpl_stm_mystery22 unstable
Submitted:	12 Jun 2007 8:06	Modified:	27 Nov 2007 18:49
Reporter:	Magnus Blåudd	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Tests	Severity:	S7 (Test Cases)
Version:	5.1.20	OS:	Any
Assigned to:	Sven Sandberg	CPU Architecture:	Any

Description:
rpl_stm_mystery22 is unstable since it has a "wait_for_slave_to_stop" call - this should be changed to "wait until expected error" 

diff -Nrup a/mysql-test/t/rpl_stm_mystery22.test b/mysql-test/t/rpl_stm_mystery22.test
> --- a/mysql-test/t/rpl_stm_mystery22.test	2006-08-30 09:22:41 +02:00
> +++ b/mysql-test/t/rpl_stm_mystery22.test	2007-06-12 04:28:36 +02:00
> @@ -28,7 +28,7 @@ insert into t1 values(NULL,'new');
>  save_master_pos;
>  connection slave;
>  # wait until the slave tries to run the query, fails and aborts slave thread
> -wait_for_slave_to_stop;
> +--source include/wait_for_slave_error.inc
>  select * from t1 order by n;
>  delete from t1 where n = 2;
>  --disable_warnings
> 

How to repeat:
rpl_stm_mystery22

Suggested fix:
Replace the wait_for_slave_to_stop

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/35203

ChangeSet@1.2571, 2007-10-09 17:17:55+02:00, sven@murkla.(none) +2 -0
  BUG#29046: rpl_stm_mystery22 unstable
  
  Problem: rpl_stm_mystery22 is unstable.
  
  Reason: At one place, the test case *should* wait until the SQL thread on the
  slave receives an error, but instead it waits until the SQL thread stops. The
  SQL thread may stop before the error flag is set, so that when the test case
  continues to execute, the error flag is not set.
  
  Fix: Introduce the subroutine mysql-test/include/wait_for_slave_sql_error.inc,
  which waits until there is an error in the sql thread of the slave.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/35296

ChangeSet@1.2571, 2007-10-10 18:10:54+02:00, sven@murkla.(none) +2 -0
  BUG#29046: rpl_stm_mystery22 unstable
  
  Problem: rpl_stm_mystery22 is unstable.
  
  Reason: At one place, the test case *should* wait until the SQL thread on the
  slave receives an error, but instead it waits until the SQL thread stops. The
  SQL thread may stop before the error flag is set, so that when the test case
  continues to execute, the error flag is not set.
  
  Fix: Introduce the subroutine mysql-test/include/wait_for_slave_sql_error.inc,
  which waits until there is an error in the sql thread of the slave.
  
  Re-commit: fixed one logical error and two smaller things noted by Mats.

Pushed into 5.1.23-rc

Pushed into 6.0.4-alpha

Test case change. No changelog entry needed.