Bug #2857 Bug in scripts/make_binary_distribution

• Submitted: 18 Feb 2004 2:39
• Modified: 13 May 2004 20:35
• Reporter: Boyd GERBER
• Status: Closed
• Category: MySQL Server: Packaging
• Severity: S2 (Serious)
• Version: MySQL-4.0.18
• OS: OpenServer 5.0.7
• Assigned to: Lenz Grimmer
• CPU Architecture: Any

[18 Feb 2004 2:39] Boyd GERBER

Description:
The script make_binary_distribution fails with this message and creates 0 lenght files

$ scripts/make_binary_distribution
cp: use -r or -R option to copy directory support-files/MacOSX
scripts/make_binary_distribution: /tmp/my_dist/bin/replace: cannot execute
scripts/make_binary_distribution: /tmp/my_dist/bin/replace: cannot execute
scripts/make_binary_distribution: /tmp/my_dist/bin/replace: cannot execute

How to repeat:
Run

scripts/make_binary_distribution

[18 Feb 2004 3:04] Boyd GERBER

Using set -x This is where it failes.

+ /tmp/my_dist/bin/replace @localstatedir@ ./data @bindir@ ./bin @scriptdir@ ./b
in @libexecdir@ ./bin @sbindir@ ./bin @prefix@ . @HOSTNAME@ /usr/bin/hostname
scripts/make_binary_distribution: /tmp/my_dist/bin/replace: cannot execute
+ /tmp/my_dist/bin/replace @prefix@ /usr/local/mysql @bindir@ ./bin @MYSQLD_USER
@ root @localstatedir@ /usr/local/mysql/data @HOSTNAME@ /usr/bin/hostname
scripts/make_binary_distribution: /tmp/my_dist/bin/replace: cannot execute
+ /tmp/my_dist/bin/replace /my/gnu/bin/hostname /bin/hostname -- /tmp/my_dist/bi
n/mysqld_safe
scripts/make_binary_distribution: /tmp/my_dist/bin/replace: cannot execute

[18 Feb 2004 4:54] Boyd GERBER

Here is the patch to make_binary_distribution.sh for OpenServer 5.0.7 if you want it only for OpenServer then some thing like the patch for mysql_test_db is needed.

*** make_binary_distribution.sh.org Tue Feb 10 11:15:56 2004
--- make_binary_distribution.sh Wed Feb 18 05:51:04 2004
***************
*** 221,226 ****
  $CP mysql-test/r/*result mysql-test/r/*.require $BASE/mysql-test/r

  if [ $BASE_SYSTEM != "netware" ] ; then
    $CP scripts/* $BASE/bin
    $BASE/bin/replace \@localstatedir\@ ./data \@bindir\@ ./bin \@scriptdir\@ ./
bin \@libexecdir\@ ./bin \@sbindir\@ ./bin \@prefix\@ . \@HOSTNAME\@ @HOSTNAME@
< $SOURCE/scripts/mysql_install_db.sh > $BASE/scripts/mysql_install_db
    $BASE/bin/replace \@prefix\@ /usr/local/mysql \@bindir\@ ./bin \@MYSQLD_USER
\@ root \@localstatedir\@ /usr/local/mysql/data \@HOSTNAME\@ @HOSTNAME@ < $SOURC
E/support-files/mysql.server.sh > $BASE/support-files/mysql.server
--- 221,227 ----
  $CP mysql-test/r/*result mysql-test/r/*.require $BASE/mysql-test/r

  if [ $BASE_SYSTEM != "netware" ] ; then
+   chmod a+x $BASE/bin/*
    $CP scripts/* $BASE/bin
    $BASE/bin/replace \@localstatedir\@ ./data \@bindir\@ ./bin \@scriptdir\@ ./
bin \@libexecdir\@ ./bin \@sbindir\@ ./bin \@prefix\@ . \@HOSTNAME\@ @HOSTNAME@
< $SOURCE/scripts/mysql_install_db.sh > $BASE/scripts/mysql_install_db
    $BASE/bin/replace \@prefix\@ /usr/local/mysql \@bindir\@ ./bin \@MYSQLD_USER
\@ root \@localstatedir\@ /usr/local/mysql/data \@HOSTNAME\@ @HOSTNAME@ < $SOURC
E/support-files/mysql.server.sh > $BASE/support-files/mysql.server

[25 Mar 2004 17:07] Boyd GERBER

I just verified that this is still a problem with the lastest bk(date March 25 2004 at 1800 MST) from 4.0 and 4.1.

[25 Mar 2004 17:15] MySQL Verification Team

Thank you Boyd for to point up us.

[13 May 2004 20:35] Lenz Grimmer

Thanks for pointing this out and sorry for the delay - this is now
fixed in the 4.0 tree and will be resolved for 4.0.20 and beyond.

ChangeSet@1.1821.1.1, 2004-05-13 18:50:09+02:00, [e-mail]
   - make sure the binaries are executable before calling them during
     make_binary_distribution (bug#2857)