Bug #28298 Node Id larger than MAX_NDB_NODES in config file doesn't generate error

Description:
Write a config file with a NDB Node id set to 50 and
start the management server. No error is discovered.
Instead the ndb fails in the start-up since 50 is an
illegal NDB Node id.

How to repeat:
Write a config file with a NDB Node id set to 50 and
start the management server. No error is discovered.
Instead the ndb fails in the start-up since 50 is an
illegal NDB Node id.

Suggested fix:
Check NDB Node Id's
Also check other node id's, quite likely the bug exists in other places as well.

Documented previously unknown limitation in Manual:

http://lists.mysql.com/commits/27843

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/31529

ChangeSet@1.2512, 2007-07-25 15:29:12+08:00, gni@dev3-221.dev.cn.tlan +1 -0
  BUG#28298 Node Id larger than MAX_NDB_NODES in config file doesn't generate error

The STR_VALUE macro should be doing this properly... 

i.e. like:

$ cat /tmp/a.c 
#define _STR_VALUE(x) #x
#define STR_VALUE(x) _STR_VALUE(x)
#define FOO 100
STR_VALUE(FOO)
stewart@willster:~/Documents/MySQL/5.0/ndb-work$ cpp /tmp/a.c 
# 1 "/tmp/a.c"
# 1 "<built-in>"
# 1 "<command line>"
# 1 "/tmp/a.c"

"100"

so why is this not working?

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/32683

ChangeSet@1.2512, 2007-08-17 13:37:27+08:00, gni@dev3-221.dev.cn.tlan +1 -0
  BUG#28298 Node Id larger than MAX_NDB_NODES in config file doesn't generate error

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/34623

ChangeSet@1.2512, 2007-09-28 09:49:16+08:00, gni@dev3-221.dev.cn.tlan +2 -0
  BUG#28298 Node Id larger than MAX_NDB_NODES in config file doesn't generate error

pushed into mysql-5.0-ndb-bj and mysql-5.1-new-ndb-bj

Documented bugfix in 5.1.23-ndb-6.3.8 changelog as follows:

        It was possible in config.ini to define
        cluster nodes having node IDs greater than the maximum allowed
        value.

Left bug in PQ status pending further merges.

Also documented for 5.1.23-ndb-6.2.11; left status unchanged.

Pushed into 5.0.58

Pushed into 5.1.24-rc

Pushed into 6.0.5-alpha

Also documented for 5.0.58, 5.1.24, and 6.0.5.