Bug #27739 build fails on Tru64 due to icheck test in configure
Submitted: 10 Apr 2007 21:49 Modified: 27 Apr 2007 15:17
Reporter: Peter O'Gorman Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Compiling Severity:S3 (Non-critical)
Version:5.0.38 OS:Other (Tru64 5.1osf1)
Assigned to: Joerg Bruehe CPU Architecture:Any
Tags: Contribution

[10 Apr 2007 21:49] Peter O'Gorman
Description:
configure tests for icheck from debian to test abi changes, icheck on Tru64 lives in /usr/sbin/icheck and is found by the configure test. Problem is that icheck on Tru64 is a "File system storage consistency check". So the build fails when this icheck is given options it does not understand.

How to repeat:
Build mysql-5.0/38 on Tru64

Suggested fix:
This patch to configure.in

@@ -459,6 +428,18 @@

 # icheck, used for ABI check
 AC_PATH_PROG(ICHECK, icheck, no)
+if test "x$ICHECK" != "xno"; then
+AC_MSG_CHECKING(if $ICHECK works as expected)
+echo "int foo;" > conftest.h
+$ICHECK --canonify -o conftest.ic conftest.h 2>/dev/null
+if ! test -f "conftest.ic" ;then
+AC_MSG_RESULT(no)
+ICHECK=no
+else
+AC_MSG_RESULT(yes)
+fi
+rm -f conftest.ic conftest.h
+fi
 AC_SUBST(ICHECK)

 # Lock for PS
[12 Apr 2007 5:59] Valeriy Kravchuk
Thank you for a bug report and patch.
[20 Apr 2007 8:36] Joerg Bruehe
I tried the proposed patch on both Debian (with "icheck" installed) and SuSE (without): Patch works, no negative consequences.

I do not have access to a machine where "icheck" is a file system checker (like Tru64), all our build hosts tah have any "icheck" have it as the ABI checker.
So I must leave that verification to the bug reporter (or some other user).
However, I trust that the reporter did this before proposing the patch.

I will soon commit it internally to get it reviewed.
[20 Apr 2007 8:52] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/24978

ChangeSet@1.2459, 2007-04-20 10:51:53+02:00, joerg@debian.(none) +1 -0
  configure.in  :  Ensure that "icheck" is really the ABI checker,
                   not some other tool (file system checker on Tru64).
  
  Patch originally supplied by Peter O'Gorman, slightly modified by me.
  
  Bug#27739 "build fails on Tru64 due to icheck test in configure"
[20 Apr 2007 10:50] Joerg Bruehe
Pushed to the internal testing trees,
hopefully to be merged to the main trees next week.
[27 Apr 2007 9:21] Bugs System
Pushed into 5.1.18-beta
[27 Apr 2007 9:23] Bugs System
Pushed into 5.0.42
[27 Apr 2007 15:17] Paul DuBois
No changelog entry needed.
[8 Aug 2009 0:45] Andrey Ponomarenko
Use ABI-compliance-checker instead of icheck because it provides more convenient output
http://ispras.linux-foundation.org/index.php/ABI_compliance_checker
[10 Aug 2009 17:22] Joerg Bruehe
The ABI check is handled in a different way for some time already,
see the top level "Makefile.am" in version 5.1.