Bug #26971 BUILD/check-cpu does not recognize Intel Core 2 Duo T7400
Submitted: 8 Mar 2007 20:55 Modified: 10 Apr 2007 16:20
Reporter: Guilhem Bichot Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Compiling Severity:S3 (Non-critical)
Version:5.0, 5.1 OS:Linux (linux)
Assigned to: Guilhem Bichot CPU Architecture:Any

[8 Mar 2007 20:55] Guilhem Bichot 
Description:
Running BUILD/compile-pentium-valgrind-max on such CPU under Linux 32 bit gives:
BUILD/check-cpu: Oops, could not find out what kind of cpu this machine is using

Such CPU should be handled like we handle Xeon: say it's a pentium4 except if the "lm" flag is listed in /proc/cpuinfo then it's nocona.

My /proc/cpuinfo is:
processor       : 0
vendor_id       : GenuineIntel
cpu family      : 6
model           : 15
model name      : Intel(R) Core(TM)2 CPU         T7400  @ 2.16GHz
stepping        : 6
cpu MHz         : 1000.000
cache size      : 4096 KB
physical id     : 0
siblings        : 2
core id         : 0
cpu cores       : 2
fdiv_bug        : no
hlt_bug         : no
f00f_bug        : no
coma_bug        : no
fpu             : yes
fpu_exception   : yes
cpuid level     : 10
wp              : yes
flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe nx lm constant_tsc pni monitor ds_cpl vmx est tm2 cx16 xtpr lahf_lm
bogomips        : 4331.83

How to repeat:
run BUILD/check-cpu on such CPU.

Suggested fix:
will fix
[8 Mar 2007 21:01] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/21541

ChangeSet@1.2470, 2007-03-08 21:59:28+01:00, guilhem@gbichot4.local +1 -0
  Fix for BUG#26971 "BUILD/check-cpu does not recognize Intel Core 2
  Duo T7400". Treat such CPU as Xeon. Here's /proc/cpuinfo for T7400:
  model name      : Intel(R) Core(TM)2 CPU         T7400  @ 2.16GHz
[9 Mar 2007 15:19] Guilhem Bichot 
queued in 5.1-maint.
Nothing to document: it's a fix for the BUILD/ scripts, without the fix the building works, it's just about adding an "optimize for this CPU" flag to the gcc command line.
[9 Mar 2007 17:29] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/21603

ChangeSet@1.2475, 2007-03-09 14:39:24+01:00, guilhem@gbichot4.local +1 -0
  Fix for BUG#26971 "BUILD/check-cpu does not recognize Intel Core 2
  Duo T7400". Treat such CPU as Xeon. Here's /proc/cpuinfo for T7400:
  model name      : Intel(R) Core(TM)2 CPU         T7400  @ 2.16GHz
[13 Mar 2007 15:08] Tatiana Azundris Nuernberg 
FWIW, there'll be a core2 switch in gcc 4.3, might be worth passing that once that version is assumed "widely used"
[22 Mar 2007 20:19] Mads Martin Joergensen 
Fixed in 5.1.17
[22 Mar 2007 20:52] Paul DuBois 
No changelog entry needed.
[22 Mar 2007 22:46] Paul DuBois 
Queued for 5.0.x.
[10 Apr 2007 16:20] Timothy Smith 
Developer fixed in 5.1 only.  Closing.