MySQL Bugs: #25074: mysql_upgrade test can't give consistent results

Bug #25074	mysql_upgrade test can't give consistent results
Submitted:	14 Dec 2006 14:58	Modified:	13 Mar 2007 1:46
Reporter:	Patrick Galbraith	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Tests	Severity:	S7 (Test Cases)
Version:	Ver 5.1.15-beta-debug-log for apple-darw, 5.0	OS:
Assigned to:	Magnus Blåudd	CPU Architecture:	Any
Tags:	2006-12-12 19:39:45-05:00, ChangeSet@1.2352, patg@radha.local +2 -0

Description:
mysql_upgrade test gives different results on different platforms. On my development server, I get a failure of this test because for some reason, mysql_upgrade is using the wrong database and picking up other databases (test) and tables on my server. I don't know why it's not using the tables in mysql-test/var/master-data (?). It also fails on the pushbuild server. 
So, I can't even fix it by recording new results, because depending on server, those will change.

TEST                           RESULT         TIME (ms)
-------------------------------------------------------

mysql_upgrade                  [ fail ]

Errors are (from /Users/patg/mysql-build/mysql-5.1-arch-clean/mysql-test/var/log/mysqltest-time) :
mysqltest: Result length mismatch
(the last lines may be the most important ones)
Below are the diffs between actual and expected results:
-------------------------------------------------------
*** r/mysql_upgrade.result      Thu Dec 14 17:34:20 2006
--- r/mysql_upgrade.reject      Thu Dec 14 17:34:25 2006
***************
*** 1,3 ****
--- 1,225 ----
  Run mysql_upgrade once
+ cluster.binlog_index                               OK
+ federated.t1                                       OK

+ mysql.columns_priv                                 OK
+ mysql.db                                           OK
+ mysql.event                                        OK
+ mysql.func                                         OK
+ mysql.general_log                                  OK
+ mysql.help_category                                OK
+ mysql.help_keyword                                 OK
+ mysql.help_relation                                OK
+ mysql.help_topic                                   OK
+ mysql.host                                         OK
+ mysql.ndb_binlog_index                             OK
+ mysql.plugin                                       OK
+ mysql.proc                                         OK
+ mysql.procs_priv                                   OK
+ mysql.servers                                      OK
+ mysql.slow_log                                     OK
+ mysql.tables_priv                                  OK
+ mysql.time_zone                                    OK
+ mysql.time_zone_leap_second                        OK
+ mysql.time_zone_name                               OK
+ mysql.time_zone_transition                         OK
+ mysql.time_zone_transition_type                    OK
+ mysql.user                                         OK
+ test.foo                                           OK
+ test.testaa                                        OK
+ test.testab                                        OK
+ test.testac                                        OK
+ test.testad                                        OK
+ test.testae                                        OK
+ test.testaf                                        OK
+ test.testag                                        OK
+ test.testah                                        OK
+ test.testai                                        OK
+ test.testaj                                        OK
+ test.testak                                        OK
+ test.testal                                        OK
+ test.testam                                        OK
+ test.testan                                        OK
+ @hadGrantPriv:=1
+ 1
+ 1
+ 1
+ 1
+ 1
+ @hadShowDbPriv:=1
+ 1
+ 1
+ 1
+ 1
+ 1
+ @hadCreateViewPriv:=1
+ 1
+ 1
+ 1
+ 1
+ 1
+ @hadCreateRoutinePriv:=1
+ 1
+ 1
+ 1
+ 1
+ 1
+ @hadCreateUserPriv:=1
+ 1
+ 1
+ 1
+ 1
+ 1
+ @hadEventPriv :=1
+ 1
+ 1
+ 1
+ 1
+ 1
+ @hadTriggerPriv :=1
+ 1
+ 1
+ 1
+ 1
+ 1
-------------------------------------------------------
Please follow the instructions outlined at
http://www.mysql.com/doc/en/Reporting_mysqltest_bugs.html
to find the reason to this problem and how to report this.

Result from queries before failure can be found in /Users/patg/mysql-build/mysql-5.1-arch-clean/mysql-test/var/log/mysql_upgrade.log

Aborting: mysql_upgrade failed in default mode. To continue, re-run with '--force'.
Stopping All Servers

How to repeat:
Run mysql_upgrade with './mysql-test-run.pl mysql_upgrade', or via 'make test'

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/16958

ChangeSet@1.2353, 2006-12-14 10:07:17-05:00, patg@radha.patg.net +1 -0
  BUG #25074
  
  mysql_upgrade test gives inconsitent results

Version 5.0 is affected too.

There is duplicate bug #25618

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/20799

ChangeSet@1.2434, 2007-02-28 18:43:18+01:00, msvensson@pilot.blaudden +1 -0
  Bug #25074 mysql_upgrade test can't give consistent results
   - Tell the programs executed by mysql_upgrade to only read
    from the defaults file generated by msyql_upgrade

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/20806

ChangeSet@1.2452, 2007-02-28 19:33:39+01:00, msvensson@pilot.blaudden +2 -0
  Bug #25074 mysql_upgrade test can't give consistent results
   - Remove disabling and record result file

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/20807

ChangeSet@1.2435, 2007-02-28 19:36:26+01:00, msvensson@pilot.blaudden +1 -0
  Bug#25074 mysql_upgrade test can't give consistent results
   - Free memory allocated by 'load_default'

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/20810

ChangeSet@1.2435, 2007-02-28 19:58:17+01:00, msvensson@pilot.blaudden +1 -0
  Bug#25074 mysql_upgrade test can't give consistent results
   - Free memory allocated by 'load_default'

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/20819

ChangeSet@1.2434, 2007-02-28 21:05:39+01:00, msvensson@pilot.blaudden +1 -0
  Bug #25074 mysql_upgrade test can't give consistent results
   - Tell the programs executed by mysql_upgrade to only read
    from the defaults file generated by msyql_upgrade
   - Fix memory leaks

pushed to 5.0.38, 5.1.17

mysql_upgrade could get confused when reading options files and passing options on to programs it calls.

Now it is more strict about how it handles options.

Not really user-visible, although I suppose someone with an odd options-file setup *could* have seen some problems before.

No changelog entry needed.