Bug #22579 use --warning-mode=pedantic and -std=c89 flags when compiling with gcc
Submitted: 22 Sep 2006 3:41 Modified: 15 Feb 2007 4:38
Reporter: Timothy Smith Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Compiling Severity:S4 (Feature request)
Version:5.0+ OS:Any (any)
Assigned to: Magnus Blåudd CPU Architecture:Any

[22 Sep 2006 3:41] Timothy Smith 
Description:
MySQL fails to compile with --warning-mode=pedantic.

The code should be cleaned up so that it compiles with --warning-mode=pedantic, and with -std=c89.  This will allow us to catch errors which will appear on platforms which don't support C99.

How to repeat:
n/a

Suggested fix:
Once the code is cleaned up, the BUILD tools should use this by default, and PushBuild should also use this on all GCC builds.
[29 Sep 2006 12:52] Magnus Blåudd 
Talked to Knielsen about this one. Pushbuild is running 5.1 with BUILD/compile-pentium-debug-max --warning-mode=pedantic 

But BUILD/* in 5.0 apparently does not support that switch, yet.

Backport BUILD/* scripts
[16 Oct 2006 12:07] Magnus Blåudd 
We will add a build host in PushBuild that uses these flags. Eventually we might put it in "make dist".
[29 Jan 2007 18:37] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/18977

ChangeSet@1.2434, 2007-01-29 19:36:48+01:00, msvensson@neptunus.(none) +2 -0
  Bug#22579 use --warning-mode=pedantic and -std=c89 flags when compiling with gcc
   - Reorganize include file order to avoid problem with gcc 2.95.3
   - Compiler is confused by forward class declarations
[14 Feb 2007 15:13] Chad MILLER 
Available in 5.1.16-beta.
[15 Feb 2007 4:38] Paul DuBois 
No changelog entry needed.