Bug #22285 Community: SHOW PROFILE (thd->proc_info)
Submitted: 12 Sep 2006 21:49 Modified: 9 Nov 2006 21:22
Reporter: Marc ALFF Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server Severity:S4 (Feature request)
Version:5.2 OS:
Assigned to: Marc ALFF CPU Architecture:Any

[12 Sep 2006 21:49] Marc ALFF 
Description:
This feature request is to implement the patch contributed by Jeremy Cole,
as a preliminary cleanup for SHOW PROFILE.

See the full thread :
http://lists.mysql.com/internals/33768

and in particular :
http://lists.mysql.com/internals/33869

How to repeat:

N/A

Suggested fix:

Per patch
[12 Sep 2006 22:04] Marc ALFF 
The issue found is a code cleanup issue.

Reproduced and Verified by code review (Marc Alff, Konstantin Osipov).
[4 Oct 2006 20:31] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/13092

ChangeSet@1.2333, 2006-10-04 14:31:24-07:00, malff@weblab.(none) +20 -0
  Bug#22285 (Community: SHOW PROFILE (thd->proc_info)
  
  This is a minor code cleanup change, no functionality is affected.
  
  Modifications to thd->proc_info have been revised to use THD_SET_PROC_INFO
  instead, which provide an extra trace in debug mode.
  
  Note that thd->proc_info is a public member, used by some storage engines.
  The storage engine code has not been changed, as this access to THD data
  needs to be revised for a different reason (engines plug-in).
  
  In non debug builds, THD_SET_PROC_INFO expands to the original code.
[1 Nov 2006 9:10] Konstantin Osipov 
The patch is approved. While reviewing, I assumed that it does what is required for SHOW PROFILE and only was making sure nothing is broken by the patch.
[2 Nov 2006 17:18] Marc ALFF 
Pushed to mysql-5.2
[9 Nov 2006 21:22] Konstantin Osipov 
No documentation entry is needed, the patch is in 5.2 main tree.
[2 Jan 2007 19:27] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/17539

ChangeSet@1.2326, 2007-01-02 14:26:42-05:00, cmiller@zippy.cornsilk.net +17 -0
  Bug#22285: Community: SHOW PROFILE (thd->proc_info)
  
  BACKPORTED from 5.2 Enterprise.
  
  This is a minor code cleanup change, no functionality is affected.
  
  Modifications to thd->proc_info have been revised to use THD_SET_PROC_INFO
  instead, which provide an extra trace in debug mode.
  
  Note that thd->proc_info is a public member, used by some storage engines.
  The storage engine code has not been changed, as this access to THD data
  needs to be revised for a different reason (engines plug-in).
  
  In non debug builds, THD_SET_PROC_INFO expands to the original code.