Bug #20439 mysqltest: remove unused options
Submitted: 13 Jun 2006 20:55 Modified: 3 Aug 2006 14:21
Reporter: Paul Dubois Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Tests Severity:S3 (Non-critical)
Version:5.1 and up OS:
Assigned to: Magnus Blåudd CPU Architecture:Any

[13 Jun 2006 20:55] Paul Dubois
Description:
The "mysqltestmanager" options have been removed
from mysql-test-run in MySQL 5.1.

The manager-related options probably could be removed
from the 5.1 mysqltest.c as well:

  {"manager-host", OPT_MANAGER_HOST, "Undocumented: Used for debugging.",
   (gptr*) &manager_host, (gptr*) &manager_host, 0, GET_STR, REQUIRED_ARG,
   0, 0, 0, 0, 0, 0},
  {"manager-password", OPT_MANAGER_PASSWD, "Undocumented: Used for debugging.",
   0, 0, 0, GET_STR, REQUIRED_ARG, 0, 0, 0, 0, 0, 0},
  {"manager-port", OPT_MANAGER_PORT, "Undocumented: Used for debugging.",
   (gptr*) &manager_port, (gptr*) &manager_port, 0, GET_INT, REQUIRED_ARG,
   MYSQL_MANAGER_PORT, 0, 0, 0, 0, 0},
  {"manager-user", OPT_MANAGER_USER, "Undocumented: Used for debugging.",
   (gptr*) &manager_user, (gptr*) &manager_user, 0, GET_STR, REQUIRED_ARG, 0,
   0, 0, 0, 0, 0},
  {"manager-wait-timeout", OPT_MANAGER_WAIT_TIMEOUT,
   "Undocumented: Used for debugging.", (gptr*) &manager_wait_timeout,
   (gptr*) &manager_wait_timeout, 0, GET_INT, REQUIRED_ARG, 3, 0, 0, 0, 0, 0},

None of these options appears to be used at all anywhere under the mysql-test
directory in the 5.1 tree.

How to repeat:
Nothing to repeat.
[14 Jun 2006 11:00] Valeriy Kravchuk
Thank you for a problem report. Verified just as described with today's 5.1-BK.
[21 Jul 2006 20:41] Magnus Blåudd
Patch is in mysql-5.1-new-maint
[31 Jul 2006 9:06] Magnus Blåudd
It's not in mysql-5.1-new-maint, found the patch still in clone for bug#19535

Here is a link to the patch http://lists.mysql.com/commits/9326
[1 Aug 2006 7:36] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/9876

ChangeSet@1.2245, 2006-08-01 09:36:27+02:00, msvensson@neptunus.(none) +1 -0
  Bug#20439 mysqltest: remove unused options
   -Remove leftovers of server_stop and server_start commands
[3 Aug 2006 8:56] Magnus Blåudd
Pushed to 5.1.12
[3 Aug 2006 14:21] Paul Dubois
I've updated the mysqltest manual to remove the descriptions
of server_start and server_stop.
[3 Aug 2006 14:38] Paul Dubois
Also removed the require_manager command and the
--manager-xxx options from the mysqltest manual.