MySQL Bugs: #20013: No pentium_cflags in SETUP.sh ?

Bug #20013	No pentium_cflags in SETUP.sh ?
Submitted:	22 May 2006 22:59	Modified:	8 Mar 2007 21:37
Reporter:	jocelyn fournier (Silver Quality Contributor)	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Compiling	Severity:	S5 (Performance)
Version:	5.1.12-BK, 5.1.11-snapshot	OS:	Linux (Linux)
Assigned to:	Daniel Fischer	CPU Architecture:	Any
Tags:	qc

Description:
Hi,

I've just noticed, although cpu-check was properly running, than ./BUILD/compile-pentium wasn't not adding the "-mtune=xxx -march=xxx" flags during the compilation with gcc 3.4.4.
I figured out it's because compile-pentium is using $pentium_cflags, but there is no

pentium_cflags="$check_cpu_cflags" in the ./BUILD/SETUP.sh file.

Is this expected ?

Thanks,
  Jocelyn

How to repeat:
Build from source with compile-pentium script.

Suggested fix:
Add pentium_cflags="$check_cpu_cflags" in ./BUILD/SETUP.sh

Thank you for a problem report. Yes, we have:

alpha_cflags="$check_cpu_cflags -Wa,-m$cpu_flag"
amd64_cflags="$check_cpu_cflags"
amd64_cxxflags=""  # If dropping '--with-big-tables', add here  "-DBIG_TABLES"
pentium64_cflags="$check_cpu_cflags -m64"
ppc_cflags="$check_cpu_cflags"
sparc_cflags=""

but no pentium_cflags="$check_cpu_cflags" in SETUP.sh. 

I think, it is a bug.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/17460

ChangeSet@1.2372, 2006-12-29 16:15:12+01:00, df@kahlann.erinye.com +1 -0
  BUG#20013 No pentium_cflags in SETUP.sh

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/20580

ChangeSet@1.2457, 2007-02-26 17:06:10+01:00, df@pippilotta.erinye.com +1 -0
  BUG#20013 No pentium_cflags in SETUP.sh
  ---
  Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build-work-20013
  into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build
  ---
  reorder lines from BUG#20013 to resemble order in 5.0

No changelog entry needed.