Bug #18495 mysqltest does not use the correct error number

• Submitted: 24 Mar 2006 17:37
• Modified: 4 May 2006 17:07
• Reporter: Andrey Hristov
• Status: Closed
• Category: MySQL Server
• Severity: S3 (Non-critical)
• Version: 5.1.8
• Assigned to: Jim Winstead
• CPU Architecture: Any

[24 Mar 2006 17:37] Andrey Hristov

Description:
Using of error names in the tests is a good practice but there is a but specifically for ER_WRONG_VALUE (1504 currently) which is being resolved from the test suite as ER_WRONG_VALUE_COUNT (1058)

How to repeat:

[22 Apr 2006 1:01] Jim Winstead

mysqltest resolves the error numbers in .test files, not mysql-test-run.pl.

problem is around line 1804 of mysqltest.c (in 5.0), where it ends up doing:
  strncmp("ER_WRONG_VALUE", "ER_WRONG_VALUE_COUNT", strlen("ER_WRONG_VALUE"))

we should first check that we are comparing against an error message name of the correct length.

[22 Apr 2006 2:28] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/5331

[2 May 2006 18:26] Jim Winstead

Fixed in 5.1.10.

[4 May 2006 17:07] Paul DuBois

Noted in 5.1.10 changelog.

<command>mysqltest</command> incorrectly interpreted some
<literal>ER_<replaceable>xxx</replaceable></literal> error
names given in the <literal>error</literal> command. (Bug
#18495)