Bug #117078 backupProfiles[].dumpInstance.dumpOptions not set by mysql-innodbcluster helm chart
Submitted: 30 Dec 2024 16:15 Modified: 31 Dec 2024 5:04
Reporter: Martin Fleurke (OCA) Email Updates:
Status: Verified Impact on me:
None 
Category:MySQL Operator Severity:S4 (Feature request)
Version:9.1.0-2.2.2 OS:Any
Assigned to: CPU Architecture:Any

[30 Dec 2024 16:15] Martin Fleurke
Description:
The innodbclusters.mysql.oracle.com CRD allows you to set the options for creating a dump, under backupProfiles[].dumpInstance.dumpOptions.

The mysql-innodbcluster helm chart does not support setting a value for this.
The created innodbclusters CRD does not have that field.

How to repeat:
helm install mycluster mysql-operator/mysql-innodbcluster

Suggested fix:
the helm chart copies the values from values.yaml 
backupProfiles:
- dumpInstance:
    dumpOptions:
      whateveroption: whatevervalue

into the CRD.

deployment_cluster.yaml needs to be improved.

        {{- if $isDumpInstance }}
      dumpInstance:
        {{- else if $isSnapshot }}

should become something like (untested)

        {{- if $isDumpInstance }}
    dumpInstance:
      {{- if $profile.backupProfile.dumpOptions }}
      dumpOptions:
        {{ $profile.backupProfile.dumpOptions.toYaml | indent 8 }}
      {{- end }}
        {{- else if $isSnapshot }}
[30 Dec 2024 17:07] Martin Fleurke
improve synopsis
[30 Dec 2024 17:11] Martin Fleurke
pull request https://github.com/mysql/mysql-operator/pull/37 solves this issue
[31 Dec 2024 5:04] MySQL Verification Team
Hello Martin Fleurke,

Thank you for the feature request!

regards,
Umesh
[6 Jan 16:23] OCA Admin
Contribution submitted via Github - Fix for Bug#117078: backupProfiles[].dumpInstance.dumpOptions not set by mysql-i 
(*) Contribution by Martin Fleurke (Github amfleurke, mysql-operator/pull/37#issuecomment-2573289388): "I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."

Contribution: git_patch_2255671610.txt (text/plain), 8.93 KiB.