MySQL Bugs: #111375: Assertion `ha_alter_info->handler_flags & (Alter_inplace_info::ADD_VIRTUAL

Bug #111375	Assertion `ha_alter_info->handler_flags & (Alter_inplace_info::ADD_VIRTUAL_COLUM
Submitted:	13 Jun 2023 2:33	Modified:	13 Jun 2023 7:39
Reporter:	Yu Liang	Email Updates:
Status:	Verified	Impact on me:	None
Category:	MySQL Server: DDL	Severity:	S6 (Debug Builds)
Version:	8.0.33	OS:	Ubuntu (20.04 LTS)
Assigned to:		CPU Architecture:	x86 (Intel(R) Core(TM) i7-10700 CPU)

Description:
The latest version of the MySQL Server (version 8.0.33) (git commit hash: ea7087d8850) crashes with Assertion Failure when executing the following query:

Config from "/etc/mysql/conf.d/mysql.cnf":

```
[mysqld]
sql_mode = "NO_ENGINE_SUBSTITUTION"
```

```sql
drop database if exists test123;
create database test123;
use test123;
CREATE TABLE IF NOT EXISTS v0 ( v1 INT )  ;
ALTER TABLE v0 ADD COLUMN ( CHECK ( TRUE ) NOT ENFORCED ) ;
```

The last query returns error: 

```
mysql> ALTER TABLE v0 ADD COLUMN ( CHECK ( TRUE ) NOT ENFORCED ) ;
mysqld: /home/mysql/mysql-server/sql/sql_table.cc:12184: bool fill_alter_inplace_info(THD *, TABLE *, Alter_inplace_info *): Assertion `ha_alter_info->handler_flags & (Alter_inplace_info::ADD_VIRTUAL_COLUMN | Alter_inplace_info::ADD_STORED_BASE_COLUMN | Alter_inplace_info::ADD_STORED_GENERATED_COLUMN)' failed.
2023-06-13T01:15:36Z UTC - mysqld got signal 6 ;
Most likely, you have hit a bug, but this error can also be caused by malfunctioning hardware.
BuildID[sha1]=1d55d4671b7469352fc317efb0121b604c26443d
Thread pointer: 0xffff10001040
Attempting backtrace. You can use the following information to find out
where mysqld died. If you see no messages after this, something went
terribly wrong...
stack_bottom = ffffac469538 thread_stack 0x100000
/home/mysql/mysql-server/bld/runtime_output_directory/mysqld(my_print_stacktrace(unsigned char const*, unsigned long)+0x60) [0x4e6bc30]
/home/mysql/mysql-server/bld/runtime_output_directory/mysqld(print_fatal_signal(int)+0x340) [0x1a89320]
/home/mysql/mysql-server/bld/runtime_output_directory/mysqld(handle_fatal_signal+0x16c) [0x1a896dc]
linux-vdso.so.1(__kernel_rt_sigreturn+0) [0xffffb63107a0]
/lib/aarch64-linux-gnu/libc.so.6(gsignal+0xe0) [0xffffb5984d78]
/lib/aarch64-linux-gnu/libc.so.6(abort+0x114) [0xffffb5971aac]
/lib/aarch64-linux-gnu/libc.so.6(+0x2d490) [0xffffb597e490]
/lib/aarch64-linux-gnu/libc.so.6(+0x2d4f4) [0xffffb597e4f4]
/home/mysql/mysql-server/bld/runtime_output_directory/mysqld() [0x1837378]
/home/mysql/mysql-server/bld/runtime_output_directory/mysqld(mysql_alter_table(THD*, char const*, char const*, HA_CREATE_INFO*, Table_ref*, Alter_info*)+0x1525c) [0x181cb74]
/home/mysql/mysql-server/bld/runtime_output_directory/mysqld(Sql_cmd_alter_table::execute(THD*)+0x834) [0x255df74]
/home/mysql/mysql-server/bld/runtime_output_directory/mysqld(mysql_execute_command(THD*, bool)+0x281c) [0x162bcd8]
/home/mysql/mysql-server/bld/runtime_output_directory/mysqld(dispatch_sql_command(THD*, Parser_state*)+0x1124) [0x16252c0]
/home/mysql/mysql-server/bld/runtime_output_directory/mysqld(dispatch_command(THD*, COM_DATA const*, enum_server_command)+0x5434) [0x161e224]
/home/mysql/mysql-server/bld/runtime_output_directory/mysqld(do_command(THD*)+0xb8c) [0x16228f4]
/home/mysql/mysql-server/bld/runtime_output_directory/mysqld() [0x1a59a64]
/home/mysql/mysql-server/bld/runtime_output_directory/mysqld() [0x655c1a0]
/lib/aarch64-linux-gnu/libpthread.so.0(+0x7624) [0xffffb62b6624]
/lib/aarch64-linux-gnu/libc.so.6(+0xd149c) [0xffffb5a2249c]

Trying to get some variables.
Some pointers may be invalid and cause the dump to abort.
Query (ffff100243c0): ALTER TABLE v0 ADD COLUMN ( CHECK ( TRUE ) NOT ENFORCED )
Connection ID (thread ID): 8
Status: NOT_KILLED
```

How to repeat:
Steps to repeat the Assertion Failure:
1. Download the MySQL Server source code from the official github repo: `https://github.com/mysql/mysql-server`
2. Checkout to the latest mysql released version: 8.0.33 (hash: `ea7087d8850`)
3. Compile MySQL using the command: 

```
mkdir -p bld
cd bld
cmake .. -DDOWNLOAD_BOOST=1 -DWITH_BOOST=../boost -DWITH_UNIT_TESTS=OFF -DUSE_LD_GOLD=1 -DWITH_DEBUG=1
make
```

4. Run the MySQL Server with command: 

```
./bin/mysqld --basedir=$(pwd) --datadir=$(pwd)/data_all/ori_data --port=7000  --socket=/tmp/mysql_0.sock --mysqlx=OFF --performance_schema=OFF
```

5. Setup the MySQL Server config in the path: "/etc/mysql/conf.d/mysql.cnf"

```
[mysqld]
sql_mode = "NO_ENGINE_SUBSTITUTION"
```

6. Run the MySQL Client with the PoC:

```
./bin/mysql --port=7000 --user=root --socket=/tmp/mysql_0.sock < poc_0.sql
```

where `poc_0.sql` is:

```sql
drop database if exists test123;
create database test123;
use test123;
CREATE TABLE IF NOT EXISTS v0 ( v1 INT )  ;
ALTER TABLE v0 ADD COLUMN ( CHECK ( TRUE ) NOT ENFORCED ) ;
```

Suggested fix:
The server should continue running instead of crashing by Assertion Failure.

Hello Yu Liang,

Thank you for the report and test case.
Observed that 8.0.33 only debug build is affected.

regards,
Umesh

-- release build

 ./mtr bug111375 --nocheck-testcases
Logging: ./mtr  bug111375 --nocheck-testcases
MySQL Version 8.0.33
Checking supported features
Using 'all' suites
Collecting tests
Checking leftover processes
Removing old var directory
Creating var directory '/export/home/tmp/ushastry/binaries/mysql-8.0.33/mysql-test/var'
Installing system database
Using parallel: 1

==============================================================================
                  TEST NAME                       RESULT  TIME (ms) COMMENT
------------------------------------------------------------------------------
drop database if exists test123;
Warnings:
Note    1008    Can't drop database 'test123'; database doesn't exist
create database test123;
use test123;
CREATE TABLE IF NOT EXISTS v0 ( v1 INT )  ;
ALTER TABLE v0 ADD COLUMN ( CHECK ( TRUE ) NOT ENFORCED ) ;
[ 50%] main.bug111375                            [ pass ]     93
[100%] shutdown_report                           [ pass ]

-- debug build - affected
 ./mtr bug111375 --nocheck-testcases --debug-server
Logging: ./mtr  bug111375 --nocheck-testcases --debug-server
MySQL Version 8.0.33
Checking supported features
 - Binaries are debug compiled
Using 'all' suites
Collecting tests
Checking leftover processes
Removing old var directory
Creating var directory '/export/home/tmp/ushastry/binaries/mysql-8.0.33/mysql-test/var'
Installing system database
Using parallel: 1

==============================================================================
                  TEST NAME                       RESULT  TIME (ms) COMMENT
------------------------------------------------------------------------------
drop database if exists test123;
Warnings:
Note    1008    Can't drop database 'test123'; database doesn't exist
create database test123;
use test123;
CREATE TABLE IF NOT EXISTS v0 ( v1 INT )  ;
ALTER TABLE v0 ADD COLUMN ( CHECK ( TRUE ) NOT ENFORCED ) ;
[ 50%] main.bug111375                            [ fail ]
        Test ended at 2023-06-13 09:38:13

CURRENT_TEST: main.bug111375
mysqltest: At line 5: Query 'ALTER TABLE v0 ADD COLUMN ( CHECK ( TRUE ) NOT ENFORCED ) ' failed.
ERROR 2013 (HY000): Lost connection to MySQL server during query

-bt

#0  0x00007f8c6466daa1 in pthread_kill () from /lib64/libpthread.so.0
#1  0x0000000004005426 in my_write_core(int) ()
#2  0x00000000032b0166 in handle_fatal_signal ()
#3  <signal handler called>
#4  0x00007f8c62b2e387 in raise () from /lib64/libc.so.6
#5  0x00007f8c62b2fa78 in abort () from /lib64/libc.so.6
#6  0x00007f8c62b271a6 in __assert_fail_base () from /lib64/libc.so.6
#7  0x00007f8c62b27252 in __assert_fail () from /lib64/libc.so.6
#8  0x00000000031d2f3d in fill_alter_inplace_info(THD*, TABLE*, Alter_inplace_info*) ()
#9  0x00000000031e0ccc in mysql_alter_table(THD*, char const*, char const*, HA_CREATE_INFO*, Table_ref*, Alter_info*) ()
#10 0x00000000035e7faa in Sql_cmd_alter_table::execute(THD*) ()
#11 0x000000000313f789 in mysql_execute_command(THD*, bool) ()
#12 0x0000000003140bc8 in dispatch_sql_command(THD*, Parser_state*) ()
#13 0x00000000031421fb in dispatch_command(THD*, COM_DATA const*, enum_server_command) ()
#14 0x0000000003143e97 in do_command(THD*) ()
#15 0x00000000032a219e in handle_connection ()
#16 0x00000000047b1601 in pfs_spawn_thread ()
#17 0x00007f8c64668ea5 in start_thread () from /lib64/libpthread.so.0
#18 0x00007f8c62bf6b2d in clone () from /lib64/libc.so.6